Support disabling chat panel always on top

Author: intitni

Core/Sources/HostApp/FeatureSettings/Chat/ChatSettingsGeneralSectionView.swift

@@ -25,6 +25,7 @@ struct ChatSettingsGeneralSectionView: View {
         @AppStorage(\.chatModels) var chatModels
         @AppStorage(\.embeddingModels) var embeddingModels
         @AppStorage(\.wrapCodeInChatCodeBlock) var wrapCodeInCodeBlock
+        @AppStorage(\.alwaysDisableFloatOnTopForChatPanel) var alwaysDisableFloatOnTopForChatPanel
         @AppStorage(
             \.keepFloatOnTopIfChatPanelAndXcodeOverlaps
         ) var keepFloatOnTopIfChatPanelAndXcodeOverlaps
@@ -298,13 +299,21 @@ struct ChatSettingsGeneralSectionView: View {
 
             CodeHighlightThemePicker(scenario: .chat)
 
+            Toggle(isOn: $settings.alwaysDisableFloatOnTopForChatPanel) {
+                Text("Always disable always-on-top.")
+            }
+
             Toggle(isOn: $settings.disableFloatOnTopWhenTheChatPanelIsDetached) {
                 Text("Disable always-on-top when the chat panel is detached")
-            }
+            }.disabled(settings.alwaysDisableFloatOnTopForChatPanel)
 
             Toggle(isOn: $settings.keepFloatOnTopIfChatPanelAndXcodeOverlaps) {
                 Text("Keep always-on-top if the chat panel and Xcode overlaps and Xcode is active")
-            }.disabled(!settings.disableFloatOnTopWhenTheChatPanelIsDetached)
+            }
+            .disabled(
+                !settings.disableFloatOnTopWhenTheChatPanelIsDetached
+                    || settings.alwaysDisableFloatOnTopForChatPanel
+            )
         }
     }
 

Core/Sources/SuggestionWidget/ChatPanelWindow.swift

@@ -20,9 +20,9 @@ final class ChatPanelWindow: WidgetWindow {
     override var defaultCollectionBehavior: NSWindow.CollectionBehavior {
         [
             .fullScreenAuxiliary,
-            .transient,
             .fullScreenPrimary,
             .fullScreenAllowsTiling,
+            .participatesInCycle
         ]
     }
 

Core/Sources/SuggestionWidget/WidgetWindowsController.swift

@@ -533,10 +533,18 @@ extension WidgetWindowsController {
 
     @MainActor
     func adjustChatPanelWindowLevel() async {
+        let alwaysDisableChatPanelFlowOnTop = UserDefaults.shared
+            .value(for: \.alwaysDisableFloatOnTopForChatPanel)
         let disableFloatOnTopWhenTheChatPanelIsDetached = UserDefaults.shared
             .value(for: \.disableFloatOnTopWhenTheChatPanelIsDetached)
 
         let window = windows.chatPanelWindow
+        
+        if alwaysDisableChatPanelFlowOnTop {
+            window.setFloatOnTop(false)
+            return
+        }
+        
         guard disableFloatOnTopWhenTheChatPanelIsDetached else {
             window.setFloatOnTop(true)
             return
@@ -587,7 +595,7 @@ extension WidgetWindowsController {
         let activeXcode = await XcodeInspector.shared.safe.activeXcode
 
         let xcode = activeXcode?.appElement
-        
+
         let isXcodeActive = xcode?.isFrontmost ?? false
 
         [
@@ -600,7 +608,7 @@ extension WidgetWindowsController {
                 $0.moveToActiveSpace()
             }
         }
-        
+
         if isXcodeActive, !windows.chatPanelWindow.isDetached {
             windows.chatPanelWindow.moveToActiveSpace()
         }
@@ -867,7 +875,7 @@ class WidgetWindow: CanBecomeKeyWindow {
             }
         }
     }
-    
+
     func moveToActiveSpace() {
         let previousState = state
         state = .switchingSpace

Tool/Sources/Preferences/Keys.swift

@@ -195,11 +195,11 @@ public extension UserDefaultPreferenceKeys {
     var gitHubCopilotPretendIDEToBeVSCode: PreferenceKey<Bool> {
         .init(defaultValue: false, key: "GitHubCopilotPretendIDEToBeVSCode")
     }
-    
+
     var gitHubCopilotModelId: PreferenceKey<String> {
         .init(defaultValue: "", key: "GitHubCopilotModelId")
     }
-    
+
     var gitHubCopilotModelFamily: PreferenceKey<String> {
         .init(defaultValue: "", key: "GitHubCopilotModelFamily")
     }
@@ -478,11 +478,15 @@ public extension UserDefaultPreferenceKeys {
     var preferredChatModelIdForWebScope: PreferenceKey<String> {
         .init(defaultValue: "", key: "PreferredChatModelIdForWebScope")
     }
-    
+
     var preferredChatModelIdForUtilities: PreferenceKey<String> {
         .init(defaultValue: "", key: "PreferredChatModelIdForUtilities")
     }
 
+    var alwaysDisableFloatOnTopForChatPanel: PreferenceKey<Bool> {
+        .init(defaultValue: false, key: "AlwaysDisableFloatOnTopForChatPanel")
+    }
+
     var disableFloatOnTopWhenTheChatPanelIsDetached: PreferenceKey<Bool> {
         .init(defaultValue: true, key: "DisableFloatOnTopWhenTheChatPanelIsDetached")
     }
@@ -494,7 +498,7 @@ public extension UserDefaultPreferenceKeys {
     var openChatMode: PreferenceKey<UserDefaultsStorageBox<OpenChatMode>> {
         .init(defaultValue: .init(.chatPanel), key: "DefaultOpenChatMode")
     }
-    
+
     var legacyOpenChatMode: DeprecatedPreferenceKey<OpenChatMode.LegacyOpenChatMode> {
         .init(defaultValue: .chatPanel, key: "OpenChatMode")
     }
@@ -731,7 +735,7 @@ public extension UserDefaultPreferenceKeys {
     var useCloudflareDomainNameForLicenseCheck: FeatureFlag {
         .init(defaultValue: false, key: "FeatureFlag-UseCloudflareDomainNameForLicenseCheck")
     }
-    
+
     var doNotInstallLaunchAgentAutomatically: FeatureFlag {
         .init(defaultValue: false, key: "FeatureFlag-DoNotInstallLaunchAgentAutomatically")
     }