From 5f3b050eb1308a6aafdd36ee72cec3b7f276462b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20Lohnisk=C3=BD?= Date: Thu, 3 Mar 2022 10:42:15 +0100 Subject: [PATCH 1/4] adt/base-query: adt-doctrine-components --- src/IQueryObjectDataSourceFactory.php | 6 +++--- src/QueryObjectDataSource.php | 12 ++++++------ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/IQueryObjectDataSourceFactory.php b/src/IQueryObjectDataSourceFactory.php index c073b8d..eb431e7 100644 --- a/src/IQueryObjectDataSourceFactory.php +++ b/src/IQueryObjectDataSourceFactory.php @@ -5,10 +5,10 @@ interface IQueryObjectDataSourceFactory { /** - * @param \Kdyby\Doctrine\QueryObject $queryObject - * @param \Kdyby\Doctrine\EntityRepository|null $repo + * @param \ADT\BaseQuery\QueryObject $queryObject + * @param \Doctrine\ORM\EntityRepository|null $repo * @return QueryObjectDataSource */ - function create(\Kdyby\Doctrine\QueryObject $queryObject, \Kdyby\Doctrine\EntityRepository $repo = null); + function create(\ADT\BaseQuery\QueryObject $queryObject, \Doctrine\ORM\EntityRepository $repo = null); } diff --git a/src/QueryObjectDataSource.php b/src/QueryObjectDataSource.php index 7067332..40f31d2 100644 --- a/src/QueryObjectDataSource.php +++ b/src/QueryObjectDataSource.php @@ -13,13 +13,13 @@ class QueryObjectDataSource implements IDataSource { use \Nette\SmartObject; - /** @var \Kdyby\Doctrine\ResultSet */ + /** @var \ADT\BaseQuery\ResultSet */ protected $resultSet; - /** @var \Kdyby\Doctrine\EntityRepository */ + /** @var \Doctrine\ORM\EntityRepository */ protected $repo; - /** @var \Kdyby\Doctrine\QueryObject|IQueryObject */ + /** @var \ADT\BaseQuery\QueryObject|IQueryObject */ protected $queryObject; /** @var callable */ @@ -39,11 +39,11 @@ class QueryObjectDataSource implements IDataSource { /** * QueryObjectDataSource constructor. - * @param \Kdyby\Doctrine\QueryObject $queryObject - * @param \Kdyby\Doctrine\EntityRepository|null $repo + * @param \ADT\BaseQuery\QueryObject $queryObject + * @param \Doctrine\ORM\EntityRepository|null $repo * @throws \Exception */ - public function __construct(\Kdyby\Doctrine\QueryObject $queryObject, \Kdyby\Doctrine\EntityRepository $repo = null) + public function __construct(\ADT\BaseQuery\QueryObject $queryObject, \Doctrine\ORM\EntityRepository $repo = null) { if (!$repo && (!$queryObject instanceof IQueryObject)) { throw new \Exception('"repo" must be set or "queryObject" has to implement IQueryObject interface.'); From de11f6c757b0818e754413141ba2529937f2f151 Mon Sep 17 00:00:00 2001 From: Marek Valuch Date: Tue, 12 Apr 2022 18:02:20 +0200 Subject: [PATCH 2/4] Calling fetch on QueryObject instead repository --- src/QueryObjectDataSource.php | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/QueryObjectDataSource.php b/src/QueryObjectDataSource.php index 40f31d2..ead517c 100644 --- a/src/QueryObjectDataSource.php +++ b/src/QueryObjectDataSource.php @@ -94,8 +94,7 @@ public function setLimitCallback($callback) { protected function getResultSet() { if (!$this->resultSet) { - $this->resultSet = $this->repo - ->fetch($this->queryObject); + $this->resultSet = $this->queryObject->fetch(); } return $this->resultSet; @@ -106,9 +105,7 @@ protected function getResultSet() { * @return int */ public function getCount(): int { - return $this->repo - ->fetch($this->queryObject) - ->getTotalCount(); + return $this->queryObject->fetch()->getTotalCount(); } /** From db13f06569b852d86a6d5b71ec469cb11d916ee6 Mon Sep 17 00:00:00 2001 From: Tomas Kudelka Date: Sun, 15 May 2022 11:58:30 +0200 Subject: [PATCH 3/4] dodelavky --- composer.json | 18 ++++++------------ src/IQueryObjectDataSourceFactory.php | 4 ++-- src/QueryObjectDataSource.php | 16 +++++++--------- 3 files changed, 15 insertions(+), 23 deletions(-) diff --git a/composer.json b/composer.json index 8dc58f1..fb59ee8 100644 --- a/composer.json +++ b/composer.json @@ -1,21 +1,15 @@ { "name": "adt/query-object-data-source", - "description": "Ublaboo Datagrid data source bindings for Kdyby Doctrine query objects.", + "description": "Ublaboo Datagrid data source bindings for adt/doctrine-components query objects.", "type": "library", "license": [ - "MIT", - "BSD-3-Clause", - "GPL-2.0", - "GPL-3.0" + "MIT" ], "require": { - "php": ">=7.1" - }, - "require-dev": { - "kdyby/doctrine": "^3.1 || ~4.0", - "ublaboo/datagrid": "^5.0 || ~6.0", - "nette/utils": "^2.4 || ~3.0", - "nette/di": "^2.4 || ~3.0" + "php": ">=7.4", + "adt/base-query": "^2.0", + "ublaboo/datagrid": "^6.0", + "nette/di": "^2.4|^3.0" }, "autoload": { "psr-4": { diff --git a/src/IQueryObjectDataSourceFactory.php b/src/IQueryObjectDataSourceFactory.php index eb431e7..b08ef93 100644 --- a/src/IQueryObjectDataSourceFactory.php +++ b/src/IQueryObjectDataSourceFactory.php @@ -5,10 +5,10 @@ interface IQueryObjectDataSourceFactory { /** - * @param \ADT\BaseQuery\QueryObject $queryObject + * @param \ADT\DoctrineComponents\QueryObject $queryObject * @param \Doctrine\ORM\EntityRepository|null $repo * @return QueryObjectDataSource */ - function create(\ADT\BaseQuery\QueryObject $queryObject, \Doctrine\ORM\EntityRepository $repo = null); + function create(\ADT\DoctrineComponents\QueryObject $queryObject, \Doctrine\ORM\EntityRepository $repo = null); } diff --git a/src/QueryObjectDataSource.php b/src/QueryObjectDataSource.php index ead517c..0faffe3 100644 --- a/src/QueryObjectDataSource.php +++ b/src/QueryObjectDataSource.php @@ -9,17 +9,15 @@ use Ublaboo\DataGrid\Utils\DateTimeHelper; use Ublaboo\DataGrid\DataSource\IDataSource; -class QueryObjectDataSource implements IDataSource { - - use \Nette\SmartObject; - - /** @var \ADT\BaseQuery\ResultSet */ +class QueryObjectDataSource implements IDataSource +{ + /** @var \ADT\DoctrineComponents\ResultSet */ protected $resultSet; /** @var \Doctrine\ORM\EntityRepository */ protected $repo; - /** @var \ADT\BaseQuery\QueryObject|IQueryObject */ + /** @var \ADT\DoctrineComponents\QueryObject|IQueryObject */ protected $queryObject; /** @var callable */ @@ -39,11 +37,11 @@ class QueryObjectDataSource implements IDataSource { /** * QueryObjectDataSource constructor. - * @param \ADT\BaseQuery\QueryObject $queryObject + * @param \ADT\DoctrineComponents\QueryObject $queryObject * @param \Doctrine\ORM\EntityRepository|null $repo * @throws \Exception */ - public function __construct(\ADT\BaseQuery\QueryObject $queryObject, \Doctrine\ORM\EntityRepository $repo = null) + public function __construct(\ADT\DoctrineComponents\QueryObject $queryObject, \Doctrine\ORM\EntityRepository $repo = null) { if (!$repo && (!$queryObject instanceof IQueryObject)) { throw new \Exception('"repo" must be set or "queryObject" has to implement IQueryObject interface.'); @@ -173,7 +171,7 @@ public function filterOne(array $filter): IDataSource { * @param int $limit * @return static */ - public function limit($offset, $limit): IDataSource { + public function limit(int $offset, int $limit): IDataSource { $defaultCallback = function () use ($offset, $limit) { $this->getResultSet()->applyPaging($offset, $limit); }; From c556c9209e7de4d98b710cec54ff6d6c32dbdeeb Mon Sep 17 00:00:00 2001 From: Tomas Kudelka Date: Sun, 15 May 2022 11:59:32 +0200 Subject: [PATCH 4/4] dodelavky --- composer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/composer.json b/composer.json index fb59ee8..4508d77 100644 --- a/composer.json +++ b/composer.json @@ -1,6 +1,6 @@ { "name": "adt/query-object-data-source", - "description": "Ublaboo Datagrid data source bindings for adt/doctrine-components query objects.", + "description": "Ublaboo Datagrid data source bindings for adt/base-query query objects.", "type": "library", "license": [ "MIT"