Fix settings in app

Author: intitni

Copilot for Xcode/App.swift

@@ -1,4 +1,5 @@
 import SwiftUI
+import XPCShared
 
 @main
 struct CopilotForXcodeApp: App {
@@ -7,6 +8,9 @@ struct CopilotForXcodeApp: App {
             ContentView()
                 .frame(minWidth: 500, minHeight: 700)
                 .preferredColorScheme(.dark)
+                .onAppear {
+                    UserDefaults.setupDefaultSettings()
+                }
         }
         .windowStyle(.hiddenTitleBar)
     }

Copilot for Xcode/SettingsView.swift

@@ -2,7 +2,7 @@ import LaunchAgentManager
 import SwiftUI
 import XPCShared
 
-struct SettingsView: View {
+final class Settings: ObservableObject {
     @AppStorage(SettingsKey.quitXPCServiceOnXcodeAndAppQuit, store: .shared)
     var quitXPCServiceOnXcodeAndAppQuit: Bool = false
     @AppStorage(SettingsKey.realtimeSuggestionToggle, store: .shared)
@@ -11,18 +11,24 @@ struct SettingsView: View {
     var realtimeSuggestionDebounce: Double = 0.7
     @AppStorage(SettingsKey.suggestionPresentationMode, store: .shared)
     var suggestionPresentationModeRawValue: Int = 0
+    init() {}
+}
+
+#warning("MUSTDO: Settings are not synced.")
+struct SettingsView: View {
+    @StateObject var settings = Settings()
     @State var editingRealtimeSuggestionDebounce: Double = UserDefaults.shared
         .value(forKey: SettingsKey.realtimeSuggestionDebounce) as? Double ?? 0.7
-
+    
     var body: some View {
         Section {
             Form {
-                Toggle(isOn: $quitXPCServiceOnXcodeAndAppQuit) {
+                Toggle(isOn: $settings.quitXPCServiceOnXcodeAndAppQuit) {
                     Text("Quit service when Xcode and host app are terminated")
                 }
                 .toggleStyle(.switch)
 
-                Picker(selection: $suggestionPresentationModeRawValue) {
+                Picker(selection: $settings.suggestionPresentationModeRawValue) {
                     ForEach(PresentationMode.allCases, id: \.rawValue) {
                         switch $0 {
                         case .comment:
@@ -34,8 +40,8 @@ struct SettingsView: View {
                 } label: {
                     Text("Present suggestions in")
                 }
-                
-                Toggle(isOn: $realtimeSuggestionToggle) {
+
+                Toggle(isOn: $settings.realtimeSuggestionToggle) {
                     Text("Real-time suggestion")
                 }
                 .toggleStyle(.switch)
@@ -44,7 +50,7 @@ struct SettingsView: View {
                     Slider(value: $editingRealtimeSuggestionDebounce, in: 0...2, step: 0.1) {
                         Text("Real-time suggestion fetch debounce")
                     } onEditingChanged: { _ in
-                        realtimeSuggestionDebounce = editingRealtimeSuggestionDebounce
+                        settings.realtimeSuggestionDebounce = editingRealtimeSuggestionDebounce
                     }
 
                     Text(

Core/Sources/XPCShared/UserDefaults.swift

@@ -2,6 +2,18 @@ import Foundation
 
 public extension UserDefaults {
     static var shared = UserDefaults(suiteName: "5YKZ4Y3DAW.group.com.intii.CopilotForXcode")!
+    
+    static func setupDefaultSettings() {
+        func setDefaultValue<T>(_ value: T, forKey: String) {
+            let userDefaults = UserDefaults.shared
+            if userDefaults.value(forKey: forKey) == nil {
+                userDefaults.set(value, forKey: forKey)
+            }
+        }
+        setDefaultValue(true, forKey: SettingsKey.quitXPCServiceOnXcodeAndAppQuit)
+        setDefaultValue(false, forKey: SettingsKey.realtimeSuggestionToggle)
+        setDefaultValue(1 as Double, forKey: SettingsKey.realtimeSuggestionDebounce)
+    }
 }
 
 public enum SettingsKey {

ExtensionService/AppDelegate.swift

@@ -23,7 +23,7 @@ class AppDelegate: NSObject, NSApplicationDelegate, NSWindowDelegate {
         _ = GraphicalUserInterfaceController.shared
         // setup real-time suggestion controller
         _ = RealtimeSuggestionController.shared
-        setupDefaultSettings()
+        UserDefaults.setupDefaultSettings()
         setupQuitOnUpdate()
         setupQuitOnUserTerminated()
         xpcListener = setupXPCListener()
@@ -178,18 +178,6 @@ class AppDelegate: NSObject, NSApplicationDelegate, NSWindowDelegate {
         listener.resume()
         return (listener, delegate)
     }
-    
-    func setupDefaultSettings() {
-        func setDefaultValue<T>(_ value: T, forKey: String) {
-            let userDefaults = UserDefaults.shared
-            if userDefaults.value(forKey: forKey) == nil {
-                userDefaults.set(value, forKey: forKey)
-            }
-        }
-        setDefaultValue(true, forKey: SettingsKey.quitXPCServiceOnXcodeAndAppQuit)
-        setDefaultValue(false, forKey: SettingsKey.realtimeSuggestionToggle)
-        setDefaultValue(1 as Double, forKey: SettingsKey.realtimeSuggestionDebounce)
-    }
 }
 
 private class UserDefaultsObserver: NSObject {