Move settings to chat settings view

Author: intitni

Core/Sources/HostApp/AccountSettings/OpenAIView.swift

@@ -1,31 +1,26 @@
 import AppKit
-import OpenAIService
 import Client
+import OpenAIService
 import Preferences
 import SuggestionModel
 import SwiftUI
 
-final class OpenAIViewSettings: ObservableObject {
-    static let availableLocalizedLocales = Locale.availableLocalizedLocales
-    @AppStorage(\.openAIAPIKey) var openAIAPIKey: String
-    @AppStorage(\.chatGPTModel) var chatGPTModel: String
-    @AppStorage(\.openAIBaseURL) var openAIBaseURL: String
-    @AppStorage(\.chatGPTLanguage) var chatGPTLanguage: String
-    @AppStorage(\.chatGPTMaxToken) var chatGPTMaxToken: Int
-    @AppStorage(\.chatGPTTemperature) var chatGPTTemperature: Double
-    @AppStorage(\.chatGPTMaxMessageCount) var chatGPTMaxMessageCount: Int
-    init() {}
-}
-
 struct OpenAIView: View {
+    final class Settings: ObservableObject {
+        @AppStorage(\.openAIAPIKey) var openAIAPIKey: String
+        @AppStorage(\.chatGPTModel) var chatGPTModel: String
+        @AppStorage(\.openAIBaseURL) var openAIBaseURL: String
+        init() {}
+    }
+    
     let apiKeyURL = URL(string: "https://platform.openai.com/account/api-keys")!
     let modelURL = URL(
         string: "https://platform.openai.com/docs/models/model-endpoint-compatibility"
     )!
     @Environment(\.openURL) var openURL
     @Environment(\.toast) var toast
-    @StateObject var settings = OpenAIViewSettings()
-    @State var maxTokenOverLimit = false
+    @State var isTesting = false
+    @StateObject var settings = Settings()
 
     var body: some View {
         Form {
@@ -50,7 +45,9 @@ struct OpenAIView: View {
                 }.textFieldStyle(.roundedBorder)
 
                 Button("Test") {
-                    Task {
+                    Task { @MainActor in
+                        isTesting = true
+                        defer { isTesting = false }
                         do {
                             let reply = try await ChatGPTService(designatedProvider: .openAI)
                                 .sendAndWait(content: "Hello", summary: nil)
@@ -59,7 +56,7 @@ struct OpenAIView: View {
                             toast(Text(error.localizedDescription), .error)
                         }
                     }
-                }
+                }.disabled(isTesting)
             }
 
             HStack {
@@ -81,119 +78,6 @@ struct OpenAIView: View {
                     Image(systemName: "questionmark.circle.fill")
                 }.buttonStyle(.plain)
             }
-
-            if #available(macOS 13.0, *) {
-                LabeledContent("Reply in Language") {
-                    languagePicker
-                }
-            } else {
-                HStack {
-                    Text("Reply in Language")
-                    languagePicker
-                }
-            }
-
-            let binding = Binding(
-                get: { String(settings.chatGPTMaxToken) },
-                set: {
-                    if let selectionMaxToken = Int($0) {
-                        if let model = ChatGPTModel(rawValue: settings.chatGPTModel) {
-                            maxTokenOverLimit = model.maxToken < selectionMaxToken
-                        } else {
-                            maxTokenOverLimit = false
-                        }
-                        settings.chatGPTMaxToken = selectionMaxToken
-                    } else {
-                        settings.chatGPTMaxToken = 0
-                    }
-                }
-            )
-            HStack {
-                Stepper(
-                    value: $settings.chatGPTMaxToken,
-                    in: 0...Int.max,
-                    step: 1
-                ) {
-                    Text("Max Token (Including Reply)")
-                        .multilineTextAlignment(.trailing)
-                }
-                TextField(text: binding) {
-                    EmptyView()
-                }
-                .labelsHidden()
-                .textFieldStyle(.roundedBorder)
-                .foregroundColor(maxTokenOverLimit ? .red : .primary)
-
-                if let model = ChatGPTModel(rawValue: settings.chatGPTModel) {
-                    Text("Max: \(model.maxToken)")
-                }
-            }
-
-            HStack {
-                Slider(value: $settings.chatGPTTemperature, in: 0...2, step: 0.1) {
-                    Text("Temperature")
-                }
-
-                Text(
-                    "\(settings.chatGPTTemperature.formatted(.number.precision(.fractionLength(1))))"
-                )
-                .font(.body)
-                .monospacedDigit()
-                .padding(.vertical, 2)
-                .padding(.horizontal, 6)
-                .background(
-                    RoundedRectangle(cornerRadius: 4, style: .continuous)
-                        .fill(Color.primary.opacity(0.1))
-                )
-            }
-
-            Picker(
-                "Memory",
-                selection: $settings.chatGPTMaxMessageCount
-            ) {
-                Text("No Limit").tag(0)
-                Text("3 Messages").tag(3)
-                Text("5 Messages").tag(5)
-                Text("7 Messages").tag(7)
-            }
-        }
-        .onAppear {
-            if let model = ChatGPTModel(rawValue: settings.chatGPTModel) {
-                maxTokenOverLimit = model.maxToken < settings.chatGPTMaxToken
-            }
-        }
-    }
-
-    var languagePicker: some View {
-        Menu {
-            if !settings.chatGPTLanguage.isEmpty,
-               !OpenAIViewSettings.availableLocalizedLocales
-               .contains(settings.chatGPTLanguage)
-            {
-                Button(
-                    settings.chatGPTLanguage,
-                    action: { self.settings.chatGPTLanguage = settings.chatGPTLanguage }
-                )
-            }
-            Button(
-                "Auto-detected by ChatGPT",
-                action: { self.settings.chatGPTLanguage = "" }
-            )
-            ForEach(
-                OpenAIViewSettings.availableLocalizedLocales,
-                id: \.self
-            ) { localizedLocales in
-                Button(
-                    localizedLocales,
-                    action: { self.settings.chatGPTLanguage = localizedLocales }
-                )
-            }
-        } label: {
-            Text(
-                settings.chatGPTLanguage.isEmpty
-                    ? "Auto-detected by ChatGPT"
-                    : settings.chatGPTLanguage
-            )
         }
     }
 }