refactor: cleanup some messages and type declarations

Author: AntoineGS

lua/copilot/client.lua

@@ -77,6 +77,7 @@ function M.buf_detach()
   end
 end
 
+---@return nil|vim.lsp.Client
 function M.get()
   return vim.lsp.get_client_by_id(M.id)
 end
@@ -170,7 +171,7 @@ end
 
 local function prepare_client_config(overrides)
   if lsp_binary_util.initialization_failed then
-    M.startup_error = "initializatino of copilot-language-server failed"
+    M.startup_error = "initialization of copilot-language-server failed"
     return
   end
 
@@ -297,7 +298,7 @@ end
 
 function M.setup()
   M.config = prepare_client_config(config.get("server_opts_overrides"))
-  M.should_attach = config.get("should_attach") --[[@as copilot_should_attach|nil]]
+  M.should_attach = config.get("should_attach") --[[@as copilot_should_attach]]
 
   if not M.config then
     is_disabled = true

lua/copilot/lsp_binary.lua

@@ -59,7 +59,7 @@ local function download_file(url, local_server_zip_filepath, local_server_zip_pa
   logger.notify("current version of copilot-language-server is not downloaded, downloading")
 
   if vim.fn.executable("curl") ~= 1 then
-    vim.api.nvim_err_writeln("Error: curl is not available")
+    logger.error("curl is not available, please install it to download copilot-language-server")
     M.initialization_failed = true
     return false
   end
@@ -165,7 +165,7 @@ function M.ensure_client_is_downloaded()
 
   local copilot_version = util.get_editor_info().editorPluginInfo.version
   local plugin_path = vim.fs.normalize(util.get_plugin_path())
-  local copilot_server_info = M.get_copilot_server_info(copilot_version, plugin_path)
+  local copilot_server_info = M.get_copilot_server_info()
   local download_filename =
     string.format("copilot-language-server-%s-%s.zip", copilot_server_info.path, copilot_version)
   local url = string.format(
@@ -199,7 +199,7 @@ function M.ensure_client_is_downloaded()
   end
 
   delete_all_except(copilot_server_info.absolute_path, copilot_server_info.filename)
-  logger.notify("copilot-language-server downloaded")
+  logger.notify(string.format("copilot-language-server v%s downloaded", copilot_version))
   return true
 end