From ddae9d45e692408169cb2dbe267badcc55b91ab2 Mon Sep 17 00:00:00 2001 From: ACTCD <101378590+ACTCD@users.noreply.github.com> Date: Tue, 22 Jul 2025 16:43:03 +0000 Subject: [PATCH 1/5] fix: cancel unnecessary state checks Avoid the inability to activate item[0] in the settings state, for example. --- src/ext/extension-page/Components/Sidebar/Sidebar.svelte | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ext/extension-page/Components/Sidebar/Sidebar.svelte b/src/ext/extension-page/Components/Sidebar/Sidebar.svelte index cc382adc..5ca2ff1d 100644 --- a/src/ext/extension-page/Components/Sidebar/Sidebar.svelte +++ b/src/ext/extension-page/Components/Sidebar/Sidebar.svelte @@ -81,8 +81,8 @@ } async function activate(item) { - // if not in ready state or the item is already active - if (!$v4state.includes("ready") || item.active) return; + // if item is empty or already active + if (!item || item.active) return; // check if there's a temp item and it's not the item to be activated // can occur when user clicks a non-temp item while a temp item exists From 8e6d9cd319a198d13d361db95bd7b3a45bbe050d Mon Sep 17 00:00:00 2001 From: ACTCD <101378590+ACTCD@users.noreply.github.com> Date: Tue, 22 Jul 2025 17:04:53 +0000 Subject: [PATCH 2/5] fix: reduce the z-index of splitter --- src/ext/extension-page/App.svelte | 4 ++-- src/ext/extension-page/Components/Sidebar/Sidebar.svelte | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ext/extension-page/App.svelte b/src/ext/extension-page/App.svelte index 90d396b4..ecdbdf52 100644 --- a/src/ext/extension-page/App.svelte +++ b/src/ext/extension-page/App.svelte @@ -168,7 +168,7 @@ cursor: col-resize; position: fixed; inset: 0; - z-index: 200; + z-index: 20; } .splitter { @@ -182,7 +182,7 @@ left: calc(var(--sidebar-fixed-width) - var(--splitter-offset)); width: var(--splitter-width); height: 100svh; - z-index: 201; + z-index: 21; transition: background-color 0.2s ease-in-out; &:hover, diff --git a/src/ext/extension-page/Components/Sidebar/Sidebar.svelte b/src/ext/extension-page/Components/Sidebar/Sidebar.svelte index 5ca2ff1d..c5af6b55 100644 --- a/src/ext/extension-page/Components/Sidebar/Sidebar.svelte +++ b/src/ext/extension-page/Components/Sidebar/Sidebar.svelte @@ -228,7 +228,7 @@ title="Open settings" {disabled} /> - + From 6bcab180bcb05e35d730993fbaa596eafdd7248f Mon Sep 17 00:00:00 2001 From: ACTCD <101378590+ACTCD@users.noreply.github.com> Date: Tue, 22 Jul 2025 17:05:46 +0000 Subject: [PATCH 3/5] fix: prevent hide sidebar when no item --- src/ext/extension-page/App.svelte | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/ext/extension-page/App.svelte b/src/ext/extension-page/App.svelte index ecdbdf52..98106604 100644 --- a/src/ext/extension-page/App.svelte +++ b/src/ext/extension-page/App.svelte @@ -66,6 +66,10 @@ const editorMinWidth = "20rem"; function sidebarSwitch() { + if (!sidebarHidden && !$items.find((i) => i.active)) { + log.add("Please select or create a new item first.", "info", true); + return; + } sidebarHidden = !sidebarHidden; } From bd3fb78a00248b512d158b3b6602880d68602228 Mon Sep 17 00:00:00 2001 From: ACTCD <101378590+ACTCD@users.noreply.github.com> Date: Tue, 22 Jul 2025 18:32:37 +0000 Subject: [PATCH 4/5] fix: hide splitter when sidebar is hidden --- src/ext/extension-page/App.svelte | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/ext/extension-page/App.svelte b/src/ext/extension-page/App.svelte index 98106604..22487e8f 100644 --- a/src/ext/extension-page/App.svelte +++ b/src/ext/extension-page/App.svelte @@ -105,14 +105,14 @@ > {#if !sidebarHidden} +
{/if} -
{#if splitterActive} From 73112a9b85ab9226ae2f4e49848944f9a9faeded Mon Sep 17 00:00:00 2001 From: ACTCD <101378590+ACTCD@users.noreply.github.com> Date: Tue, 22 Jul 2025 23:12:28 +0000 Subject: [PATCH 5/5] fix: reduce the z-index of empty mask --- .../extension-page/Components/Editor/Editor.svelte | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/src/ext/extension-page/Components/Editor/Editor.svelte b/src/ext/extension-page/Components/Editor/Editor.svelte index ef47d3b6..e0b7c719 100644 --- a/src/ext/extension-page/Components/Editor/Editor.svelte +++ b/src/ext/extension-page/Components/Editor/Editor.svelte @@ -255,19 +255,16 @@ } .editor__empty { - align-items: center; background-color: inherit; color: var(--text-color-disabled); - display: flex; font: var(--text-large); - height: 100%; - justify-content: center; - left: 0; letter-spacing: var(--letter-spacing-large); + display: flex; + place-content: center; + place-items: center; position: absolute; - top: 0; - width: 100%; - z-index: 85; + inset: 0; + z-index: 10; } .editor__header {