Prevent filespace of workspace files

Author: intitni

Tool/Sources/Workspace/Workspace.swift

@@ -66,6 +66,13 @@ public final class Workspace {
             "Can't find workspace."
         }
     }
+    
+    public struct CantFindFileError: Error, LocalizedError {
+        public var fileURL: URL
+        public var errorDescription: String? {
+            "Can't find \(fileURL)."
+        }
+    }
 
     private var additionalProperties = WorkspacePropertyValues()
     public internal(set) var plugins = [ObjectIdentifier: WorkspacePlugin]()
@@ -107,7 +114,7 @@ public final class Workspace {
         let openedFiles = openedFileRecoverableStorage.openedFiles
         Task { @WorkspaceActor in
             for fileURL in openedFiles {
-                _ = createFilespaceIfNeeded(fileURL: fileURL)
+                _ = try? createFilespaceIfNeeded(fileURL: fileURL)
             }
         }
     }
@@ -117,7 +124,19 @@ public final class Workspace {
     }
 
     @WorkspaceActor
-    public func createFilespaceIfNeeded(fileURL: URL) -> Filespace {
+    public func createFilespaceIfNeeded(fileURL: URL) throws -> Filespace {
+        let extensionName = fileURL.pathExtension
+        if ["xcworkspace", "xcodeproj"].contains(extensionName) {
+            throw UnsupportedFileError(extensionName: extensionName)
+        }
+        var isDirectory: ObjCBool = false
+        if !FileManager.default.fileExists(atPath: fileURL.path, isDirectory: &isDirectory) {
+            throw CantFindFileError(fileURL: fileURL)
+        }
+        if isDirectory.boolValue {
+            throw UnsupportedFileError(extensionName: extensionName)
+        }
+
         let existedFilespace = filespaces[fileURL]
         let filespace = existedFilespace ?? .init(
             fileURL: fileURL,

Tool/Sources/Workspace/WorkspacePool.swift

@@ -92,13 +92,13 @@ public class WorkspacePool {
         if let currentWorkspaceURL = await XcodeInspector.shared.safe.realtimeActiveWorkspaceURL {
             if let existed = workspaces[currentWorkspaceURL] {
                 // Reuse the existed workspace.
-                let filespace = existed.createFilespaceIfNeeded(fileURL: fileURL)
+                let filespace = try existed.createFilespaceIfNeeded(fileURL: fileURL)
                 return (existed, filespace)
             }
 
             let new = createNewWorkspace(workspaceURL: currentWorkspaceURL)
             workspaces[currentWorkspaceURL] = new
-            let filespace = new.createFilespaceIfNeeded(fileURL: fileURL)
+            let filespace = try new.createFilespaceIfNeeded(fileURL: fileURL)
             return (new, filespace)
         }
 
@@ -132,7 +132,7 @@ public class WorkspacePool {
                 return createNewWorkspace(workspaceURL: workspaceURL)
             }()
 
-            let filespace = workspace.createFilespaceIfNeeded(fileURL: fileURL)
+            let filespace = try workspace.createFilespaceIfNeeded(fileURL: fileURL)
             workspaces[workspaceURL] = workspace
             workspace.refreshUpdateTime()
             return (workspace, filespace)

Tool/Sources/WorkspaceSuggestionService/Workspace+SuggestionService.swift

@@ -33,7 +33,7 @@ public extension Workspace {
     ) async throws -> [CodeSuggestion] {
         refreshUpdateTime()
 
-        let filespace = createFilespaceIfNeeded(fileURL: fileURL)
+        let filespace = try createFilespaceIfNeeded(fileURL: fileURL)
 
         guard !(await filespace.isGitIgnored) else { return [] }