Fix reflection chat payload and ground Pine continuity

Author: TayDa64

scripts/test-bug-fixes.js

@@ -305,6 +305,27 @@ test('system prompt includes Pine diagnostics guidance', () => {
   assert(systemPromptContent.includes('TradingView shortcut profile rule'), 'System prompt should include TradingView shortcut-profile guidance');
 });
 
+test('reflection trigger builds provider-compatible chat messages', () => {
+  const reflectionTriggerPath = path.join(__dirname, '..', 'src', 'main', 'telemetry', 'reflection-trigger.js');
+  const reflectionTrigger = require(reflectionTriggerPath);
+
+  assert(typeof reflectionTrigger.buildReflectionMessages === 'function', 'Reflection trigger should expose chat-message builder');
+  const messages = reflectionTrigger.buildReflectionMessages([
+    {
+      task: 'Open TradingView alert dialog',
+      phase: 'execution',
+      actions: [{ type: 'key', key: 'alt+a' }],
+      verifier: { exitCode: 1, stderr: 'dialog not observed' },
+      context: { failedCount: 1 }
+    }
+  ]);
+
+  assert(Array.isArray(messages), 'Reflection trigger should return a message array');
+  assertEqual(messages[0].role, 'system', 'Reflection messages should begin with a system instruction');
+  assertEqual(messages[1].role, 'user', 'Reflection messages should include a user payload for providers that reject system-only chat requests');
+  assert(/Open TradingView alert dialog/i.test(messages[1].content), 'Reflection user payload should contain summarized failure context');
+});
+
 test('rewriteActionsForReliability does not reinterpret passive TradingView open-state prompts as app launches', () => {
   const aiServicePath = path.join(__dirname, '..', 'src', 'main', 'ai-service.js');
   const aiService = require(aiServicePath);
@@ -397,6 +418,8 @@ test('ai-service gates TradingView follow-up typing on post-key observation chec
   assert(systemPromptContent.includes('safe new-script / bounded-edit paths'), 'system prompt should guide Pine authoring toward safe new-script flows');
   assert(observationCheckpointContent.includes('active Pine Editor surface before continuing'), 'Observation checkpoint failures should explain missing active Pine Editor state');
   assert(tradingViewPineContent.includes('requiresEditorActivation'), 'TradingView Pine workflows should distinguish editor activation from generic panel visibility');
+  assert(tradingViewPineContent.includes("messageMentionsTradingViewShortcut(raw, 'open-pine-editor')"), 'TradingView Pine workflows should use shortcut-profile aliases for Pine Editor phrasing');
+  assert(tradingViewPineContent.includes('getPineSurfaceMatchTerms'), 'TradingView Pine workflows should expose alias-aware Pine surface match terms');
   assert(tradingViewVerificationContent.includes('pine editor'), 'TradingView checkpoints should ground Pine Editor workflows');
   assert(tradingViewVerificationContent.includes('depth of market'), 'TradingView checkpoints should ground DOM workflows');
   assert(tradingViewVerificationContent.includes('paper trading'), 'TradingView checkpoints should ground Paper Trading workflows');

scripts/test-session-intent-state.js

@@ -506,3 +506,58 @@ test('session intent continuity recommends targeted edits under Pine line-budget
 
   fs.rmSync(tempDir, { recursive: true, force: true });
 });
+
+test('session intent continuity surfaces Pine provenance summaries for continuation context', () => {
+  const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'liku-session-intent-'));
+  const stateFile = path.join(tempDir, 'session-intent-state.json');
+  const store = createSessionIntentStateStore({ stateFile });
+
+  const recorded = store.recordExecutedTurn({
+    userMessage: 'open pine version history in tradingview and summarize the top visible revision metadata',
+    executionIntent: 'Inspect visible Pine Version History provenance.',
+    committedSubgoal: 'Inspect top visible Pine Version History metadata',
+    actionPlan: [
+      { type: 'focus_window', title: 'TradingView', processName: 'tradingview' },
+      { type: 'key', key: 'alt+h', verifyKind: 'panel-visible', verifyTarget: 'pine-version-history' },
+      { type: 'get_text', text: 'Pine Version History' }
+    ],
+    results: [
+      { type: 'focus_window', success: true, message: 'focused' },
+      { type: 'key', success: true, message: 'version history opened' },
+      {
+        type: 'get_text',
+        success: true,
+        message: 'provenance inspected',
+        pineStructuredSummary: {
+          evidenceMode: 'provenance-summary',
+          compactSummary: 'latest=Revision 12 | revisions=3 | recency=recent-visible',
+          latestVisibleRevisionLabel: 'Revision 12',
+          latestVisibleRevisionNumber: 12,
+          latestVisibleRelativeTime: '5 minutes ago',
+          visibleRevisionCount: 3,
+          visibleRecencySignal: 'recent-visible',
+          topVisibleRevisions: [
+            { label: 'Revision 12', relativeTime: '5 minutes ago', revisionNumber: 12 },
+            { label: 'Revision 11', relativeTime: '1 hour ago', revisionNumber: 11 }
+          ]
+        }
+      }
+    ],
+    success: true,
+    verification: { status: 'verified' }
+  }, {
+    cwd: path.join(__dirname, '..')
+  });
+
+  const continuityContext = formatChatContinuityContext(recorded);
+  assert(continuityContext.includes('pineEvidenceMode: provenance-summary'));
+  assert(continuityContext.includes('pineCompactSummary: latest=Revision 12 | revisions=3 | recency=recent-visible'));
+  assert(continuityContext.includes('pineLatestVisibleRevisionLabel: Revision 12'));
+  assert(continuityContext.includes('pineLatestVisibleRevisionNumber: 12'));
+  assert(continuityContext.includes('pineLatestVisibleRelativeTime: 5 minutes ago'));
+  assert(continuityContext.includes('pineVisibleRevisionCount: 3'));
+  assert(continuityContext.includes('pineVisibleRecencySignal: recent-visible'));
+  assert(continuityContext.includes('pineTopVisibleRevisions: Revision 12 5 minutes ago #12 | Revision 11 1 hour ago #11'));
+
+  fs.rmSync(tempDir, { recursive: true, force: true });
+});

scripts/test-tradingview-pine-data-workflows.js

@@ -42,6 +42,16 @@ test('pine workflow recognizes pine editor status-output requests', () => {
   assert.strictEqual(intent.wantsEvidenceReadback, true);
 });
 
+test('pine workflow recognizes pine-editor alias phrasing', () => {
+  const intent = inferTradingViewPineIntent('open pine script editor in tradingview and read the visible compiler status', [
+    { type: 'key', key: 'ctrl+e' }
+  ]);
+
+  assert(intent, 'intent should be inferred');
+  assert.strictEqual(intent.surfaceTarget, 'pine-editor');
+  assert.strictEqual(intent.wantsEvidenceReadback, true);
+});
+
 test('pine workflow recognizes compile-result requests', () => {
   const intent = inferTradingViewPineIntent('open pine editor in tradingview and summarize the compile result', [
     { type: 'key', key: 'ctrl+e' }
@@ -84,6 +94,16 @@ test('pine workflow recognizes pine profiler evidence-gathering requests', () =>
   assert.strictEqual(intent.wantsEvidenceReadback, true);
 });
 
+test('pine workflow recognizes pine profiler alias phrasing', () => {
+  const intent = inferTradingViewPineIntent('open performance profiler in tradingview and summarize the metrics', [
+    { type: 'key', key: 'ctrl+shift+p' }
+  ]);
+
+  assert(intent, 'intent should be inferred');
+  assert.strictEqual(intent.surfaceTarget, 'pine-profiler');
+  assert.strictEqual(intent.wantsEvidenceReadback, true);
+});
+
 test('pine workflow recognizes pine version history provenance requests', () => {
   const intent = inferTradingViewPineIntent('open pine version history in tradingview and read the latest visible revisions', [
     { type: 'key', key: 'alt+h' }
@@ -94,6 +114,16 @@ test('pine workflow recognizes pine version history provenance requests', () =>
   assert.strictEqual(intent.wantsEvidenceReadback, true);
 });
 
+test('pine workflow recognizes revision-history alias phrasing', () => {
+  const intent = inferTradingViewPineIntent('open revision history in tradingview and read the latest visible revisions', [
+    { type: 'key', key: 'alt+h' }
+  ]);
+
+  assert(intent, 'intent should be inferred');
+  assert.strictEqual(intent.surfaceTarget, 'pine-version-history');
+  assert.strictEqual(intent.wantsEvidenceReadback, true);
+});
+
 test('pine workflow classifies version history metadata summary requests', () => {
   const mode = inferPineVersionHistoryEvidenceMode('open pine version history in tradingview and summarize the top visible revision metadata');
 

scripts/test-tradingview-shortcut-profile.js

@@ -110,10 +110,13 @@ test('shortcut profile resolves aliases and documents official shortcut referenc
 test('shortcut profile exposes reusable phrase matching helpers for workflow inference', () => {
   const indicatorTerms = getTradingViewShortcutMatchTerms('indicator-search');
   const alertTerms = getTradingViewShortcutMatchTerms('create-alert');
+  const pineEditorTerms = getTradingViewShortcutMatchTerms('open-pine-editor');
 
   assert(indicatorTerms.includes('study search'));
   assert(indicatorTerms.includes('indicators menu'));
   assert(alertTerms.includes('new alert'));
+  assert(pineEditorTerms.includes('pine script editor'));
   assert(messageMentionsTradingViewShortcut('open the study search in tradingview', 'indicator-search'));
   assert(messageMentionsTradingViewShortcut('open a new alert in tradingview', 'create-alert'));
+  assert(messageMentionsTradingViewShortcut('open the pine script editor in tradingview', 'open-pine-editor'));
 });

scripts/test-windows-observation-flow.js

@@ -469,6 +469,18 @@ async function run() {
     assert.strictEqual(rewritten[4].pineEvidenceMode, 'compile-result');
   });
 
+  await testAsync('low-signal TradingView pine-script-editor alias request rewrites to panel verification plus get_text', async () => {
+    const rewritten = aiService.rewriteActionsForReliability([
+      { type: 'key', key: 'ctrl+e' }
+    ], {
+      userMessage: 'open pine script editor in tradingview and read the visible compiler status'
+    });
+
+    assert(Array.isArray(rewritten), 'pine editor alias rewrite should return an action array');
+    assert.strictEqual(rewritten[2].verify.target, 'pine-editor');
+    assert.strictEqual(rewritten[4].text, 'Pine Editor');
+  });
+
   await testAsync('low-signal TradingView Pine diagnostics request rewrites to panel verification plus diagnostics get_text', async () => {
     const rewritten = aiService.rewriteActionsForReliability([
       { type: 'key', key: 'ctrl+e' }
@@ -531,6 +543,18 @@ async function run() {
     assert.strictEqual(rewritten[4].text, 'Pine Profiler');
   });
 
+  await testAsync('low-signal TradingView performance-profiler alias request rewrites to panel verification plus get_text', async () => {
+    const rewritten = aiService.rewriteActionsForReliability([
+      { type: 'key', key: 'ctrl+shift+p' }
+    ], {
+      userMessage: 'open performance profiler in tradingview and summarize the visible metrics'
+    });
+
+    assert(Array.isArray(rewritten), 'pine profiler alias rewrite should return an action array');
+    assert.strictEqual(rewritten[2].verify.target, 'pine-profiler');
+    assert.strictEqual(rewritten[4].text, 'Pine Profiler');
+  });
+
   await testAsync('low-signal TradingView Pine Version History request rewrites to panel verification plus get_text', async () => {
     const rewritten = aiService.rewriteActionsForReliability([
       { type: 'key', key: 'alt+h' }
@@ -546,6 +570,18 @@ async function run() {
     assert.strictEqual(rewritten[4].text, 'Pine Version History');
   });
 
+  await testAsync('low-signal TradingView revision-history alias request rewrites to panel verification plus get_text', async () => {
+    const rewritten = aiService.rewriteActionsForReliability([
+      { type: 'key', key: 'alt+h' }
+    ], {
+      userMessage: 'open revision history in tradingview and summarize the latest visible revisions'
+    });
+
+    assert(Array.isArray(rewritten), 'revision-history alias rewrite should return an action array');
+    assert.strictEqual(rewritten[2].verify.target, 'pine-version-history');
+    assert.strictEqual(rewritten[4].text, 'Pine Version History');
+  });
+
   await testAsync('low-signal TradingView Pine Version History metadata request rewrites to provenance-summary get_text', async () => {
     const rewritten = aiService.rewriteActionsForReliability([
       { type: 'key', key: 'alt+h' }

src/main/ai-service.js

@@ -4813,13 +4813,11 @@ async function executeActions(actionData, onAction = null, onScreenshot = null,
         while (evaluation.shouldReflect && reflectionIteration < MAX_REFLECTION_ITERATIONS) {
           reflectionIteration++;
           console.log(`[AI-SERVICE] Reflection triggered (iteration ${reflectionIteration}/${MAX_REFLECTION_ITERATIONS}): ${evaluation.reason}`);
-          const reflectionPrompt = reflectionTrigger.buildReflectionPrompt(evaluation.failures);
+          const reflectionMessages = reflectionTrigger.buildReflectionMessages(evaluation.failures);
 
           try {
             const reflectionResult = await providerOrchestrator.requestWithFallback(
-              [
-                { role: 'system', content: reflectionPrompt }
-              ],
+              reflectionMessages,
               reflectionModelOverride, // N6: use reasoning model for reflection when configured
               { phase: 'reflection' }
             );

src/main/session-intent-state.js

@@ -626,7 +626,7 @@ function isBroadAdvisoryPivotInput(message) {
   if (!text) return false;
 
   const hasAdvisorySignal = /\b(what would help|what should i|how can i|confidence|invest|investing|visualizations|indicators|data|catalyst|fundamental|fundamentals|what matters|what should i watch|what should i use)\b/i.test(text);
-  const hasExplicitExecutionSignal = /\b(continue|apply|add|open|show|set|switch|change|draw|place|capture|screenshot|pine logs|pine editor|volume profile|rsi|macd|bollinger|alert|timeframe|watchlist)\b/i.test(text);
+  const hasExplicitExecutionSignal = /\b(continue|apply|add|open|show|set|switch|change|draw|place|capture|screenshot|pine logs|pine editor|pine script editor|pine profiler|performance profiler|pine version history|revision history|script history|volume profile|rsi|macd|bollinger|alert|timeframe|watchlist)\b/i.test(text);
   return hasAdvisorySignal && !hasExplicitExecutionSignal;
 }
 
@@ -710,6 +710,8 @@ function formatChatContinuityContext(state, options = {}) {
       lines.push(`- pineVisibleSignals: ${pineStructuredSummary.visibleSignals.join(' | ')}`);
     }
   }
+  if (pineStructuredSummary?.evidenceMode) lines.push(`- pineEvidenceMode: ${pineStructuredSummary.evidenceMode}`);
+  if (pineStructuredSummary?.compactSummary) lines.push(`- pineCompactSummary: ${pineStructuredSummary.compactSummary}`);
   if (pineStructuredSummary?.compileStatus) {
     lines.push(`- pineCompileStatus: ${pineStructuredSummary.compileStatus}`);
     if (pineStructuredSummary.errorCountEstimate !== null && pineStructuredSummary.errorCountEstimate !== undefined) {
@@ -726,6 +728,22 @@ function formatChatContinuityContext(state, options = {}) {
       lines.push(`- pineTopVisibleDiagnostics: ${pineStructuredSummary.topVisibleDiagnostics.join(' | ')}`);
     }
   }
+  if (pineStructuredSummary?.latestVisibleRevisionLabel) lines.push(`- pineLatestVisibleRevisionLabel: ${pineStructuredSummary.latestVisibleRevisionLabel}`);
+  if (pineStructuredSummary?.latestVisibleRevisionNumber !== null && pineStructuredSummary?.latestVisibleRevisionNumber !== undefined) {
+    lines.push(`- pineLatestVisibleRevisionNumber: ${pineStructuredSummary.latestVisibleRevisionNumber}`);
+  }
+  if (pineStructuredSummary?.latestVisibleRelativeTime) lines.push(`- pineLatestVisibleRelativeTime: ${pineStructuredSummary.latestVisibleRelativeTime}`);
+  if (pineStructuredSummary?.visibleRevisionCount !== null && pineStructuredSummary?.visibleRevisionCount !== undefined) {
+    lines.push(`- pineVisibleRevisionCount: ${pineStructuredSummary.visibleRevisionCount}`);
+  }
+  if (pineStructuredSummary?.visibleRecencySignal) lines.push(`- pineVisibleRecencySignal: ${pineStructuredSummary.visibleRecencySignal}`);
+  if (Array.isArray(pineStructuredSummary?.topVisibleRevisions) && pineStructuredSummary.topVisibleRevisions.length > 0) {
+    const revisions = pineStructuredSummary.topVisibleRevisions
+      .map((entry) => [entry.label, entry.relativeTime, entry.revisionNumber !== null && entry.revisionNumber !== undefined ? `#${entry.revisionNumber}` : null].filter(Boolean).join(' '))
+      .filter(Boolean)
+      .join(' | ');
+    if (revisions) lines.push(`- pineTopVisibleRevisions: ${revisions}`);
+  }
   if (lastTurn?.executionResult?.popupFollowUp?.attempted) {
     const popup = lastTurn.executionResult.popupFollowUp;
     lines.push(`- popupFollowUp: ${popup.recipeId || 'recipe'} attempted=${popup.attempted ? 'yes' : 'no'} completed=${popup.completed ? 'yes' : 'no'}`);

src/main/telemetry/reflection-trigger.js

@@ -96,7 +96,7 @@ function buildReflectionPrompt(failures) {
     return `Failure ${i + 1}:\n  task: ${f.task}\n  phase: ${f.phase}\n${actions}\n${verifier}${context}`;
   }).join('\n\n');
 
-  return `You are the Reflection Agent for Liku CLI. Analyze these recent failures and respond with ONLY a JSON object:
+  return `Analyze these recent failures and respond with ONLY a JSON object:
 
 ${failureSummary}
 
@@ -117,6 +117,19 @@ Respond with exactly this JSON structure:
 }`;
 }
 
+function buildReflectionMessages(failures) {
+  return [
+    {
+      role: 'system',
+      content: 'You are the Reflection Agent for Liku CLI. Analyze recent failures and respond with ONLY a JSON object.'
+    },
+    {
+      role: 'user',
+      content: buildReflectionPrompt(failures)
+    }
+  ];
+}
+
 /**
  * Parse the reflection response and apply the recommended action.
  *
@@ -222,6 +235,7 @@ function resetSession() {
 
 module.exports = {
   evaluateOutcome,
+  buildReflectionMessages,
   buildReflectionPrompt,
   applyReflectionResult,
   resetSession,