Skip to content

Commit 27c576e

Browse files
committed
Change the close button in compact suggestion panel to dismiss instead of reject
1 parent 7eebdb8 commit 27c576e

File tree

3 files changed

+13
-2
lines changed

3 files changed

+13
-2
lines changed

Core/Sources/Service/GUI/WidgetDataSource.swift

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,13 @@ extension WidgetDataSource: SuggestionWidgetDataSource {
5050
await handler.acceptSuggestion()
5151
NSWorkspace.activatePreviousActiveXcode()
5252
}
53+
},
54+
onDismissSuggestionTapped: {
55+
Task {
56+
let handler = PseudoCommandHandler()
57+
await handler.dismissSuggestion()
58+
NSWorkspace.activatePreviousActiveXcode()
59+
}
5360
}
5461
)
5562
}

Core/Sources/SuggestionWidget/Providers/CodeSuggestionProvider.swift

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ public final class CodeSuggestionProvider: ObservableObject, Equatable {
1818
public var onSelectNextSuggestionTapped: () -> Void
1919
public var onRejectSuggestionTapped: () -> Void
2020
public var onAcceptSuggestionTapped: () -> Void
21+
public var onDismissSuggestionTapped: () -> Void
2122

2223
public init(
2324
code: String = "",
@@ -28,7 +29,8 @@ public final class CodeSuggestionProvider: ObservableObject, Equatable {
2829
onSelectPreviousSuggestionTapped: @escaping () -> Void = {},
2930
onSelectNextSuggestionTapped: @escaping () -> Void = {},
3031
onRejectSuggestionTapped: @escaping () -> Void = {},
31-
onAcceptSuggestionTapped: @escaping () -> Void = {}
32+
onAcceptSuggestionTapped: @escaping () -> Void = {},
33+
onDismissSuggestionTapped: @escaping () -> Void = {}
3234
) {
3335
self.code = code
3436
self.language = language
@@ -39,11 +41,13 @@ public final class CodeSuggestionProvider: ObservableObject, Equatable {
3941
self.onSelectNextSuggestionTapped = onSelectNextSuggestionTapped
4042
self.onRejectSuggestionTapped = onRejectSuggestionTapped
4143
self.onAcceptSuggestionTapped = onAcceptSuggestionTapped
44+
self.onDismissSuggestionTapped = onDismissSuggestionTapped
4245
}
4346

4447
func selectPreviousSuggestion() { onSelectPreviousSuggestionTapped() }
4548
func selectNextSuggestion() { onSelectNextSuggestionTapped() }
4649
func rejectSuggestion() { onRejectSuggestionTapped() }
4750
func acceptSuggestion() { onAcceptSuggestionTapped() }
51+
func dismissSuggestion() { onDismissSuggestionTapped() }
4852
}
4953

Core/Sources/SuggestionWidget/SuggestionPanelContent/CodeBlockSuggestionPanel.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ struct CodeBlockSuggestionPanel: View {
7474
Spacer()
7575

7676
Button(action: {
77-
suggestion.rejectSuggestion()
77+
suggestion.dismissSuggestion()
7878
}) {
7979
Image(systemName: "xmark")
8080
}.buttonStyle(.plain)

0 commit comments

Comments
 (0)