Prevent sending discard suggestion action when there is no suggestion displayed

intitni · intitni · commit e27b1ab58823 · 2024-03-14T01:51:40.000+08:00
diff --git a/Core/Sources/SuggestionWidget/SuggestionWidgetController.swift b/Core/Sources/SuggestionWidget/SuggestionWidgetController.swift
@@ -51,7 +51,11 @@ public extension SuggestionWidgetController {
     }
 
     func discardSuggestion() {
-        store.send(.panel(.discardSuggestion))
+        store.withState { state in
+            if state.panelState.content.suggestion != nil {
+                store.send(.panel(.discardSuggestion))
+            }
+        }
     }
 
     #warning("TODO: Make a progress controller that doesn't use TCA.")

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,11 @@ public extension SuggestionWidgetController {`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`func discardSuggestion() {`
`54`		`- store.send(.panel(.discardSuggestion))`
	`54`	`+ store.withState { state in`
	`55`	`+ if state.panelState.content.suggestion != nil {`
	`56`	`+ store.send(.panel(.discardSuggestion))`
	`57`	`+ }`
	`58`	`+ }`
`55`	`59`	`}`
`56`	`60`
`57`	`61`	`#warning("TODO: Make a progress controller that doesn't use TCA.")`