Fix that the other chat tab can't scroll up

Author: intitni

Core/Sources/ChatGPTChatTab/Chat.swift

@@ -66,6 +66,8 @@ struct Chat {
         var isReceivingMessage = false
         var chatMenu = ChatMenu.State()
         var focusedField: Field?
+        var isEnabled = true
+        var isPinnedToBottom = true
 
         enum Field: String, Hashable {
             case textField
@@ -77,13 +79,16 @@ struct Chat {
 
         case appear
         case refresh
+        case setIsEnabled(Bool)
         case sendButtonTapped
         case returnButtonTapped
         case stopRespondingButtonTapped
         case clearButtonTap
         case deleteMessageButtonTapped(MessageID)
         case resendMessageButtonTapped(MessageID)
         case setAsExtraPromptButtonTapped(MessageID)
+        case manuallyScrolledUp
+        case scrollToBottomButtonTapped
         case focusOnTextField
         case referenceClicked(DisplayedChatMessage.Reference)
 
@@ -143,6 +148,10 @@ struct Chat {
                     await send(.chatMenu(.refresh))
                 }
 
+            case let .setIsEnabled(isEnabled):
+                state.isEnabled = isEnabled
+                return .none
+            
             case .sendButtonTapped:
                 guard !state.typedMessage.isEmpty else { return .none }
                 let message = state.typedMessage
@@ -204,6 +213,14 @@ struct Chat {
                         await openURL(url)
                     }
                 }
+                
+            case .manuallyScrolledUp:
+                state.isPinnedToBottom = false
+                return .none
+                
+            case .scrollToBottomButtonTapped:
+                state.isPinnedToBottom = true
+                return .none
 
             case .focusOnTextField:
                 state.focusedField = .textField
@@ -365,6 +382,9 @@ struct Chat {
 
             case .isReceivingMessageChanged:
                 state.isReceivingMessage = service.isReceivingMessage
+                if service.isReceivingMessage {
+                    state.isPinnedToBottom = true
+                }
                 return .none
 
             case .systemPromptChanged:

Core/Sources/ChatGPTChatTab/ChatPanel.swift

@@ -43,7 +43,6 @@ struct ChatPanelMessages: View {
     let chat: StoreOf<Chat>
     @State var cancellable = Set<AnyCancellable>()
     @State var isScrollToBottomButtonDisplayed = true
-    @State var isPinnedToBottom = true
     @Namespace var bottomID
     @Namespace var topID
     @Namespace var scrollSpace
@@ -128,11 +127,7 @@ struct ChatPanelMessages: View {
                         scrollToBottomButton(proxy: proxy)
                     }
                     .background {
-                        PinToBottomHandler(
-                            chat: chat,
-                            isBottomHidden: isBottomHidden,
-                            pinnedToBottom: $isPinnedToBottom
-                        ) {
+                        PinToBottomHandler(chat: chat, isBottomHidden: isBottomHidden) {
                             proxy.scrollTo(bottomID, anchor: .bottom)
                         }
                     }
@@ -151,22 +146,26 @@ struct ChatPanelMessages: View {
                 cancellable.forEach { $0.cancel() }
                 cancellable = []
             }
+            .onChange(of: isEnabled) { isEnabled in
+                chat.send(.setIsEnabled(isEnabled))
+            }
         }
     }
 
     func trackScrollWheel() {
         NSApplication.shared.publisher(for: \.currentEvent)
-            .filter {
-                if !isEnabled { return false }
+            .receive(on: DispatchQueue.main)
+            .filter { [chat] in
+                guard chat.withState(\.isEnabled) else { return false }
                 return $0?.type == .scrollWheel
             }
             .compactMap { $0 }
             .sink { event in
-                guard isPinnedToBottom else { return }
+                guard chat.withState(\.isPinnedToBottom) else { return }
                 let delta = event.deltaY
                 let scrollUp = delta > 0
                 if scrollUp {
-                    isPinnedToBottom = false
+                    chat.send(.manuallyScrolledUp)
                 }
             }
             .store(in: &cancellable)
@@ -184,7 +183,7 @@ struct ChatPanelMessages: View {
     @ViewBuilder
     func scrollToBottomButton(proxy: ScrollViewProxy) -> some View {
         Button(action: {
-            isPinnedToBottom = true
+            chat.send(.scrollToBottomButtonTapped)
             withAnimation(.easeInOut(duration: 0.1)) {
                 proxy.scrollTo(bottomID, anchor: .bottom)
             }
@@ -222,18 +221,16 @@ struct ChatPanelMessages: View {
     struct PinToBottomHandler: View {
         let chat: StoreOf<Chat>
         let isBottomHidden: Bool
-        @Binding var pinnedToBottom: Bool
         let scrollToBottom: () -> Void
 
         @State var isInitialLoad = true
-        
+
         var body: some View {
             WithPerceptionTracking {
                 EmptyView()
                     .onChange(of: chat.isReceivingMessage) { isReceiving in
                         if isReceiving {
                             Task {
-                                pinnedToBottom = true
                                 await Task.yield()
                                 withAnimation(.easeInOut(duration: 0.1)) {
                                     scrollToBottom()
@@ -242,7 +239,7 @@ struct ChatPanelMessages: View {
                         }
                     }
                     .onChange(of: chat.history.last) { _ in
-                        if pinnedToBottom || isInitialLoad {
+                        if chat.withState(\.isPinnedToBottom) || isInitialLoad {
                             if isInitialLoad {
                                 isInitialLoad = false
                             }
@@ -256,7 +253,7 @@ struct ChatPanelMessages: View {
                     }
                     .onChange(of: isBottomHidden) { value in
                         // This is important to prevent it from jumping to the top!
-                        if value, pinnedToBottom {
+                        if value, chat.withState(\.isPinnedToBottom) {
                             scrollToBottom()
                         }
                     }