Workaround cooperative app activation

Author: intitni

Core/Sources/Service/GUI/GraphicalUserInterfaceController.swift

@@ -141,9 +141,7 @@ struct GUI: ReducerProtocol {
                         )
                         await send(.suggestionWidget(.updateKeyWindow(.chatPanel)))
 
-                        if await !NSApplication.shared.isActive {
-                            activateThisApp()
-                        }
+                        activateThisApp()
                     }
 
                 case .createChatGPTChatTabIfNeeded:

Core/Sources/SuggestionWidget/FeatureReducers/WidgetFeature.swift

@@ -197,17 +197,6 @@ public struct WidgetFeature: ReducerProtocol {
             PanelFeature()
         }
 
-        Reduce { _, action in
-            switch action {
-            case .panel(.sharedPanel(.promptToCodeGroup(.activateOrCreatePromptToCode))):
-                return .run { send in
-                    await send(.updateKeyWindow(.sharedPanel))
-                    activateThisApp()
-                }
-            default: return .none
-            }
-        }
-
         Scope(state: \.chatPanelState, action: /Action.chatPanel) {
             ChatPanelFeature()
         }

Tool/Sources/AppActivator/AppActivator.swift

@@ -3,13 +3,27 @@ import Dependencies
 import XcodeInspector
 
 public extension NSWorkspace {
-    static func activateThisApp(delay: TimeInterval = 0.5) {
+    static func activateThisApp(delay: TimeInterval = 0.3) {
         Task { @MainActor in
             try await Task.sleep(nanoseconds: UInt64(delay * 1_000_000_000))
-            // NSApp.activate may fail.
-            NSRunningApplication(
-                processIdentifier: ProcessInfo.processInfo.processIdentifier
-            )?.activate()
+
+            // NSApp.activate may fail. And since macOS 14, it looks like the app needs other
+            // apps to call `yieldActivationToApplication` to activate itself?
+
+            let activated = NSRunningApplication.current
+                .activate(options: [.activateIgnoringOtherApps])
+
+            if activated { return }
+
+            // Fallback solution
+
+            let appleScript = """
+            tell application "System Events"
+                set frontmost of the first process whose unix id is \
+            \(ProcessInfo.processInfo.processIdentifier) to true
+            end tell
+            """
+            try await runAppleScript(appleScript)
         }
     }
 
@@ -20,7 +34,7 @@ public extension NSWorkspace {
             app.runningApplication.activate()
         }
     }
-    
+
     static func activatePreviousActiveXcode(delay: TimeInterval = 0.2) {
         Task { @MainActor in
             guard let app = XcodeInspector.shared.latestActiveXcode else { return }
@@ -52,10 +66,41 @@ public extension DependencyValues {
         get { self[ActivatePreviousActiveAppDependencyKey.self] }
         set { self[ActivatePreviousActiveAppDependencyKey.self] = newValue }
     }
-    
+
     var activatePreviousActiveXcode: () -> Void {
         get { self[ActivatePreviousActiveXcodeDependencyKey.self] }
         set { self[ActivatePreviousActiveXcodeDependencyKey.self] = newValue }
     }
 }
 
+@discardableResult
+func runAppleScript(_ appleScript: String) async throws -> String {
+    let task = Process()
+    task.launchPath = "/usr/bin/osascript"
+    task.arguments = ["-e", appleScript]
+    let outpipe = Pipe()
+    task.standardOutput = outpipe
+    task.standardError = Pipe()
+
+    return try await withUnsafeThrowingContinuation { continuation in
+        do {
+            task.terminationHandler = { _ in
+                do {
+                    if let data = try outpipe.fileHandleForReading.readToEnd(),
+                       let content = String(data: data, encoding: .utf8)
+                    {
+                        continuation.resume(returning: content)
+                        return
+                    }
+                    continuation.resume(returning: "")
+                } catch {
+                    continuation.resume(throwing: error)
+                }
+            }
+            try task.run()
+        } catch {
+            continuation.resume(throwing: error)
+        }
+    }
+}
+