Fix tests

Author: intitni

Tool/Sources/WorkspaceSuggestionService/Filespace+SuggestionService.swift

@@ -104,7 +104,7 @@ extension Filespace {
     ) -> Bool {
         // cursor is not even moved during the generation.
         if alwaysTrueIfCursorNotMoved, cursorPosition == suggestion.position { return true }
-        
+
         // cursor has moved to another line
         if cursorPosition.line != suggestion.position.line { return false }
 
@@ -219,6 +219,23 @@ extension Filespace {
             completion: pseudoSuggestion,
             extraInfo: &extraInfo
         )
+
+        // We want that finish typing a partial suggestion should also make no difference.
+        if let lastOriginalLine = originalEditingLines.last,
+           cursorPosition.character < lastOriginalLine.utf16.count,
+           // But we also want to separate this case from the case that the suggestion is
+           // shortening the last line. Which does make a difference.
+           suggestion.range.end.character < lastOriginalLine.utf16.count - 1 // for line ending
+        {
+            let editingLinesPrefix = editingLines.dropLast()
+            let originalEditingLinesPrefix = originalEditingLines.dropLast()
+            if editingLinesPrefix != originalEditingLinesPrefix {
+                return false
+            }
+            let lastEditingLine = editingLines.last ?? "\n"
+            return lastOriginalLine.hasPrefix(lastEditingLine.dropLast(1)) // for line ending
+        }
+
         return editingLines == originalEditingLines
     }
 }

Tool/Tests/SuggestionProviderTests/PostProcessingSuggestionServiceMiddlewareTests.swift

@@ -241,7 +241,8 @@ class PostProcessingSuggestionServiceMiddlewareTests: XCTestCase {
                 id: "1",
                 text: "hello world",
                 position: .init(line: 0, character: 1),
-                range: .init(startPair: (0, 0), endPair: (0, 1))
+                range: .init(startPair: (0, 0), endPair: (0, 1)),
+                middlewareComments: ["Removed redundant closing parenthesis."]
             ),
         ])
     }
@@ -275,7 +276,8 @@ class PostProcessingSuggestionServiceMiddlewareTests: XCTestCase {
                 id: "1",
                 text: "",
                 position: .init(line: 0, character: 0),
-                range: .init(startPair: (0, 0), endPair: (0, 0))
+                range: .init(startPair: (0, 0), endPair: (0, 0)),
+                middlewareComments: ["Removed redundant closing parenthesis."]
             ),
         ])
     }
@@ -309,7 +311,8 @@ class PostProcessingSuggestionServiceMiddlewareTests: XCTestCase {
                 id: "1",
                 text: "hello world",
                 position: .init(line: 0, character: 1),
-                range: .init(startPair: (0, 0), endPair: (0, 1))
+                range: .init(startPair: (0, 0), endPair: (0, 1)),
+                middlewareComments: ["Removed redundant closing parenthesis."]
             ),
         ])
     }
@@ -343,7 +346,8 @@ class PostProcessingSuggestionServiceMiddlewareTests: XCTestCase {
                 id: "1",
                 text: "hello world",
                 position: .init(line: 0, character: 1),
-                range: .init(startPair: (0, 0), endPair: (0, 1))
+                range: .init(startPair: (0, 0), endPair: (0, 1)),
+                middlewareComments: ["Removed redundant closing parenthesis."]
             ),
         ])
     }
@@ -377,7 +381,8 @@ class PostProcessingSuggestionServiceMiddlewareTests: XCTestCase {
                 id: "1",
                 text: "hello world",
                 position: .init(line: 0, character: 1),
-                range: .init(startPair: (0, 0), endPair: (0, 1))
+                range: .init(startPair: (0, 0), endPair: (0, 1)),
+                middlewareComments: ["Removed redundant closing parenthesis."]
             ),
         ])
     }