Support presenting suggestion error when needed

Author: intitni

Core/Sources/Service/SuggestionCommandHandler/PseudoCommandHandler.swift

@@ -1,7 +1,9 @@
 import ActiveApplicationMonitor
 import AppKit
 import CodeiumService
+import enum CopilotForXcodeKit.SuggestionServiceError
 import Dependencies
+import Logger
 import PlusFeatureFlag
 import Preferences
 import SuggestionInjector
@@ -107,7 +109,16 @@ struct PseudoCommandHandler {
             } else {
                 presenter.discardSuggestion(fileURL: fileURL)
             }
+        } catch let error as SuggestionServiceError {
+            switch error {
+            case let .notice(error):
+                presenter.presentErrorMessage(error.localizedDescription)
+            case .silent:
+                Logger.service.error(error.localizedDescription)
+                return
+            }
         } catch {
+            Logger.service.error(error.localizedDescription)
             return
         }
     }

Core/Sources/SuggestionService/SuggestionService.swift

@@ -1,6 +1,7 @@
 import BuiltinExtension
 import CodeiumService
 import struct CopilotForXcodeKit.WorkspaceInfo
+import enum CopilotForXcodeKit.SuggestionServiceError
 import Foundation
 import GitHubCopilotService
 import Preferences
@@ -63,22 +64,28 @@ public extension SuggestionService {
         _ request: SuggestionRequest,
         workspaceInfo: CopilotForXcodeKit.WorkspaceInfo
     ) async throws -> [SuggestionModel.CodeSuggestion] {
-        var getSuggestion = suggestionProvider.getSuggestions(_:workspaceInfo:)
-        let configuration = await configuration
-
-        for middleware in middlewares.reversed() {
-            getSuggestion = { [getSuggestion] request, workspaceInfo in
-                try await middleware.getSuggestion(
-                    request,
-                    configuration: configuration,
-                    next: { [getSuggestion] request in
-                        try await getSuggestion(request, workspaceInfo)
-                    }
-                )
+        do {
+            var getSuggestion = suggestionProvider.getSuggestions(_:workspaceInfo:)
+            let configuration = await configuration
+            
+            for middleware in middlewares.reversed() {
+                getSuggestion = { [getSuggestion] request, workspaceInfo in
+                    try await middleware.getSuggestion(
+                        request,
+                        configuration: configuration,
+                        next: { [getSuggestion] request in
+                            try await getSuggestion(request, workspaceInfo)
+                        }
+                    )
+                }
             }
+            
+            return try await getSuggestion(request, workspaceInfo)
+        } catch let error as SuggestionServiceError {
+            throw error
+        } catch {
+            throw SuggestionServiceError.silent(error)
         }
-
-        return try await getSuggestion(request, workspaceInfo)
     }
 
     func notifyAccepted(

Tool/Sources/GitHubCopilotService/LanguageServer/GitHubCopilotService.swift

@@ -1,4 +1,5 @@
 import AppKit
+import enum CopilotForXcodeKit.SuggestionServiceError
 import Foundation
 import LanguageClient
 import LanguageServerProtocol
@@ -95,7 +96,7 @@ public class GitHubCopilotBaseService {
     let projectRootURL: URL
     var server: GitHubCopilotLSP
     var localProcessServer: CopilotLocalProcessServer?
-    
+
     deinit {
         localProcessServer?.terminate()
     }
@@ -111,7 +112,7 @@ public class GitHubCopilotBaseService {
             let urls = try GitHubCopilotBaseService.createFoldersIfNeeded()
             let executionParams: Process.ExecutionParameters
             let runner = UserDefaults.shared.value(for: \.runNodeWith)
-            
+
             guard let agentJSURL = {
                 let languageServerDotJS = urls.executableURL
                     .appendingPathComponent("copilot/dist/language-server.js")
@@ -129,7 +130,8 @@ public class GitHubCopilotBaseService {
 
             let indexJSURL: URL = try {
                 if UserDefaults.shared.value(for: \.gitHubCopilotLoadKeyChainCertificates) {
-                    let url = urls.executableURL.appendingPathComponent("load-self-signed-cert-1.34.0.js")
+                    let url = urls.executableURL
+                        .appendingPathComponent("load-self-signed-cert-1.34.0.js")
                     if !FileManager.default.fileExists(atPath: url.path) {
                         let file = Bundle.module.url(
                             forResource: "load-self-signed-cert-1.34.0",
@@ -409,8 +411,9 @@ public final class GitHubCopilotService: GitHubCopilotBaseService,
                 return completions
             } catch let error as ServerError {
                 switch error {
-                case .serverError(1000, _, _):
-                    throw GitHubCopilotError.languageServerError(error)
+                case .serverError(1000, _, _): // not logged-in error
+                    throw SuggestionServiceError
+                        .notice(GitHubCopilotError.languageServerError(error))
                 case .serverError:
                     // sometimes the content inside language server is not new enough, which can
                     // lead to an version mismatch error. We can try a few times until the content
@@ -429,7 +432,7 @@ public final class GitHubCopilotService: GitHubCopilotBaseService,
                 throw error
             }
         }
-        
+
         func recoverContent() async {
             try? await notifyChangeTextDocument(
                 fileURL: fileURL,