Skip to content

Commit 3a34444

Browse files
committed
Make OverrideChatGPTConfiguration non-generic
1 parent bbf5dc0 commit 3a34444

3 files changed

Lines changed: 14 additions & 13 deletions

File tree

Core/Sources/ChatService/ChatService.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import Preferences
77

88
public final class ChatService: ObservableObject {
99
public let memory: ContextAwareAutoManagedChatGPTMemory
10-
public let configuration: OverridingChatGPTConfiguration<UserPreferenceChatGPTConfiguration>
10+
public let configuration: ChatGPTConfiguration
1111
public let chatGPTService: any ChatGPTServiceType
1212
public var allPluginCommands: [String] { allPlugins.map { $0.command } }
1313
@Published public internal(set) var isReceivingMessage = false
@@ -20,7 +20,7 @@ public final class ChatService: ObservableObject {
2020

2121
init<T: ChatGPTServiceType>(
2222
memory: ContextAwareAutoManagedChatGPTMemory,
23-
configuration: OverridingChatGPTConfiguration<UserPreferenceChatGPTConfiguration>,
23+
configuration: ChatGPTConfiguration,
2424
chatGPTService: T
2525
) {
2626
self.memory = memory

Tool/Sources/OpenAIService/Configuration/ChatGPTConfiguration.swift

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,15 @@ public extension ChatGPTConfiguration {
3939
}
4040

4141
func overriding(
42-
_ overrides: OverridingChatGPTConfiguration<Self>.Overriding
43-
) -> OverridingChatGPTConfiguration<Self> {
42+
_ overrides: OverridingChatGPTConfiguration.Overriding
43+
) -> OverridingChatGPTConfiguration {
4444
.init(overriding: self, with: overrides)
4545
}
4646

4747
func overriding(
48-
_ update: (inout OverridingChatGPTConfiguration<Self>.Overriding) -> Void = { _ in }
49-
) -> OverridingChatGPTConfiguration<Self> {
50-
var overrides = OverridingChatGPTConfiguration<Self>.Overriding()
48+
_ update: (inout OverridingChatGPTConfiguration.Overriding) -> Void = { _ in }
49+
) -> OverridingChatGPTConfiguration {
50+
var overrides = OverridingChatGPTConfiguration.Overriding()
5151
update(&overrides)
5252
return .init(overriding: self, with: overrides)
5353
}

Tool/Sources/OpenAIService/Configuration/UserPreferenceChatGPTConfiguration.swift

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,7 @@ public struct UserPreferenceChatGPTConfiguration: ChatGPTConfiguration {
4343
public init() {}
4444
}
4545

46-
public class OverridingChatGPTConfiguration<
47-
Configuration: ChatGPTConfiguration
48-
>: ChatGPTConfiguration {
46+
public class OverridingChatGPTConfiguration: ChatGPTConfiguration {
4947
public struct Overriding {
5048
public var featureProvider: ChatFeatureProvider?
5149
public var temperature: Double?
@@ -80,10 +78,13 @@ public class OverridingChatGPTConfiguration<
8078
}
8179
}
8280

83-
private let configuration: Configuration
81+
private let configuration: ChatGPTConfiguration
8482
public var overriding = Overriding()
8583

86-
public init(overriding configuration: Configuration, with overrides: Overriding = .init()) {
84+
public init(
85+
overriding configuration: any ChatGPTConfiguration,
86+
with overrides: Overriding = .init()
87+
) {
8788
overriding = overrides
8889
self.configuration = configuration
8990
}
@@ -123,7 +124,7 @@ public class OverridingChatGPTConfiguration<
123124
public var minimumReplyTokens: Int {
124125
overriding.minimumReplyTokens ?? configuration.minimumReplyTokens
125126
}
126-
127+
127128
public var runFunctionsAutomatically: Bool {
128129
overriding.runFunctionsAutomatically ?? configuration.runFunctionsAutomatically
129130
}

0 commit comments

Comments
 (0)