Skip to content

Commit 8ed0c8d

Browse files
committed
fix(showcase/dashboard): pass maxDepth to DepthChip so D5 cells aren't all red
The matrix chips were hard-coded red at D5 because parity-matrix and cell-matrix passed `regression={depth.isRegression}` to DepthChip but never `maxDepth`. DepthChip short-circuits to red when `regression` is true, regardless of depth. Since `isRegression` was redefined as `achieved < maxPossible` and `computeMaxPossible` returns 6 whenever a D5 mapping exists, every D5 cell without a green D6 probe (the common case — D6 probes are rare) ended up red. Pass `maxDepth={depth.maxPossible}` and drop the `regression` prop. This re-engages the chip's intended graduated coloring: green at ceiling, amber 1-2 below, red 3+ below. The `isRegression` field is still used by the cell-matrix `filter="regressions"` row filter — that's unchanged.
1 parent 0761801 commit 8ed0c8d

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

showcase/shell-dashboard/src/components/cell-matrix.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ function CategorySection({
182182
<DepthChip
183183
depth={depth.achieved}
184184
status={cellStatus}
185-
regression={depth.isRegression}
185+
maxDepth={depth.maxPossible}
186186
/>
187187
</button>
188188
{isSelected && (

showcase/shell-dashboard/src/components/parity-matrix.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ function ParityCategorySection({
139139
<DepthChip
140140
depth={refDepth.achieved}
141141
status={refStatus}
142-
regression={refDepth.isRegression}
142+
maxDepth={refDepth.maxPossible}
143143
/>
144144
</td>
145145
{nonRefIntegrations.map((int) => {
@@ -164,7 +164,7 @@ function ParityCategorySection({
164164
<DepthChip
165165
depth={depth.achieved}
166166
status={cellStatus}
167-
regression={depth.isRegression}
167+
maxDepth={depth.maxPossible}
168168
/>
169169
</td>
170170
);

0 commit comments

Comments
 (0)