Skip to content

Commit c7aa4bf

Browse files
krukowCopilot
andcommitted
Fix remaining gpt-5.2 references in source docstrings, tests, and mock server
Complete the gpt-5.2 → gpt-5.4 sweep across src/ docstrings (copilot_sdk.clj, client.clj, helpers.clj), integration tests, mock server, and API.md list-models example name field. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent eac98ac commit c7aa4bf

File tree

8 files changed

+32
-32
lines changed

8 files changed

+32
-32
lines changed

doc/api/API.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ <h4><a href="#list-models" id="list-models"></a><code>list-models</code></h4>
211211
</code></pre>
212212
<p>List available models with their metadata. Results are cached per client connection. Requires authentication. Returns a vector of model info maps:</p>
213213
<pre><code class="language-clojure">[{:id "gpt-5.4"
214-
:name "GPT-5.2"
214+
:name "GPT-5.4"
215215
:vendor "openai"
216216
:family "gpt-5.4"
217217
:version "gpt-5.4"

doc/reference/API.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,7 @@ instead of the RPC method (no connection required).
378378
Requires authentication (unless `:on-list-models` is provided). Returns a vector of model info maps:
379379
```clojure
380380
[{:id "gpt-5.4"
381-
:name "GPT-5.2"
381+
:name "GPT-5.4"
382382
:vendor "openai"
383383
:family "gpt-5.4"
384384
:version "gpt-5.4"

src/github/copilot_sdk.clj

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
1212
;; Create a session
1313
(def session (copilot/create-session client {:on-permission-request copilot/approve-all
14-
:model \"gpt-5.2\"}))
14+
:model \"gpt-5.4\"}))
1515
1616
;; Send a message and wait for response
1717
(def response (copilot/send-and-wait! session {:prompt \"What is 2+2?\"}))
@@ -382,7 +382,7 @@
382382
Config options (`:on-permission-request` is **required**):
383383
- :on-permission-request - Permission handler function (**required**, e.g. `approve-all`)
384384
- :session-id - Custom session ID
385-
- :model - Model to use (e.g., \"gpt-5.2\", \"claude-sonnet-4.5\")
385+
- :model - Model to use (e.g., \"gpt-5.4\", \"claude-sonnet-4.5\")
386386
- :tools - Vector of tool definitions (use define-tool)
387387
- :system-message - {:mode :append/:replace :content \"...\"}
388388
- :available-tools - List of allowed tool names
@@ -401,7 +401,7 @@
401401
Example:
402402
```clojure
403403
(def session (copilot/create-session client {:on-permission-request copilot/approve-all
404-
:model \"gpt-5.2\"}))
404+
:model \"gpt-5.4\"}))
405405
```"
406406
[client config]
407407
(client/create-session client config))
@@ -417,7 +417,7 @@
417417
```clojure
418418
(go
419419
(let [result (<! (copilot/<create-session client {:on-permission-request copilot/approve-all
420-
:model \"gpt-5.2\"}))]
420+
:model \"gpt-5.4\"}))]
421421
(when-not (instance? Throwable result)
422422
(let [answer (<! (copilot/<send! result {:prompt \"Hello\"}))]
423423
(println answer)))))
@@ -430,7 +430,7 @@
430430
431431
Usage:
432432
(with-session [s client {:on-permission-request copilot/approve-all
433-
:model \"gpt-5.2\"}]
433+
:model \"gpt-5.4\"}]
434434
...)"
435435
[[session-sym client config] & body]
436436
`(let [~session-sym (create-session ~client ~config)]
@@ -448,29 +448,29 @@
448448
1. [session session-opts] - anonymous client with default options
449449
```clojure
450450
(with-client-session [session {:on-permission-request copilot/approve-all
451-
:model \"gpt-5.2\"}]
451+
:model \"gpt-5.4\"}]
452452
(copilot/send! session {:prompt \"Hi\"}))
453453
```
454454
455455
2. [client-opts session session-opts] - anonymous client with custom options
456456
```clojure
457457
(with-client-session [{:log-level :debug} session {:on-permission-request copilot/approve-all
458-
:model \"gpt-5.2\"}]
458+
:model \"gpt-5.4\"}]
459459
(copilot/send! session {:prompt \"Hi\"}))
460460
```
461461
462462
3. [client session session-opts] - named client with default options
463463
```clojure
464464
(with-client-session [client session {:on-permission-request copilot/approve-all
465-
:model \"gpt-5.2\"}]
465+
:model \"gpt-5.4\"}]
466466
(println (copilot/client-options client))
467467
(copilot/send! session {:prompt \"Hi\"}))
468468
```
469469
470470
4. [client client-opts session session-opts] - named client with custom options
471471
```clojure
472472
(with-client-session [client {:log-level :debug} session {:on-permission-request copilot/approve-all
473-
:model \"gpt-5.2\"}]
473+
:model \"gpt-5.4\"}]
474474
(println (copilot/client-options client))
475475
(copilot/send! session {:prompt \"Hi\"}))
476476
```"
@@ -868,7 +868,7 @@
868868
Example:
869869
```clojure
870870
(copilot/session-config session)
871-
;=> {:model \"gpt-5.2\", :streaming? true, ...}
871+
;=> {:model \"gpt-5.4\", :streaming? true, ...}
872872
```"
873873
[session]
874874
(session/config session))

src/github/copilot_sdk/client.clj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1223,7 +1223,7 @@
12231223
- :on-permission-request - Permission handler function (**required**, e.g. `approve-all`)
12241224
- :session-id - Custom session ID
12251225
- :client-name - Client name to identify the application (included in User-Agent header)
1226-
- :model - Model to use (e.g., \"gpt-5.2\")
1226+
- :model - Model to use (e.g., \"gpt-5.4\")
12271227
- :tools - Vector of tool definitions
12281228
- :system-message - System message config
12291229
- :available-tools - List of allowed tool names
@@ -1336,7 +1336,7 @@
13361336
Usage:
13371337
(go
13381338
(let [result (<! (<create-session client {:on-permission-request copilot/approve-all
1339-
:model \"gpt-5.2\"}))]
1339+
:model \"gpt-5.4\"}))]
13401340
(if (instance? Throwable result)
13411341
(println \"Error:\" (ex-message result))
13421342
;; use result as session
@@ -1381,7 +1381,7 @@
13811381
(go
13821382
(let [result (<! (<resume-session client session-id
13831383
{:on-permission-request copilot/approve-all
1384-
:model \"gpt-5.2\"}))]
1384+
:model \"gpt-5.4\"}))]
13851385
(if (instance? Throwable result)
13861386
(println \"Error:\" (ex-message result))
13871387
;; use result as session

src/github/copilot_sdk/helpers.clj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@
202202
203203
;; With explicit session (multi-turn)
204204
(copilot/with-session [s client {:on-permission-request copilot/approve-all
205-
:model \"gpt-5.2\"}]
205+
:model \"gpt-5.4\"}]
206206
(query \"What is 2+2?\" :session s)
207207
(query \"And 3+3?\" :session s)) ;; context preserved
208208
"

test/github/copilot_sdk/integration_test.clj

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@
212212
(testing "Create new session"
213213
(let [session (sdk/create-session *test-client*
214214
{:on-permission-request sdk/approve-all
215-
:model "gpt-5.2"})]
215+
:model "gpt-5.4"})]
216216
(is (some? session))
217217
(is (string? (sdk/session-id session)))
218218
;; Session ID is now generated client-side as a UUID
@@ -293,12 +293,12 @@
293293

294294
(deftest test-get-current-model
295295
(testing "Get current model for session"
296-
(let [session (sdk/create-session *test-client* {:on-permission-request sdk/approve-all :model "gpt-5.2"})]
297-
(is (= "gpt-5.2" (sdk/get-current-model session))))))
296+
(let [session (sdk/create-session *test-client* {:on-permission-request sdk/approve-all :model "gpt-5.4"})]
297+
(is (= "gpt-5.4" (sdk/get-current-model session))))))
298298

299299
(deftest test-switch-model
300300
(testing "Switch model for session"
301-
(let [session (sdk/create-session *test-client* {:on-permission-request sdk/approve-all :model "gpt-5.2"})
301+
(let [session (sdk/create-session *test-client* {:on-permission-request sdk/approve-all :model "gpt-5.4"})
302302
new-model (sdk/switch-model! session "claude-sonnet-4.5")]
303303
(is (= "claude-sonnet-4.5" new-model))
304304
(is (= "claude-sonnet-4.5" (sdk/get-current-model session))))))
@@ -657,7 +657,7 @@
657657
(swap! seen assoc method params))))
658658
_ (sdk/create-session *test-client*
659659
{:on-permission-request sdk/approve-all
660-
:model "gpt-5.2"
660+
:model "gpt-5.4"
661661
:provider {:base-url "https://example.test"
662662
:api-key "key"}
663663
:mcp-servers {"srv-1" {:mcp-server-type :http
@@ -670,7 +670,7 @@
670670
session-id (sdk/get-last-session-id *test-client*)
671671
_ (sdk/resume-session *test-client* session-id
672672
{:on-permission-request sdk/approve-all
673-
:model "gpt-5.2"
673+
:model "gpt-5.4"
674674
:provider {:base-url "https://resume.test"}
675675
:mcp-servers {"srv-2" {:mcp-server-type :sse
676676
:mcp-url "https://mcp.resume.test"
@@ -722,7 +722,7 @@
722722
_ (mock/set-request-hook! *mock-server* (fn [method params]
723723
(when (#{"session.create"} method)
724724
(swap! seen assoc method params))))
725-
_ (sdk/create-session *test-client* {:on-permission-request sdk/approve-all :model "gpt-5.2"})
725+
_ (sdk/create-session *test-client* {:on-permission-request sdk/approve-all :model "gpt-5.4"})
726726
create-params (get @seen "session.create")]
727727
(is (not (contains? create-params :clientName))))))
728728

@@ -799,7 +799,7 @@
799799
_ (mock/set-request-hook! *mock-server* (fn [method params]
800800
(when (#{"session.create" "session.resume"} method)
801801
(swap! seen assoc method params))))
802-
_ (sdk/create-session *test-client* {:on-permission-request sdk/approve-all :model "gpt-5.2"})
802+
_ (sdk/create-session *test-client* {:on-permission-request sdk/approve-all :model "gpt-5.4"})
803803
create-params (get @seen "session.create")]
804804
(is (true? (:requestPermission create-params))
805805
"requestPermission must be true when handler is configured")))
@@ -810,7 +810,7 @@
810810
(when (#{"session.create"} method)
811811
(swap! seen assoc method params))))
812812
_ (sdk/create-session *test-client*
813-
{:model "gpt-5.2"
813+
{:model "gpt-5.4"
814814
:on-permission-request sdk/approve-all})
815815
create-params (get @seen "session.create")]
816816
(is (true? (:requestPermission create-params)))))

test/github/copilot_sdk/mock_server.clj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,11 +105,11 @@
105105
:statusMessage "Authenticated as test-user"})
106106

107107
(defn- handle-models-list [server params]
108-
{:models [{:id "gpt-5.2"
109-
:name "GPT-5.2"
108+
{:models [{:id "gpt-5.4"
109+
:name "GPT-5.4"
110110
:vendor "openai"
111-
:family "gpt-5.2"
112-
:version "gpt-5.2"
111+
:family "gpt-5.4"
112+
:version "gpt-5.4"
113113
:max_input_tokens 128000
114114
:max_output_tokens 16384
115115
:preview false}

test/github/copilot_sdk_test.clj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -289,19 +289,19 @@
289289
:reasoning-efforts "high"}))))
290290

291291
(testing "typo in session config provides helpful error"
292-
(let [unknown (specs/unknown-keys {:model "gpt-5.2" :streeming? true}
292+
(let [unknown (specs/unknown-keys {:model "gpt-5.4" :streeming? true}
293293
specs/session-config-keys)]
294294
(is (contains? unknown :streeming?))))
295295

296296
(testing "valid session config keys are accepted"
297297
(is (s/valid? ::specs/session-config {:on-permission-request identity
298-
:model "gpt-5.2"
298+
:model "gpt-5.4"
299299
:streaming? true
300300
:reasoning-effort "high"})))
301301

302302
(testing "session config rejects unknown keys even with valid ones"
303303
(is (not (s/valid? ::specs/session-config {:on-permission-request identity
304-
:model "gpt-5.2"
304+
:model "gpt-5.4"
305305
:unknown-key "value"})))))
306306

307307
(deftest evt-helper-test

0 commit comments

Comments
 (0)