Skip to content

Commit efe5e20

Browse files
committed
Remove the useless await
1 parent 321236a commit efe5e20

1 file changed

Lines changed: 17 additions & 20 deletions

File tree

Core/Sources/SuggestionWidget/WidgetWindowsController.swift

Lines changed: 17 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -79,11 +79,7 @@ actor WidgetWindowsController: NSObject {
7979
await send(.updatePanelStateToMatch(location))
8080
}
8181

82-
func updateWindowOpacity(immediately: Bool) async {
83-
let state = store.withState { $0 }
84-
85-
let isChatPanelDetached = state.chatPanelState.chatPanelInASeparateWindow
86-
let hasChat = !state.chatPanelState.chatTabGroup.tabInfo.isEmpty
82+
func updateWindowOpacity(immediately: Bool) {
8783
let shouldDebounce = !immediately &&
8884
!(Date().timeIntervalSince(lastUpdateWindowOpacityTime) > 5)
8985
lastUpdateWindowOpacityTime = Date()
@@ -153,7 +149,7 @@ actor WidgetWindowsController: NSObject {
153149
immediately: Bool,
154150
function: StaticString = #function,
155151
line: UInt = #line
156-
) async {
152+
) {
157153
@Sendable @MainActor
158154
func update() async {
159155
let state = store.withState { $0 }
@@ -259,11 +255,12 @@ private extension WidgetWindowsController {
259255
func activate(_ app: AppInstanceInspector) {
260256
Task {
261257
if app.isXcode {
262-
await updateWindowLocation(animated: false, immediately: true)
263-
await updateWindowOpacity(immediately: false)
258+
updateWindowLocation(animated: false, immediately: true)
259+
updateWindowOpacity(immediately: false)
264260
} else {
265-
await updateWindowOpacity(immediately: true)
266-
await updateWindowLocation(animated: false, immediately: false)
261+
updateWindowOpacity(immediately: true)
262+
updateWindowLocation(animated: false, immediately: false)
263+
await hideSuggestionPanelWindow()
267264
}
268265
}
269266
guard currentApplicationProcessIdentifier != app.processIdentifier else { return }
@@ -295,13 +292,13 @@ private extension WidgetWindowsController {
295292

296293
func updateWidgetsAndNotifyChangeOfEditor(immediately: Bool) async {
297294
await send(.panel(.switchToAnotherEditorAndUpdateContent))
298-
await updateWindowLocation(animated: false, immediately: immediately)
299-
await updateWindowOpacity(immediately: immediately)
295+
updateWindowLocation(animated: false, immediately: immediately)
296+
updateWindowOpacity(immediately: immediately)
300297
}
301298

302299
func updateWidgets() async {
303-
await updateWindowLocation(animated: false, immediately: false)
304-
await updateWindowOpacity(immediately: false)
300+
updateWindowLocation(animated: false, immediately: false)
301+
updateWindowOpacity(immediately: false)
305302
}
306303

307304
switch notification.kind {
@@ -348,8 +345,8 @@ private extension WidgetWindowsController {
348345
await hideSuggestionPanelWindow()
349346
}
350347

351-
await updateWindowLocation(animated: false, immediately: false)
352-
await updateWindowOpacity(immediately: false)
348+
updateWindowLocation(animated: false, immediately: false)
349+
updateWindowOpacity(immediately: false)
353350
}
354351
} else {
355352
for await notification in merge(selectionRangeChange, scroll) {
@@ -361,8 +358,8 @@ private extension WidgetWindowsController {
361358
await hideSuggestionPanelWindow()
362359
}
363360

364-
await updateWindowLocation(animated: false, immediately: false)
365-
await updateWindowOpacity(immediately: false)
361+
updateWindowLocation(animated: false, immediately: false)
362+
updateWindowOpacity(immediately: false)
366363
}
367364
}
368365
}
@@ -379,8 +376,8 @@ private extension WidgetWindowsController {
379376
try await Task.sleep(nanoseconds: 400_000_000)
380377
}
381378

382-
await updateWindowLocation(animated: false, immediately: false)
383-
await updateWindowOpacity(immediately: false)
379+
updateWindowLocation(animated: false, immediately: false)
380+
updateWindowOpacity(immediately: false)
384381
}
385382
}
386383
}

0 commit comments

Comments
 (0)