Merge branch 'feature/fix-detached-window-resized-repositioned-once-displayed' into develop

intitni · intitni · commit ae6c55177568 · 2024-01-25T15:33:05.000+08:00
diff --git a/Core/Sources/SuggestionWidget/FeatureReducers/WidgetFeature.swift b/Core/Sources/SuggestionWidget/FeatureReducers/WidgetFeature.swift
@@ -208,7 +208,7 @@ public struct WidgetFeature: ReducerProtocol {
                     await send(.updateWindowOpacity(immediately: false))
                     if isDetached {
                         Task { @MainActor in
-                            windows.chatPanelWindow.alphaValue = 1
+                            windows.chatPanelWindow.isWindowHidden = false
                         }
                     }
                 }
@@ -539,13 +539,7 @@ public struct WidgetFeature: ReducerProtocol {
                         }
 
                         if isChatPanelDetached {
-                            if windows.chatPanelWindow.alphaValue == 0 {
-                                windows.chatPanelWindow.setFrame(
-                                    widgetLocation.defaultPanelLocation.frame,
-                                    display: false,
-                                    animate: animated
-                                )
-                            }
+                            // don't update it!
                         } else {
                             windows.chatPanelWindow.setFrame(
                                 widgetLocation.defaultPanelLocation.frame,

Original file line number	Diff line number	Diff line change
`@@ -208,7 +208,7 @@ public struct WidgetFeature: ReducerProtocol {`
`208`	`208`	`await send(.updateWindowOpacity(immediately: false))`
`209`	`209`	`if isDetached {`
`210`	`210`	`Task { @MainActor in`
`211`		`- windows.chatPanelWindow.alphaValue = 1`
	`211`	`+ windows.chatPanelWindow.isWindowHidden = false`
`212`	`212`	`}`
`213`	`213`	`}`
`214`	`214`	`}`
`@@ -539,13 +539,7 @@ public struct WidgetFeature: ReducerProtocol {`
`539`	`539`	`}`
`540`	`540`
`541`	`541`	`if isChatPanelDetached {`
`542`		`- if windows.chatPanelWindow.alphaValue == 0 {`
`543`		`- windows.chatPanelWindow.setFrame(`
`544`		`- widgetLocation.defaultPanelLocation.frame,`
`545`		`- display: false,`
`546`		`- animate: animated`
`547`		`- )`
`548`		`- }`
	`542`	`+ // don't update it!`
`549`	`543`	`} else {`
`550`	`544`	`windows.chatPanelWindow.setFrame(`
`551`	`545`	`widgetLocation.defaultPanelLocation.frame,`