Terminate process on cancellation

Author: intitni

Core/Package.swift

@@ -148,7 +148,7 @@ let package = Package(
             dependencies: ["OpenAIService"]
         ),
         .target(name: "Preferences"),
-        .target(name: "ChatPlugins", dependencies: ["OpenAIService", "Environment"]),
+        .target(name: "ChatPlugins", dependencies: ["OpenAIService", "Environment", "Terminal"]),
         .target(name: "Terminal"),
         .target(name: "ChatService", dependencies: ["OpenAIService", "ChatPlugins", "Environment"]),
     ]

Core/Sources/ChatPlugins/TerminalChatPlugin.swift

@@ -90,7 +90,8 @@ public actor TerminalChatPlugin: ChatPlugin {
         delegate?.pluginDidEnd(self)
     }
 
-    public func cancel() {
+    public func cancel() async {
         isCancelled = true
+        await terminal.terminate()
     }
 }

Core/Sources/Terminal/Terminal.swift

@@ -15,6 +15,8 @@ public protocol TerminalType {
         currentDirectoryPath: String,
         environment: [String: String]
     ) async throws -> String
+    
+    func terminate() async
 }
 
 public final class Terminal: TerminalType, @unchecked Sendable {
@@ -145,4 +147,9 @@ public final class Terminal: TerminalType, @unchecked Sendable {
         inputPipe?.fileHandleForWriting.write(data)
         inputPipe?.fileHandleForWriting.closeFile()
     }
+    
+    public func terminate() async {
+        process?.terminate()
+        process = nil
+    }
 }