Rename chatPanelInASeparateWindow to isDetached

Author: intitni

Core/Sources/SuggestionWidget/ChatWindowView.swift

@@ -79,7 +79,7 @@ struct ChatTitleBar: View {
 
             Spacer()
 
-            WithViewStore(store, observe: { $0.chatPanelInASeparateWindow }) { viewStore in
+            WithViewStore(store, observe: { $0.isDetached }) { viewStore in
                 TrafficLightButton(
                     isHovering: isHovering,
                     isActive: viewStore.state,

Core/Sources/SuggestionWidget/FeatureReducers/ChatPanelFeature.swift

@@ -48,7 +48,7 @@ public struct ChatPanelFeature: ReducerProtocol {
         public var chatTabGroup = ChatTabGroup()
         var colorScheme: ColorScheme = .light
         public internal(set) var isPanelDisplayed = false
-        var chatPanelInASeparateWindow = false
+        var isDetached = false
         var isFullScreen = false
     }
 
@@ -118,17 +118,17 @@ public struct ChatPanelFeature: ReducerProtocol {
                 return .none
 
             case .toggleChatPanelDetachedButtonClicked:
-                if state.isFullScreen, state.chatPanelInASeparateWindow {
+                if state.isFullScreen, state.isDetached {
                     return .run { send in
                         await send(.attachChatPanel)
                     }
                 }
 
-                state.chatPanelInASeparateWindow.toggle()
+                state.isDetached.toggle()
                 return .none
 
             case .detachChatPanel:
-                state.chatPanelInASeparateWindow = true
+                state.isDetached = true
                 return .none
 
             case .attachChatPanel:
@@ -140,7 +140,7 @@ public struct ChatPanelFeature: ReducerProtocol {
                     }
                 }
 
-                state.chatPanelInASeparateWindow = false
+                state.isDetached = false
                 return .none
 
             case .enterFullScreen:
@@ -155,7 +155,7 @@ public struct ChatPanelFeature: ReducerProtocol {
 
             case let .presentChatPanel(forceDetach):
                 if forceDetach {
-                    state.chatPanelInASeparateWindow = true
+                    state.isDetached = true
                 }
                 state.isPanelDisplayed = true
                 return .run { send in

Core/Sources/SuggestionWidget/FeatureReducers/WidgetFeature.swift

@@ -65,7 +65,7 @@ public struct WidgetFeature: ReducerProtocol {
                     }(),
                     isContentEmpty: chatPanelState.chatTabGroup.tabInfo.isEmpty
                         && panelState.sharedPanelState.isEmpty,
-                    isChatPanelDetached: chatPanelState.chatPanelInASeparateWindow,
+                    isChatPanelDetached: chatPanelState.isDetached,
                     isChatOpen: chatPanelState.isPanelDisplayed
                 )
             }
@@ -191,7 +191,7 @@ public struct WidgetFeature: ReducerProtocol {
         Reduce { state, action in
             switch action {
             case .chatPanel(.presentChatPanel):
-                let isDetached = state.chatPanelState.chatPanelInASeparateWindow
+                let isDetached = state.chatPanelState.isDetached
                 return .run { _ in
                     await windowsController?.updateWindowLocation(
                         animated: false,
@@ -206,7 +206,7 @@ public struct WidgetFeature: ReducerProtocol {
                 }
 
             case .chatPanel(.toggleChatPanelDetachedButtonClicked):
-                let isDetached = state.chatPanelState.chatPanelInASeparateWindow
+                let isDetached = state.chatPanelState.isDetached
                 return .run { _ in
                     await windowsController?.updateWindowLocation(
                         animated: !isDetached,

Core/Sources/SuggestionWidget/WidgetWindowsController.swift

@@ -96,7 +96,7 @@ actor WidgetWindowsController: NSObject {
             let previousActiveApplication = xcodeInspector.previousActiveApplication
             await MainActor.run {
                 let state = store.withState { $0 }
-                let isChatPanelDetached = state.chatPanelState.chatPanelInASeparateWindow
+                let isChatPanelDetached = state.chatPanelState.isDetached
                 let hasChat = !state.chatPanelState.chatTabGroup.tabInfo.isEmpty
 
                 if let activeApp, activeApp.isXcode {
@@ -166,7 +166,7 @@ actor WidgetWindowsController: NSObject {
         @Sendable @MainActor
         func update() async {
             let state = store.withState { $0 }
-            let isChatPanelDetached = state.chatPanelState.chatPanelInASeparateWindow
+            let isChatPanelDetached = state.chatPanelState.isDetached
             guard let widgetLocation = await generateWidgetLocation() else { return }
             await updatePanelState(widgetLocation)
 
@@ -295,14 +295,15 @@ private extension WidgetWindowsController {
                 /// so the transition looks better.
                 func hideWidgetForTransitions() async {
                     let newDocumentURL = await xcodeInspector.safe.realtimeActiveDocumentURL
-                    let documentURL = await MainActor.run { store.withState { $0.focusingDocumentURL } }
+                    let documentURL = await MainActor
+                        .run { store.withState { $0.focusingDocumentURL } }
                     if documentURL != newDocumentURL {
                         await send(.panel(.removeDisplayedContent))
                         await hidePanelWindows()
                     }
                     await send(.updateFocusingDocumentURL)
                 }
-                
+
                 func removeContent() async {
                     await send(.panel(.removeDisplayedContent))
                 }