feat - Chat History (Part3) - Added UI to persist chat history. (#1148)

Author: ethanyhou

com.microsoft.copilot.eclipse.core/META-INF/MANIFEST.MF

@@ -15,6 +15,7 @@ Export-Package: com.microsoft.copilot.eclipse.core,
  com.microsoft.copilot.eclipse.core.lsp.protocol,
  com.microsoft.copilot.eclipse.core.lsp.protocol.git,
  com.microsoft.copilot.eclipse.core.lsp.protocol.quota,
+ com.microsoft.copilot.eclipse.core.persistence;x-friends:="com.microsoft.copilot.eclipse.ui,com.microsoft.copilot.eclipse.core.test，com.microsoft.copilot.eclipse.core.utils",
  com.microsoft.copilot.eclipse.core.utils
 Bundle-Activator: com.microsoft.copilot.eclipse.core.CopilotCore
 Bundle-RequiredExecutionEnvironment: JavaSE-17

com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/events/CopilotEventConstants.java

@@ -49,14 +49,34 @@ public class CopilotEventConstants {
    * Event when MCP runtime log is received.
    */
   public static final String TOPIC_CHAT_MCP_RUNTIME_LOG = TOPIC_CHAT + "MCP_RUNTIME_LOG";
-  
+
   /**
    * Event when the chat feature flag are updated.
    */
   public static final String TOPIC_CHAT_DID_CHANGE_FEATURE_FLAGS = TOPIC_CHAT + "DID_CHANGE_FEATURE_FLAGS";
-  
+
   /**
    * Event when the chat mode is changed.
    */
   public static final String TOPIC_CHAT_MODE_CHANGED = TOPIC_CHAT + "MODE_CHANGED";
+
+  /**
+   * Event when the chat history visibility is toggled to hide chat history.
+   */
+  public static final String TOPIC_CHAT_HIDE_CHAT_HISTORY = TOPIC_CHAT + "HIDE_CHAT_HISTORY";
+
+  /**
+   * Event when the chat history visibility is toggled to show chat history.
+   */
+  public static final String TOPIC_CHAT_SHOW_CHAT_HISTORY = TOPIC_CHAT + "SHOW_CHAT_HISTORY";
+
+  /**
+   * Event when the back button is clicked in chat history view.
+   */
+  public static final String TOPIC_CHAT_HISTORY_BACK_CLICKED = TOPIC_CHAT + "BACK_TO_CHAT_CLICKED";
+
+  /**
+   * Event when a conversation is selected in chat history view.
+   */
+  public static final String TOPIC_CHAT_HISTORY_CONVERSATION_SELECTED = TOPIC_CHAT + "HISTORY_CONVERSATION_SELECTED";
 }

com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/lsp/CopilotLanguageServerConnection.java

@@ -42,6 +42,7 @@
 import com.microsoft.copilot.eclipse.core.lsp.protocol.SignInConfirmParams;
 import com.microsoft.copilot.eclipse.core.lsp.protocol.SignInInitiateResult;
 import com.microsoft.copilot.eclipse.core.lsp.protocol.TelemetryExceptionParams;
+import com.microsoft.copilot.eclipse.core.lsp.protocol.Turn;
 import com.microsoft.copilot.eclipse.core.lsp.protocol.UpdateMcpToolsStatusParams;
 import com.microsoft.copilot.eclipse.core.lsp.protocol.git.GenerateCommitMessageParams;
 import com.microsoft.copilot.eclipse.core.lsp.protocol.git.GenerateCommitMessageResult;
@@ -221,7 +222,7 @@ public CompletableFuture<Object> sendExceptionTelemetry(Throwable ex) {
    * Create a conversation with the given parameters.
    */
   public CompletableFuture<ChatCreateResult> createConversation(String workDoneToken, String message,
-      List<IResource> files, IFile currentFile, CopilotModel activeModel, String chatModeName) {
+      List<IResource> files, IFile currentFile, List<Turn> turns, CopilotModel activeModel, String chatModeName) {
     boolean supportVision = activeModel.getCapabilities().supports().vision();
     Either<String, List<ChatCompletionContentPart>> messageWithImages = ChatMessageUtils
         .createMessageWithImages(message, FileUtils.filterFilesFrom(files), supportVision);
@@ -232,6 +233,11 @@ public CompletableFuture<ChatCreateResult> createConversation(String workDoneTok
       param.setReferences(FileUtils.convertToChatReferences(files));
       param.setModel(getModelName(activeModel));
       param.setChatMode(chatModeName);
+
+      // Set historical turns if provided.
+      if (turns != null && turns.size() > 0) {
+        param.setTurns(turns);
+      }
       // TODO: remove needToolCallConfirmation when CLS fully supports it across all IDEs.
       param.setNeedToolCallConfirmation(true);
       if (currentFile != null) {

com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/lsp/protocol/ConversationCreateParams.java

@@ -15,7 +15,7 @@
  */
 public class ConversationCreateParams {
   private String workDoneToken;
-  private Turn[] turns;
+  private List<Turn> turns;
   private ConversationCapabilities capabilities;
   private boolean computeSuggestions;
   private TextDocumentIdentifier textDocument;
@@ -37,7 +37,7 @@ public class ConversationCreateParams {
    */
   public ConversationCreateParams(Either<String, List<ChatCompletionContentPart>> prompt, String workDoneToken) {
     this.workDoneToken = workDoneToken;
-    this.turns = new Turn[] { new Turn(prompt, null, null) };
+    this.turns = new ArrayList<>(List.of(new Turn(prompt, null, null)));
     this.capabilities = new ConversationCapabilities();
     this.capabilities.setSkills(List.of(ConversationCapabilities.CURRENT_EDITOR_SKILL));
     this.computeSuggestions = true;
@@ -54,11 +54,11 @@ public void setWorkDoneToken(String workDoneToken) {
     this.workDoneToken = workDoneToken;
   }
 
-  public Turn[] getTurns() {
+  public List<Turn> getTurns() {
     return turns;
   }
 
-  public void setTurns(Turn[] turns) {
+  public void setTurns(List<Turn> turns) {
     this.turns = turns;
   }
 
@@ -163,7 +163,7 @@ public int hashCode() {
     final int prime = 31;
     int result = 1;
     result = prime * result + Arrays.hashCode(ignoredSkills);
-    result = prime * result + Arrays.hashCode(turns);
+    result = prime * result + Objects.hashCode(turns);
     result = prime * result + Objects.hash(capabilities, chatMode, computeSuggestions, model, needToolCallConfirmation,
         references, source, textDocument, userLanguage, workDoneToken, workspaceFolder, workspaceFolders);
     return result;
@@ -185,7 +185,7 @@ public boolean equals(Object obj) {
         && computeSuggestions == other.computeSuggestions && Arrays.equals(ignoredSkills, other.ignoredSkills)
         && Objects.equals(model, other.model) && needToolCallConfirmation == other.needToolCallConfirmation
         && Objects.equals(references, other.references) && Objects.equals(source, other.source)
-        && Objects.equals(textDocument, other.textDocument) && Arrays.equals(turns, other.turns)
+        && Objects.equals(textDocument, other.textDocument) && Objects.equals(turns, other.turns)
         && Objects.equals(userLanguage, other.userLanguage) && Objects.equals(workDoneToken, other.workDoneToken)
         && Objects.equals(workspaceFolder, other.workspaceFolder)
         && Objects.equals(workspaceFolders, other.workspaceFolders);
@@ -195,7 +195,7 @@ public boolean equals(Object obj) {
   public String toString() {
     ToStringBuilder builder = new ToStringBuilder(this);
     builder.add("workDoneToken", workDoneToken);
-    builder.add("turns", Arrays.toString(turns));
+    builder.add("turns", turns);
     builder.add("capabilities", capabilities);
     builder.add("computeSuggestions", computeSuggestions);
     builder.add("textDocument", textDocument);

com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/persistence/ConversationDataFactory.java

@@ -201,8 +201,10 @@ public List<Turn> convertToTurns(List<AbstractTurnData> turnDataList) {
     if (turnDataList == null || turnDataList.isEmpty()) {
       return new ArrayList<>();
     }
-    List<Turn> result = new ArrayList<>(turnDataList.size());
-    for (AbstractTurnData turnData : turnDataList) {
+    // Defensive copy to avoid ConcurrentModificationException if another thread mutates the list while iterating.
+    List<AbstractTurnData> snapshot = new ArrayList<>(turnDataList);
+    List<Turn> result = new ArrayList<>(snapshot.size());
+    for (AbstractTurnData turnData : snapshot) {
       if (turnData == null) {
         continue;
       }
@@ -380,4 +382,52 @@ private void ensureReplyInitialized(ReplyData reply) {
       reply.setSteps(new ArrayList<>());
     }
   }
+
+  /**
+   * Converts persisted ToolCallData to AgentToolCall for use with UI components. This is the reverse operation of
+   * convertAgentToolCallToToolCallData.
+   *
+   * @param toolCallData the persisted tool call data
+   * @return AgentToolCall instance for use with UI components
+   */
+  public AgentToolCall convertToolCallDataToAgentToolCall(ToolCallData toolCallData) {
+    if (toolCallData == null) {
+      return null;
+    }
+
+    return new AgentToolCall() {
+      @Override
+      public String getId() {
+        return toolCallData.getId();
+      }
+
+      @Override
+      public String getName() {
+        return toolCallData.getName();
+      }
+
+      @Override
+      public String getProgressMessage() {
+        return toolCallData.getProgressMessage();
+      }
+
+      @Override
+      public String getStatus() {
+        return toolCallData.getStatus();
+      }
+
+      @Override
+      public String getError() {
+        // Extract error from result if present
+        if (toolCallData.getResult() != null && !toolCallData.getResult().isEmpty()) {
+          for (Map<String, Object> result : toolCallData.getResult()) {
+            if (result.containsKey("error")) {
+              return result.get("error").toString();
+            }
+          }
+        }
+        return null;
+      }
+    };
+  }
 }

com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/persistence/ConversationPersistenceManager.java

@@ -257,6 +257,8 @@ private ConversationData getOrCreateNewConversationById(String conversationId) t
     }
 
     ConversationData newConversation = dataFactory.createConversationData(conversationId);
+
+    // must persist conversation and index here to make sure conversation title and last message date is up to date.
     persistAndCacheConversation(newConversation);
     return newConversation;
   }
@@ -265,4 +267,13 @@ private void persistAndCacheConversation(ConversationData conversation) throws I
     persistenceService.saveConversation(conversation);
     conversationCache.put(conversation.getConversationId(), conversation);
   }
-}
+
+  /**
+   * Gets the data factory for data transformation operations.
+   *
+   * @return the ConversationDataFactory instance
+   */
+  public ConversationDataFactory getDataFactory() {
+    return dataFactory;
+  }
+}

com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/persistence/ConversationPersistenceService.java

@@ -82,7 +82,7 @@ public ConversationPersistenceService(AuthStatusManager authStatusManager) {
 
   /**
    * Saves the conversation data to conversation JSON file and updates the index if it's a new conversation or the
-   * conversation title should be updated.
+   * conversation title / lastMessageDate should be updated.
    */
   public void saveConversation(ConversationData conversationData) throws IOException {
     String username = authStatusManager.getUserName();
@@ -91,38 +91,8 @@ public void saveConversation(ConversationData conversationData) throws IOExcepti
       return;
     }
 
-    boolean shouldUpdateIndexConversationId = saveConversationJson(conversationData, username);
-    boolean shouldUpdateIndexTitle = StringUtils.isNotBlank(conversationData.getTitle())
-        && isIndexTitleMissing(conversationData.getConversationId(), username);
-
-    if (shouldUpdateIndexConversationId || shouldUpdateIndexTitle) {
-      updateConversationIndex(conversationData, username);
-    }
-  }
-
-  /**
-   * Checks if the conversation title is missing or empty in the XML index.
-   */
-  private boolean isIndexTitleMissing(String conversationId, String username) {
-    try {
-      Document doc = loadOrCreateIndexDocument(username);
-      Element userElement = getUserElement(doc, username, false);
-
-      if (userElement != null) {
-        Element conversationsElement = findChildElement(userElement, ELEMENT_CONVERSATIONS);
-        if (conversationsElement != null) {
-          Element conversationElement = findConversationElement(conversationsElement, conversationId);
-          if (conversationElement != null) {
-            String existingTitle = conversationElement.getAttribute(ATTR_TITLE);
-            return StringUtils.isBlank(existingTitle);
-          }
-        }
-      }
-      return true;
-    } catch (ParserConfigurationException | SAXException | IOException e) {
-      CopilotCore.LOGGER.error("Failed to check index title for conversation: " + conversationId, e);
-      return true;
-    }
+    saveConversationJson(conversationData, username);
+    updateConversationIndex(conversationData, username);
   }
 
   /** Gets the plugin state location path for the current workspace. */

com.microsoft.copilot.eclipse.ui.terminal.tm/src/com/microsoft/copilot/eclipse/ui/terminal/tm/RunInTerminalTool.java

@@ -329,4 +329,4 @@ private IWorkbenchPage getActivePage() {
   public void setTerminalIconDescriptor(ImageDescriptor iconDescriptor) {
     this.terminalIconDescriptor = iconDescriptor;
   }
-}
+}

com.microsoft.copilot.eclipse.ui.terminal/src/com/microsoft/copilot/eclipse/ui/terminal/RunInTerminalTool.java

@@ -331,4 +331,4 @@ private IWorkbenchPage getActivePage() {
   public void setTerminalIconDescriptor(ImageDescriptor iconDescriptor) {
     this.terminalIconDescriptor = iconDescriptor;
   }
-}
+}

com.microsoft.copilot.eclipse.ui/css/dark.css

@@ -45,6 +45,8 @@
 #chat-container > BeforeLoginWelcomeViewer,
 #chat-container > BeforeLoginWelcomeViewer *,
 #chat-content-wrapper,
+#chat-content-wrapper > ChatHistoryViewer,
+#chat-content-wrapper > ChatHistoryViewer *,
 #chat-content-wrapper > AfterLoginWelcomeViewer,
 #chat-content-wrapper > AfterLoginWelcomeViewer *,
 #chat-content-wrapper > AgentModeViewer,
@@ -96,3 +98,27 @@
 	color: #DEE1E5;
 	background-color: #26282B;
 }
+
+#chat-history-viewer Composite.chat-history-item,
+#chat-history-viewer Composite.chat-history-item * {
+	color: #D3D2D2;           /* default/hover exit foreground */
+	background-color: #1E1F22;/* default/hover exit background */
+}
+
+#chat-history-viewer Composite.chat-history-item-current,
+#chat-history-viewer Composite.chat-history-item-current * {
+	color: #D3D2D2;           /* current item foreground */
+	background-color: #274458;/* current item background */
+}
+
+/* Hover state should override default/current */
+#chat-history-viewer Composite.chat-history-item-hover,
+#chat-history-viewer Composite.chat-history-item-hover * {
+	color: #D3D2D2;           /* hover foreground */
+	background-color: #393B40;/* hover background */
+}
+
+#chat-history-viewer Label.chat-history-item-current-label,
+#chat-history-viewer Label.chat-history-item-date-label {
+	color: #A4A4A4;
+}