Prevent events to be sent to a store rapidly

Author: intitni

Core/Sources/Service/SuggestionCommandHandler/PseudoCommandHandler.swift

@@ -55,14 +55,16 @@ struct PseudoCommandHandler {
         presenter.markAsProcessing(true)
         defer { presenter.markAsProcessing(false) }
 
-        // Check if the current suggestion is still valid.
-        if filespace.validateSuggestions(
-            lines: editor.lines,
-            cursorPosition: editor.cursorPosition
-        ) {
-            return
-        } else {
-            presenter.discardSuggestion(fileURL: filespace.fileURL)
+        if filespace.presentingSuggestion != nil {
+            // Check if the current suggestion is still valid.
+            if filespace.validateSuggestions(
+                lines: editor.lines,
+                cursorPosition: editor.cursorPosition
+            ) {
+                return
+            } else {
+                presenter.discardSuggestion(fileURL: filespace.fileURL)
+            }
         }
 
         let snapshot = FilespaceSuggestionSnapshot(

Core/Sources/Service/SuggestionCommandHandler/WindowBaseCommandHandler.swift

@@ -80,8 +80,6 @@ struct WindowBaseCommandHandler: SuggestionCommandHandler {
 
     @WorkspaceActor
     private func _presentNextSuggestion(editor: EditorContent) async throws {
-        presenter.markAsProcessing(true)
-        defer { presenter.markAsProcessing(false) }
         guard let fileURL = XcodeInspector.shared.realtimeActiveDocumentURL else { return }
         let (workspace, filespace) = try await Service.shared.workspacePool
             .fetchOrCreateWorkspaceAndFilespace(fileURL: fileURL)
@@ -107,8 +105,6 @@ struct WindowBaseCommandHandler: SuggestionCommandHandler {
 
     @WorkspaceActor
     private func _presentPreviousSuggestion(editor: EditorContent) async throws {
-        presenter.markAsProcessing(true)
-        defer { presenter.markAsProcessing(false) }
         guard let fileURL = XcodeInspector.shared.realtimeActiveDocumentURL else { return }
         let (workspace, filespace) = try await Service.shared.workspacePool
             .fetchOrCreateWorkspaceAndFilespace(fileURL: fileURL)
@@ -134,8 +130,6 @@ struct WindowBaseCommandHandler: SuggestionCommandHandler {
 
     @WorkspaceActor
     private func _rejectSuggestion(editor: EditorContent) async throws {
-        presenter.markAsProcessing(true)
-        defer { presenter.markAsProcessing(false) }
         guard let fileURL = XcodeInspector.shared.realtimeActiveDocumentURL else { return }
 
         let (workspace, _) = try await Service.shared.workspacePool
@@ -146,9 +140,6 @@ struct WindowBaseCommandHandler: SuggestionCommandHandler {
 
     @WorkspaceActor
     func acceptSuggestion(editor: EditorContent) async throws -> UpdatedContent? {
-        presenter.markAsProcessing(true)
-        defer { presenter.markAsProcessing(false) }
-
         guard let fileURL = XcodeInspector.shared.realtimeActiveDocumentURL else { return nil }
         let (workspace, _) = try await Service.shared.workspacePool
             .fetchOrCreateWorkspaceAndFilespace(fileURL: fileURL)
@@ -182,9 +173,6 @@ struct WindowBaseCommandHandler: SuggestionCommandHandler {
     }
 
     func acceptPromptToCode(editor: EditorContent) async throws -> UpdatedContent? {
-        presenter.markAsProcessing(true)
-        defer { presenter.markAsProcessing(false) }
-
         guard let fileURL = XcodeInspector.shared.realtimeActiveDocumentURL else { return nil }
 
         let injector = SuggestionInjector()
@@ -363,8 +351,6 @@ extension WindowBaseCommandHandler {
         generateDescription: Bool?,
         name: String?
     ) async throws {
-        presenter.markAsProcessing(true)
-        defer { presenter.markAsProcessing(false) }
         guard let fileURL = XcodeInspector.shared.realtimeActiveDocumentURL else { return }
         let (workspace, filespace) = try await Service.shared.workspacePool
             .fetchOrCreateWorkspaceAndFilespace(fileURL: fileURL)

Core/Sources/SuggestionWidget/SuggestionWidgetController.swift

@@ -223,7 +223,7 @@ public final class SuggestionWidgetController: NSObject {
         dependency.windows.suggestionPanelWindow = suggestionPanelWindow
         dependency.windows.fullscreenDetector = fullscreenDetector
         dependency.windows.widgetWindow = widgetWindow
-
+                                                                                             
         store.send(.startup)
     }
 }
@@ -240,10 +240,12 @@ public extension SuggestionWidgetController {
     }
 
     func markAsProcessing(_ isProcessing: Bool) {
-        if isProcessing {
-            store.send(.circularWidget(.markIsProcessing))
-        } else {
-            store.send(.circularWidget(.endIsProcessing))
+        store.withState { state in
+            if isProcessing, !state.circularWidgetState.isProcessing {
+                store.send(.circularWidget(.markIsProcessing))
+            } else if !isProcessing, state.circularWidgetState.isProcessing {
+                store.send(.circularWidget(.endIsProcessing))
+            }
         }
     }