-
Notifications
You must be signed in to change notification settings - Fork 2k
Expand file tree
/
Copy pathEditsAutoApproveView.swift
More file actions
280 lines (244 loc) · 10.1 KB
/
Copy pathEditsAutoApproveView.swift
File metadata and controls
280 lines (244 loc) · 10.1 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
import AppKit
import Client
import Logger
import Preferences
import SharedUIComponents
import SwiftUI
import UserDefaultsObserver
import ComposableArchitecture
struct EditsAutoApproveView: View {
@State private var isExpanded: Bool = true
@StateObject private var viewModel = ViewModel()
@State private var selection = Set<ViewModel.Rule.ID>()
let rowHeight: CGFloat = 28
private var canRemoveSelection: Bool {
guard !selection.isEmpty else { return false }
return !viewModel.rules.contains { rule in
selection.contains(rule.id) && rule.isDefault
}
}
var body: some View {
VStack(spacing: 0) {
DisclosureSettingsRow(
isExpanded: $isExpanded,
accessibilityLabel: { $0 ? "Collapse edits auto-approve section" : "Expand edits auto-approve section" },
title: { Text("Edits Auto-Approve").font(.headline) },
subtitle: { Text("Controls whether file edits generated by Copilot are approved automatically. Set to **true** to auto-approve edits to matching files; set to **false** to always require explicit approval.") }
)
if isExpanded {
VStack(alignment: .leading, spacing: 0) {
Divider()
rulesTable
Divider()
toolbar
}
.frame(maxWidth: .infinity, alignment: .leading)
.background(QuaternarySystemFillColor.opacity(0.75))
.transition(.opacity.combined(with: .scale(scale: 1, anchor: .top)))
}
}
.settingsContainerStyle(isExpanded: isExpanded)
.onAppear {
viewModel.loadRules()
}
}
@ViewBuilder
private var rulesTable: some View {
if #available(macOS 13.5, *) {
Table(viewModel.rules, selection: $selection) {
TableColumn(Text("Pattern").bold()) { rule in
if rule.isDefault {
Text(rule.pattern).help(rule.pattern)
} else {
EditableText("Pattern", text: rule.pattern) { newText in
viewModel.updateRule(id: rule.id, pattern: newText)
}
.help("Click to edit pattern")
}
}
TableColumn("Description") { rule in
if rule.isDefault {
Text(rule.description).help(rule.description)
} else {
EditableText("Description", text: rule.description) { newText in
viewModel.updateRule(id: rule.id, description: newText)
}
.help(rule.description)
}
}
TableColumn("Type") { rule in
Text(rule.isDefault ? "Default" : "Custom")
.foregroundStyle(.secondary)
}
TableColumn("Auto-Approve") { rule in
Toggle(rule.isDefault ? "Default to false" : "", isOn: Binding(
get: { rule.autoApprove },
set: { viewModel.updateRule(id: rule.id, autoApprove: $0) }
))
.disabled(rule.isDefault)
}
}
.frame(height: CGFloat(max(viewModel.rules.count, 1)) * rowHeight + 40)
.padding(.horizontal, 20)
.transparentBackground()
}
}
@ViewBuilder
private var toolbar: some View {
HStack(spacing: 8) {
Button(action: { viewModel.addRule() }) {
Image(systemName: "plus")
}
.foregroundColor(.primary)
.buttonStyle(.borderless)
.padding(.leading, 8)
Divider()
Group {
if canRemoveSelection {
Button(action: {
viewModel.removeRules(ids: selection)
selection.removeAll()
}) {
Image(systemName: "minus")
}
.buttonStyle(.borderless)
} else {
Image(systemName: "minus")
}
}
.foregroundColor(
canRemoveSelection ? .primary : Color(
nsColor: .quaternaryLabelColor
)
)
.help("Remove selected rules")
Spacer()
}
.frame(height: 24)
.background(TertiarySystemFillColor)
}
}
extension EditsAutoApproveView {
final class ViewModel: ObservableObject {
@Dependency(\.toast) var toast
struct Rule: Identifiable {
var id = UUID()
var pattern: String
var description: String
var autoApprove: Bool
var isDefault: Bool
}
@Published var rules: [Rule] = []
private let defaults = UserDefaults.autoApproval
private var observer = UserDefaultsObserver(
object: UserDefaults.autoApproval,
forKeyPaths: [UserDefaultPreferenceKeys().sensitiveFilesGlobalApprovals.key],
context: nil
)
private let defaultRules: [Rule] = [
Rule(pattern: "**/.github/instructions/*", description: "Github instructions files", autoApprove: false, isDefault: true),
Rule(pattern: "**/github-copilot/**/*", description: "Github Copilot settings and token files", autoApprove: false, isDefault: true),
]
init() {
observer.onChange = { [weak self] in
DispatchQueue.main.async {
self?.loadRules()
}
}
}
func loadRules() {
var loadedRules: [Rule] = []
// Load from UserDefaults
let state = defaults.value(for: \.sensitiveFilesGlobalApprovals)
let savedRules = state.rules
func findExistingID(pattern: String) -> UUID {
return rules.first(where: { $0.pattern == pattern })?.id ?? UUID()
}
// Add default rules first
for defaultRule in defaultRules {
var rule = defaultRule
// If it exists in persisted config, override properties that can be changed (autoApprove)
// We keep the default description unless we want to allow overriding it.
if let savedRule = savedRules[defaultRule.pattern] {
rule.autoApprove = savedRule.autoApprove
if !savedRule.description.isEmpty {
rule.description = savedRule.description
}
}
rule.id = findExistingID(pattern: rule.pattern)
loadedRules.append(rule)
}
// Add custom rules
for (patternKey, value) in savedRules {
// Skip if it's a default rule
if defaultRules.contains(where: { $0.pattern == patternKey }) { continue }
let id = findExistingID(pattern: patternKey)
loadedRules.append(Rule(id: id, pattern: patternKey, description: value.description, autoApprove: value.autoApprove, isDefault: false))
}
rules = loadedRules.sorted {
if $0.isDefault != $1.isDefault {
return $0.isDefault // Defaults first
}
return $0.pattern < $1.pattern
}
}
func addRule() {
var counter = 0
var newPattern = "New Pattern"
while rules.contains(where: { $0.pattern == newPattern }) {
counter += 1
newPattern = "New Pattern \(counter)"
}
rules.append(Rule(pattern: newPattern, description: "Description", autoApprove: false, isDefault: false))
saveRules()
}
func removeRules(ids: Set<UUID>) {
rules.removeAll { ids.contains($0.id) && !$0.isDefault }
saveRules()
}
@discardableResult
func updateRule(id: UUID, pattern: String? = nil, description: String? = nil, autoApprove: Bool? = nil) -> Bool {
guard let index = rules.firstIndex(where: { $0.id == id }) else { return false }
if let pattern {
var newPattern = pattern.filter { !$0.isNewline }
newPattern = newPattern.trimmingCharacters(in: .whitespacesAndNewlines)
if !rules.contains(where: { $0.id != id && $0.pattern == newPattern }) {
rules[index].pattern = newPattern
} else {
toast("Duplicate patterns are not allowed. Please ensure each rule has a unique pattern.", .warning)
return false
}
}
if let description { rules[index].description = description }
if let autoApprove { rules[index].autoApprove = autoApprove }
saveRules()
return true
}
func saveRules() {
// Check for duplicate patterns
let patterns = rules.map(\.pattern)
let uniquePatterns = Set(patterns)
if patterns.count != uniquePatterns.count {
return
}
var state = defaults.value(for: \.sensitiveFilesGlobalApprovals)
var newRules: [String: SensitiveFileRule] = [:]
for rule in rules {
newRules[rule.pattern] = SensitiveFileRule(description: rule.description, autoApprove: rule.autoApprove)
}
state.rules = newRules
defaults.set(state, for: \.sensitiveFilesGlobalApprovals)
Task {
do {
let service = try getService()
try await service.postNotification(
name: Notification.Name
.gitHubCopilotShouldRefreshEditorInformation.rawValue
)
} catch {
toast(error.localizedDescription, .error)
}
}
}
}
}