You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
1.**Testing and Validation**: Consider adding a way to simulate PR workflows in a staging environment to validate these changes before merging into the main branch. This is particularly useful for `pull_request_target` workflows.
2
+
3
+
2.**Error Handling**: While `set -euo pipefail` improves robustness, consider adding error messages in critical commands or logging for better debugging.
4
+
5
+
3.**Trigger Coverage**: Double-check if `closed` should potentially be monitored to handle edge cases where PRs are closed directly after being reopened or synchronized.
6
+
7
+
4.**Environment Variable Validation**: Include a check at the start of the script to ensure that critical `env` variables (like `PR_NUMBER`) are properly set before execution.
8
+
9
+
5.**Documentation Improvements**:
10
+
- Expand on the rationale behind these changes in the `README.md` or repo documentation. Explicitly describe why fork PRs must be auto-closed and same-repo PRs ignored.
11
+
- Add comments wherever non-obvious logic is used to ensure future maintainers understand the conditions and implications.
12
+
13
+
6.**Close Comment Guidance**:
14
+
- Include a link in the close comment directing contributors to documentation about why fork PRs aren’t accepted.
0 commit comments