On branch edburns/resolve-fake-test-time-token-failures

modified:   src/test/java/com/github/copilot/sdk/E2ETestContext.java
modified:   src/test/java/com/github/copilot/sdk/ExecutorWiringTest.java

Given that the live API was never used, I see no reason why we should condition the setting of fake tokens on the runtime environment (CI vs local).

The replaying proxy intercepts everything regardless of environment. The fake token just satisfies the CLI's startup check — it's never sent to a real API. The `GITHUB_ACTIONS` guard is unnecessary and is what broke local runs.

Author: edburns

src/test/java/com/github/copilot/sdk/E2ETestContext.java

@@ -270,15 +270,10 @@ public Map<String, String> getEnvironment() {
             env.put("REQUESTS_CA_BUNDLE", caFile);
             env.put("CURL_CA_BUNDLE", caFile);
             env.put("GIT_SSL_CAINFO", caFile);
-            env.put("GH_TOKEN", "");
-            env.put("GITHUB_TOKEN", "");
-            env.put("GH_ENTERPRISE_TOKEN", "");
-            env.put("GITHUB_ENTERPRISE_TOKEN", "");
-        }
-
-        if ("true".equals(System.getenv("GITHUB_ACTIONS"))) {
             env.put("GH_TOKEN", "fake-token-for-e2e-tests");
             env.put("GITHUB_TOKEN", "fake-token-for-e2e-tests");
+            env.put("GH_ENTERPRISE_TOKEN", "");
+            env.put("GITHUB_ENTERPRISE_TOKEN", "");
         }
 
         return env;
@@ -291,13 +286,7 @@ public Map<String, String> getEnvironment() {
      */
     public CopilotClient createClient() {
         CopilotClientOptions options = new CopilotClientOptions().setCliPath(cliPath).setCwd(workDir.toString())
-                .setEnvironment(getEnvironment());
-
-        // In CI (GitHub Actions), use a fake token to avoid auth issues
-        String ci = System.getenv("GITHUB_ACTIONS");
-        if (ci != null && !ci.isEmpty()) {
-            options.setGitHubToken("fake-token-for-e2e-tests");
-        }
+                .setEnvironment(getEnvironment()).setGitHubToken("fake-token-for-e2e-tests");
 
         return new CopilotClient(options);
     }
@@ -321,10 +310,7 @@ public CopilotClient createClient(CopilotClientOptions options) {
         if (options.getEnvironment() == null || options.getEnvironment().isEmpty()) {
             options.setEnvironment(getEnvironment());
         }
-
-        // In CI (GitHub Actions), use a fake token to avoid auth issues
-        String ci = System.getenv("GITHUB_ACTIONS");
-        if (ci != null && !ci.isEmpty() && options.getGitHubToken() == null) {
+        if (options.getGitHubToken() == null) {
             options.setGitHubToken("fake-token-for-e2e-tests");
         }
 

src/test/java/com/github/copilot/sdk/ExecutorWiringTest.java

@@ -87,12 +87,8 @@ int getTaskCount() {
 
     private CopilotClientOptions createOptionsWithExecutor(TrackingExecutor executor) {
         CopilotClientOptions options = new CopilotClientOptions().setCliPath(ctx.getCliPath())
-                .setCwd(ctx.getWorkDir().toString()).setEnvironment(ctx.getEnvironment()).setExecutor(executor);
-
-        String ci = System.getenv("GITHUB_ACTIONS");
-        if (ci != null && !ci.isEmpty()) {
-            options.setGitHubToken("fake-token-for-e2e-tests");
-        }
+                .setCwd(ctx.getWorkDir().toString()).setEnvironment(ctx.getEnvironment()).setExecutor(executor)
+                .setGitHubToken("fake-token-for-e2e-tests");
         return options;
     }