Skip to content

Commit 66da8c4

Browse files
Copilotedburns
andauthored
Fix test failures: update assertions for generated enum type changes
- GeneratedEventTypesCoverageTest: use valid ExitPlanModeAction values (exit_only/interactive/autopilot instead of approve/edit/reject), use McpServerStatus instead of McpServersLoadedServerStatus, use SkillSource.PROJECT enum instead of string "project" - SessionEventDeserializationTest: same ExitPlanModeAction fix - ModeHandlersTest: compare ExitPlanModeAction.INTERACTIVE enum instead of string "interactive" for selectedAction() Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
1 parent ba6e981 commit 66da8c4

3 files changed

Lines changed: 11 additions & 10 deletions

File tree

src/test/java/com/github/copilot/sdk/ModeHandlersTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import org.junit.jupiter.api.BeforeAll;
1616
import org.junit.jupiter.api.Test;
1717

18+
import com.github.copilot.sdk.generated.ExitPlanModeAction;
1819
import com.github.copilot.sdk.generated.ExitPlanModeCompletedEvent;
1920
import com.github.copilot.sdk.generated.ExitPlanModeRequestedEvent;
2021
import com.github.copilot.sdk.json.AutoModeSwitchRequest;
@@ -89,7 +90,7 @@ void shouldInvokeExitPlanModeHandlerWhenModelUsesTool() throws Exception {
8990
requestedEvent.complete(requested);
9091
} else if (event instanceof ExitPlanModeCompletedEvent completed
9192
&& Boolean.TRUE.equals(completed.getData().approved())
92-
&& "interactive".equals(completed.getData().selectedAction())) {
93+
&& ExitPlanModeAction.INTERACTIVE == completed.getData().selectedAction()) {
9394
completedEvent.complete(completed);
9495
}
9596
});
@@ -109,7 +110,7 @@ void shouldInvokeExitPlanModeHandlerWhenModelUsesTool() throws Exception {
109110

110111
var compEvent = completedEvent.get(10, TimeUnit.SECONDS);
111112
assertTrue(compEvent.getData().approved());
112-
assertEquals("interactive", compEvent.getData().selectedAction());
113+
assertEquals(ExitPlanModeAction.INTERACTIVE, compEvent.getData().selectedAction());
113114

114115
assertNotNull(response);
115116

src/test/java/com/github/copilot/sdk/SessionEventDeserializationTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2326,8 +2326,8 @@ void testParseExitPlanModeRequestedEvent() throws Exception {
23262326
"requestId": "plan-req-001",
23272327
"summary": "Plan is ready",
23282328
"planContent": "## Plan\\n1. Do thing",
2329-
"actions": ["approve", "edit", "reject"],
2330-
"recommendedAction": "approve"
2329+
"actions": ["exit_only", "interactive", "autopilot"],
2330+
"recommendedAction": "interactive"
23312331
}
23322332
}
23332333
""";
@@ -2338,7 +2338,7 @@ void testParseExitPlanModeRequestedEvent() throws Exception {
23382338
assertEquals("plan-req-001", event.getData().requestId());
23392339
assertEquals("Plan is ready", event.getData().summary());
23402340
assertEquals(3, event.getData().actions().size());
2341-
assertEquals("approve", event.getData().recommendedAction());
2341+
assertEquals(ExitPlanModeAction.INTERACTIVE, event.getData().recommendedAction());
23422342
}
23432343

23442344
@Test

src/test/java/com/github/copilot/sdk/generated/GeneratedEventTypesCoverageTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -210,14 +210,14 @@ void testParseElicitationCompletedEventCancel() throws Exception {
210210
void testParseExitPlanModeRequestedEvent() throws Exception {
211211
var event = parse(
212212
"""
213-
{"type":"exit_plan_mode.requested","data":{"requestId":"epm-1","summary":"Implement login","planContent":"# Plan\\n1. Create login","actions":["approve","edit","reject"],"recommendedAction":"approve"}}
213+
{"type":"exit_plan_mode.requested","data":{"requestId":"epm-1","summary":"Implement login","planContent":"# Plan\\n1. Create login","actions":["exit_only","interactive","autopilot"],"recommendedAction":"interactive"}}
214214
""");
215215
assertInstanceOf(ExitPlanModeRequestedEvent.class, event);
216216
assertEquals("exit_plan_mode.requested", event.getType());
217217
var typed = (ExitPlanModeRequestedEvent) event;
218218
assertEquals("epm-1", typed.getData().requestId());
219219
assertEquals("Implement login", typed.getData().summary());
220-
assertEquals("approve", typed.getData().recommendedAction());
220+
assertEquals(ExitPlanModeAction.INTERACTIVE, typed.getData().recommendedAction());
221221
assertEquals(3, typed.getData().actions().size());
222222
}
223223

@@ -464,7 +464,7 @@ void testParseSessionMcpServersLoadedEvent() throws Exception {
464464
assertNotNull(typed.getData().servers());
465465
assertEquals(1, typed.getData().servers().size());
466466
assertEquals("mcp1", typed.getData().servers().get(0).name());
467-
assertEquals(McpServersLoadedServerStatus.CONNECTED, typed.getData().servers().get(0).status());
467+
assertEquals(McpServerStatus.CONNECTED, typed.getData().servers().get(0).status());
468468
}
469469

470470
@Test
@@ -529,7 +529,7 @@ void testParseSessionSkillsLoadedEvent() throws Exception {
529529
assertEquals(1, typed.getData().skills().size());
530530
var skill = typed.getData().skills().get(0);
531531
assertEquals("deploy", skill.name());
532-
assertEquals("project", skill.source());
532+
assertEquals(SkillSource.PROJECT, skill.source());
533533
assertTrue(skill.userInvocable());
534534
assertTrue(skill.enabled());
535535
}
@@ -699,6 +699,6 @@ void testSessionContextChangedHostTypeEnumFromValue() {
699699

700700
@Test
701701
void testSessionMcpServersLoadedStatusEnumFromValue() {
702-
assertThrows(IllegalArgumentException.class, () -> McpServersLoadedServerStatus.fromValue("unknown"));
702+
assertThrows(IllegalArgumentException.class, () -> McpServerStatus.fromValue("unknown"));
703703
}
704704
}

0 commit comments

Comments
 (0)