Skip to content

Commit a9c88d7

Browse files
Copilotedburns
andauthored
Refine timeout constants from validation feedback
Agent-Logs-Url: https://github.com/github/copilot-sdk-java/sessions/38b90523-b5be-4dbd-9d33-36361110399b Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
1 parent ee55571 commit a9c88d7

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

src/main/java/com/github/copilot/sdk/CliServerManager.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
final class CliServerManager {
3131

3232
private static final Logger LOG = Logger.getLogger(CliServerManager.class.getName());
33+
private static final int STDERR_READER_JOIN_TIMEOUT_MS = 5000;
3334

3435
private final CopilotClientOptions options;
3536
private final StringBuilder stderrBuffer = new StringBuilder();
@@ -254,7 +255,7 @@ private void awaitStderrReader() {
254255
Thread t = this.stderrThread;
255256
if (t != null) {
256257
try {
257-
t.join(5000);
258+
t.join(STDERR_READER_JOIN_TIMEOUT_MS);
258259
} catch (InterruptedException e) {
259260
Thread.currentThread().interrupt();
260261
}

src/main/java/com/github/copilot/sdk/CopilotClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public final class CopilotClient implements AutoCloseable {
7676
* shutdown via {@link #stop()}.
7777
*/
7878
public static final int AUTOCLOSEABLE_TIMEOUT_SECONDS = 10;
79-
private static final long FORCE_KILL_TIMEOUT_SECONDS = 10;
79+
private static final int FORCE_KILL_TIMEOUT_SECONDS = 10;
8080
private final CopilotClientOptions options;
8181
private final CliServerManager serverManager;
8282
private final LifecycleEventManager lifecycleManager = new LifecycleEventManager();

0 commit comments

Comments
 (0)