Skip to content

Commit e5add4d

Browse files
committed
Refactor testShouldHandlePermissionHandlerErrorsGracefully to remove TODO comment and clarify error handling
1 parent 927f6b6 commit e5add4d

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

src/test/java/com/github/copilot/sdk/PermissionsTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -233,8 +233,6 @@ void testToolCallIdInPermissionRequests(TestInfo testInfo) throws Exception {
233233
void testShouldHandlePermissionHandlerErrorsGracefully(TestInfo testInfo) throws Exception {
234234
ctx.configureForTest("permissions", "should_handle_permission_handler_errors_gracefully");
235235

236-
// TODO: this test throws this exception and the stacktrace is being logged. We
237-
// need to prevent that.
238236
SessionConfig config = new SessionConfig().setOnPermissionRequest((request, invocation) -> {
239237
// Throw an error in the handler
240238
throw new RuntimeException("Handler error");

0 commit comments

Comments
 (0)