-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Expand file tree
/
Copy pathsession_fs_sqlite_e2e_test.go
More file actions
414 lines (375 loc) · 11.7 KB
/
Copy pathsession_fs_sqlite_e2e_test.go
File metadata and controls
414 lines (375 loc) · 11.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
package e2e
import (
"encoding/json"
"fmt"
"sort"
"strings"
"sync"
"testing"
"time"
copilot "github.com/github/copilot-sdk/go"
"github.com/github/copilot-sdk/go/internal/e2e/testharness"
"github.com/github/copilot-sdk/go/rpc"
)
type sqliteCall struct {
SessionID string
QueryType string
Query string
}
// inMemorySqliteProvider is a SessionFSProvider backed by in-memory maps with a stub SQLite handler.
// The stub returns plausible canned responses based on query type rather than executing real SQL.
// This avoids pulling in a real SQLite dependency (which would force a go directive bump across
// all scenario go.mod files).
type inMemorySqliteProvider struct {
mu sync.Mutex
sessionID string
files map[string]string
dirs map[string]bool
hadQuery bool
sqliteCalls *[]sqliteCall
}
func newInMemorySqliteProvider(sessionID string, calls *[]sqliteCall) *inMemorySqliteProvider {
return &inMemorySqliteProvider{
sessionID: sessionID,
files: make(map[string]string),
dirs: map[string]bool{"/": true},
sqliteCalls: calls,
}
}
func (p *inMemorySqliteProvider) ensureParent(path string) {
parts := strings.Split(strings.TrimRight(path, "/"), "/")
for i := 1; i < len(parts); i++ {
p.dirs[strings.Join(parts[:i], "/")] = true
}
}
func (p *inMemorySqliteProvider) ReadFile(path string) (string, error) {
p.mu.Lock()
defer p.mu.Unlock()
content, ok := p.files[path]
if !ok {
return "", fmt.Errorf("file not found: %s", path)
}
return content, nil
}
func (p *inMemorySqliteProvider) WriteFile(path string, content string, mode *int) error {
p.mu.Lock()
defer p.mu.Unlock()
p.ensureParent(path)
p.files[path] = content
return nil
}
func (p *inMemorySqliteProvider) AppendFile(path string, content string, mode *int) error {
p.mu.Lock()
defer p.mu.Unlock()
p.ensureParent(path)
p.files[path] = p.files[path] + content
return nil
}
func (p *inMemorySqliteProvider) Exists(path string) (bool, error) {
p.mu.Lock()
defer p.mu.Unlock()
_, isFile := p.files[path]
_, isDir := p.dirs[path]
return isFile || isDir, nil
}
func (p *inMemorySqliteProvider) Stat(path string) (*copilot.SessionFSFileInfo, error) {
p.mu.Lock()
defer p.mu.Unlock()
now := time.Now().UTC()
if p.dirs[path] {
return &copilot.SessionFSFileInfo{
IsFile: false, IsDirectory: true, Size: 0, Mtime: now, Birthtime: now,
}, nil
}
if content, ok := p.files[path]; ok {
return &copilot.SessionFSFileInfo{
IsFile: true, IsDirectory: false, Size: int64(len(content)), Mtime: now, Birthtime: now,
}, nil
}
return nil, fmt.Errorf("not found: %s", path)
}
func (p *inMemorySqliteProvider) MakeDirectory(path string, recursive bool, mode *int) error {
p.mu.Lock()
defer p.mu.Unlock()
if recursive {
parts := strings.Split(strings.TrimRight(path, "/"), "/")
for i := 1; i <= len(parts); i++ {
p.dirs[strings.Join(parts[:i], "/")] = true
}
} else {
p.dirs[path] = true
}
return nil
}
func (p *inMemorySqliteProvider) ReadDirectory(path string) ([]string, error) {
p.mu.Lock()
defer p.mu.Unlock()
prefix := strings.TrimRight(path, "/") + "/"
names := map[string]bool{}
for f := range p.files {
if strings.HasPrefix(f, prefix) {
rest := f[len(prefix):]
if rest != "" {
names[strings.SplitN(rest, "/", 2)[0]] = true
}
}
}
for d := range p.dirs {
if strings.HasPrefix(d, prefix) {
rest := d[len(prefix):]
if rest != "" {
names[strings.SplitN(rest, "/", 2)[0]] = true
}
}
}
result := make([]string, 0, len(names))
for n := range names {
result = append(result, n)
}
sort.Strings(result)
return result, nil
}
func (p *inMemorySqliteProvider) ReadDirectoryWithTypes(path string) ([]rpc.SessionFSReaddirWithTypesEntry, error) {
p.mu.Lock()
defer p.mu.Unlock()
prefix := strings.TrimRight(path, "/") + "/"
entries := map[string]rpc.SessionFSReaddirWithTypesEntryType{}
for d := range p.dirs {
if strings.HasPrefix(d, prefix) {
rest := d[len(prefix):]
if rest != "" {
name := strings.SplitN(rest, "/", 2)[0]
entries[name] = rpc.SessionFSReaddirWithTypesEntryTypeDirectory
}
}
}
for f := range p.files {
if strings.HasPrefix(f, prefix) {
rest := f[len(prefix):]
if rest != "" {
name := strings.SplitN(rest, "/", 2)[0]
if _, exists := entries[name]; !exists {
entries[name] = rpc.SessionFSReaddirWithTypesEntryTypeFile
}
}
}
}
result := make([]rpc.SessionFSReaddirWithTypesEntry, 0, len(entries))
for name, typ := range entries {
result = append(result, rpc.SessionFSReaddirWithTypesEntry{Name: name, Type: typ})
}
sort.Slice(result, func(i, j int) bool { return result[i].Name < result[j].Name })
return result, nil
}
func (p *inMemorySqliteProvider) Remove(path string, recursive bool, force bool) error {
p.mu.Lock()
defer p.mu.Unlock()
delete(p.files, path)
delete(p.dirs, path)
return nil
}
func (p *inMemorySqliteProvider) Rename(src string, dest string) error {
p.mu.Lock()
defer p.mu.Unlock()
if content, ok := p.files[src]; ok {
p.ensureParent(dest)
p.files[dest] = content
delete(p.files, src)
}
return nil
}
func (p *inMemorySqliteProvider) SqliteQuery(queryType rpc.SessionFSSqliteQueryType, query string, params map[string]any) (*copilot.SessionFSSqliteQueryResult, error) {
p.mu.Lock()
defer p.mu.Unlock()
p.hadQuery = true
*p.sqliteCalls = append(*p.sqliteCalls, sqliteCall{
SessionID: p.sessionID,
QueryType: string(queryType),
Query: query,
})
// Return canned results based on query type. The agent doesn't know or care
// whether a real SQLite database is behind this — it just receives SQL tool
// results. These stubs return plausible responses so the agent can proceed
// normally without pulling in a real SQLite dependency.
upper := strings.ToUpper(strings.TrimSpace(query))
switch queryType {
case rpc.SessionFSSqliteQueryTypeExec:
return &copilot.SessionFSSqliteQueryResult{Columns: []string{}, Rows: []map[string]any{}}, nil
case rpc.SessionFSSqliteQueryTypeRun:
lastID := int64(1)
return &copilot.SessionFSSqliteQueryResult{
Columns: []string{},
Rows: []map[string]any{},
RowsAffected: 1,
LastInsertRowid: &lastID,
}, nil
case rpc.SessionFSSqliteQueryTypeQuery:
if strings.Contains(upper, "SELECT") {
return &copilot.SessionFSSqliteQueryResult{
Columns: []string{"id", "name"},
Rows: []map[string]any{{"id": "a1", "name": "Widget"}},
}, nil
}
return &copilot.SessionFSSqliteQueryResult{Columns: []string{}, Rows: []map[string]any{}}, nil
}
return &copilot.SessionFSSqliteQueryResult{Columns: []string{}, Rows: []map[string]any{}}, nil
}
func (p *inMemorySqliteProvider) SqliteExists() (bool, error) {
p.mu.Lock()
defer p.mu.Unlock()
return p.hadQuery, nil
}
func TestSessionFSSqliteE2E(t *testing.T) {
ctx := testharness.NewTestContext(t)
sessionStatePath := createSessionStatePath(t)
sessionFSConfig := &copilot.SessionFSConfig{
InitialWorkingDirectory: "/",
SessionStatePath: sessionStatePath,
Conventions: rpc.SessionFSSetProviderConventionsPosix,
Capabilities: &copilot.SessionFSCapabilities{Sqlite: true},
}
var sqliteCalls []sqliteCall
var providers sync.Map
createSessionFSHandler := func(session *copilot.Session) copilot.SessionFSProvider {
p := newInMemorySqliteProvider(session.SessionID, &sqliteCalls)
providers.Store(session.SessionID, p)
return p
}
client := ctx.NewClient(func(opts *copilot.ClientOptions) {
opts.SessionFS = sessionFSConfig
})
t.Cleanup(func() { client.ForceStop() })
t.Run("should route sql queries through the sessionfs sqlite handler", func(t *testing.T) {
ctx.ConfigureForTest(t)
sqliteCalls = nil
session, err := client.CreateSession(t.Context(), &copilot.SessionConfig{
OnPermissionRequest: copilot.PermissionHandler.ApproveAll,
CreateSessionFSProvider: createSessionFSHandler,
})
if err != nil {
t.Fatalf("Failed to create session: %v", err)
}
msg, err := session.SendAndWait(t.Context(), copilot.MessageOptions{
Prompt: `Use the sql tool to create a table called "items" with columns id (TEXT PRIMARY KEY) and name (TEXT). ` +
`Then insert a row with id "a1" and name "Widget".`,
})
if err != nil {
t.Fatalf("Failed to send message: %v", err)
}
_ = msg
// Verify sqlite handler was called
sessionCalls := filterCalls(sqliteCalls, session.SessionID)
if len(sessionCalls) == 0 {
t.Fatal("Expected sqlite handler to be called")
}
assertCallContains(t, sessionCalls, "CREATE TABLE")
assertCallContains(t, sessionCalls, "INSERT")
// Verify queryType is set correctly
assertQueryType(t, sessionCalls, "exec")
assertQueryType(t, sessionCalls, "run")
if err := session.Disconnect(); err != nil {
t.Fatalf("Failed to disconnect: %v", err)
}
})
t.Run("should allow subagents to use sql tool via inherited sessionfs", func(t *testing.T) {
ctx.ConfigureForTest(t)
sqliteCalls = nil
session, err := client.CreateSession(t.Context(), &copilot.SessionConfig{
OnPermissionRequest: copilot.PermissionHandler.ApproveAll,
CreateSessionFSProvider: createSessionFSHandler,
})
if err != nil {
t.Fatalf("Failed to create session: %v", err)
}
_, err = session.SendAndWait(t.Context(), copilot.MessageOptions{
Prompt: "Use the task tool to ask a task agent to do the following: " +
"Use the sql tool to run this query: INSERT INTO todos " +
"(id, title, status) VALUES ('subagent-test', 'Created by subagent', 'done')",
})
if err != nil {
t.Fatalf("Failed to send message: %v", err)
}
if err := session.Disconnect(); err != nil {
t.Fatalf("Failed to disconnect: %v", err)
}
// Verify INSERT calls were routed
sessionCalls := filterCalls(sqliteCalls, session.SessionID)
insertCalls := filterByQuery(sessionCalls, "INSERT")
if len(insertCalls) == 0 {
t.Fatal("Expected INSERT calls from subagent")
}
// Read events.jsonl from in-memory FS
val, ok := providers.Load(session.SessionID)
if !ok {
t.Fatal("Provider not found for session")
}
provider := val.(*inMemorySqliteProvider)
eventsPath := sessionStatePath + "/events.jsonl"
content, err := provider.ReadFile(eventsPath)
if err != nil {
t.Fatalf("Failed to read events.jsonl: %v", err)
}
lines := strings.Split(strings.TrimSpace(content), "\n")
var sqlToolEvents []map[string]any
for _, line := range lines {
if line == "" {
continue
}
var event map[string]any
if err := json.Unmarshal([]byte(line), &event); err != nil {
continue
}
if event["type"] == "tool.execution_start" {
if data, ok := event["data"].(map[string]any); ok {
if data["toolName"] == "sql" {
sqlToolEvents = append(sqlToolEvents, event)
}
}
}
}
if len(sqlToolEvents) == 0 {
t.Fatal("Expected sql tool events in events.jsonl")
}
for _, e := range sqlToolEvents {
if e["agentId"] == nil || e["agentId"] == "" {
t.Error("Expected agentId on sql tool event")
}
}
})
}
func filterCalls(calls []sqliteCall, sessionID string) []sqliteCall {
var result []sqliteCall
for _, c := range calls {
if c.SessionID == sessionID {
result = append(result, c)
}
}
return result
}
func filterByQuery(calls []sqliteCall, keyword string) []sqliteCall {
var result []sqliteCall
for _, c := range calls {
if strings.Contains(strings.ToUpper(c.Query), keyword) {
result = append(result, c)
}
}
return result
}
func assertCallContains(t *testing.T, calls []sqliteCall, keyword string) {
t.Helper()
for _, c := range calls {
if strings.Contains(strings.ToUpper(c.Query), keyword) {
return
}
}
t.Errorf("Expected a call with query containing %q", keyword)
}
func assertQueryType(t *testing.T, calls []sqliteCall, queryType string) {
t.Helper()
for _, c := range calls {
if c.QueryType == queryType {
return
}
}
t.Errorf("Expected a call with queryType %q", queryType)
}