Skip to content

Commit b433ee2

Browse files
committed
MSM: remove unnecessary imports
1 parent 350b70c commit b433ee2

4 files changed

Lines changed: 5 additions & 10 deletions

File tree

ql_demos/cpp/Qualcomm-MSM-copy_from_user/00_copy_from_user.ql

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
*/
66

77
import cpp
8-
import semmle.code.cpp.rangeanalysis.SimpleRangeAnalysis
98

109
// This first query is essentially equivalent to `grep -r copy_from_user`.
1110
// It has almost 1300 results.

ql_demos/cpp/Qualcomm-MSM-copy_from_user/04_safe_malloc.ql

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77

88
import cpp
99
import semmle.code.cpp.valuenumbering.GlobalValueNumbering
10-
import semmle.code.cpp.dataflow.TaintTracking
11-
import DataFlow
10+
import semmle.code.cpp.dataflow.DataFlow
1211

1312
// Let's see if we can detect this pattern:
1413
//
@@ -26,7 +25,7 @@ predicate safe_malloc(FunctionCall allocCall, FunctionCall copy_from_user) {
2625
copy_from_user.getTarget().getName() = "copy_from_user" and
2726
source.asExpr() = allocCall and
2827
sink.asExpr() = copy_from_user.getArgument(0) and
29-
localFlow(source, sink) and
28+
DataFlow::localFlow(source, sink) and
3029
globalValueNumber(allocCall.getArgument(0)) =
3130
globalValueNumber(copy_from_user.getArgument(2)))
3231
}

ql_demos/cpp/Qualcomm-MSM-copy_from_user/05_filter_with_upperbound_and_safe_malloc.ql

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@
1010
import cpp
1111
import semmle.code.cpp.rangeanalysis.SimpleRangeAnalysis
1212
import semmle.code.cpp.valuenumbering.GlobalValueNumbering
13-
import semmle.code.cpp.dataflow.TaintTracking
14-
import DataFlow
13+
import semmle.code.cpp.dataflow.DataFlow
1514

1615
// We wrote this predicate in the previous query.
1716
predicate safe_malloc(FunctionCall allocCall, FunctionCall copy_from_user) {
@@ -20,7 +19,7 @@ predicate safe_malloc(FunctionCall allocCall, FunctionCall copy_from_user) {
2019
copy_from_user.getTarget().getName() = "copy_from_user" and
2120
source.asExpr() = allocCall and
2221
sink.asExpr() = copy_from_user.getArgument(0) and
23-
localFlow(source, sink) and
22+
DataFlow::localFlow(source, sink) and
2423
globalValueNumber(allocCall.getArgument(0)) =
2524
globalValueNumber(copy_from_user.getArgument(2)))
2625
}

ql_demos/cpp/Qualcomm-MSM-copy_from_user/06_stackaddress_dataflow.ql

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,7 @@
1010

1111
import cpp
1212
import semmle.code.cpp.rangeanalysis.SimpleRangeAnalysis
13-
import semmle.code.cpp.valuenumbering.GlobalValueNumbering
14-
import semmle.code.cpp.dataflow.TaintTracking
15-
import DataFlow
13+
import semmle.code.cpp.dataflow.DataFlow
1614
import DataFlow::PathGraph
1715

1816
class Config extends DataFlow::Configuration {

0 commit comments

Comments
 (0)