Merge pull request #16 from kevinbackhouse/FizzDemoTypo

adityasharad · web-flow · commit e83f5b3abf22 · 2019-11-07T10:29:31.000-08:00
Fix typo in comment
diff --git a/ql_demos/cpp/Facebook_Fizz_CVE-2019-3560/FizzOverflow.ql b/ql_demos/cpp/Facebook_Fizz_CVE-2019-3560/FizzOverflow.ql
@@ -35,7 +35,7 @@ class Cfg extends TaintTracking::Configuration {
         .getFunctionSymbol() instanceof EndianConvert
   }
 
-  /** Hold if `sink` is a narrowing conversion. */
+  /** Holds if `sink` is a narrowing conversion. */
   override predicate isSink(DataFlow::Node sink) {
     sink.asInstruction().getResultSize() < sink
           .asInstruction()

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ class Cfg extends TaintTracking::Configuration {`
`35`	`35`	`.getFunctionSymbol() instanceof EndianConvert`
`36`	`36`	`}`
`37`	`37`
`38`		- /** Hold if `sink` is a narrowing conversion. */
	`38`	+ /** Holds if `sink` is a narrowing conversion. */
`39`	`39`	`override predicate isSink(DataFlow::Node sink) {`
`40`	`40`	`sink.asInstruction().getResultSize() < sink`
`41`	`41`	`.asInstruction()`