From 481863427305726ef890d5eaa89f8faf02bdc0c0 Mon Sep 17 00:00:00 2001 From: Shx Guo Date: Thu, 25 Jan 2024 15:27:47 +0800 Subject: [PATCH 1/2] Prevent the chat window size and position being reset when it's hidden --- .../SuggestionWidget/FeatureReducers/WidgetFeature.swift | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/Core/Sources/SuggestionWidget/FeatureReducers/WidgetFeature.swift b/Core/Sources/SuggestionWidget/FeatureReducers/WidgetFeature.swift index 86943827..9be10fc5 100644 --- a/Core/Sources/SuggestionWidget/FeatureReducers/WidgetFeature.swift +++ b/Core/Sources/SuggestionWidget/FeatureReducers/WidgetFeature.swift @@ -539,13 +539,7 @@ public struct WidgetFeature: ReducerProtocol { } if isChatPanelDetached { - if windows.chatPanelWindow.alphaValue == 0 { - windows.chatPanelWindow.setFrame( - widgetLocation.defaultPanelLocation.frame, - display: false, - animate: animated - ) - } + // don't update it! } else { windows.chatPanelWindow.setFrame( widgetLocation.defaultPanelLocation.frame, From 23b7f3cb205a66cd7bbb097a550762508f529b99 Mon Sep 17 00:00:00 2001 From: Shx Guo Date: Thu, 25 Jan 2024 15:28:13 +0800 Subject: [PATCH 2/2] Use isWindowHidden to control the opacity of chat window --- .../SuggestionWidget/FeatureReducers/WidgetFeature.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Core/Sources/SuggestionWidget/FeatureReducers/WidgetFeature.swift b/Core/Sources/SuggestionWidget/FeatureReducers/WidgetFeature.swift index 9be10fc5..5e17481c 100644 --- a/Core/Sources/SuggestionWidget/FeatureReducers/WidgetFeature.swift +++ b/Core/Sources/SuggestionWidget/FeatureReducers/WidgetFeature.swift @@ -208,7 +208,7 @@ public struct WidgetFeature: ReducerProtocol { await send(.updateWindowOpacity(immediately: false)) if isDetached { Task { @MainActor in - windows.chatPanelWindow.alphaValue = 1 + windows.chatPanelWindow.isWindowHidden = false } } }