fix: ensure attachment even when suggestion is disabled

Author: AntoineGS

lua/copilot/client/init.lua

@@ -8,6 +8,7 @@ local client_config = require("copilot.client.config")
 local is_disabled = false
 
 ---@class CopilotClient
+---@field augroup string|nil
 ---@field id integer|nil
 ---@field capabilities lsp.ClientCapabilities | nil
 ---@field config vim.lsp.ClientConfig | nil
@@ -16,6 +17,7 @@ local is_disabled = false
 -- Only for informational purposes, use Vim API to check actual status
 ---@field buffer_statuses table<integer, string>
 local M = {
+  augroup = nil,
   id = nil,
   capabilities = nil,
   config = nil,
@@ -166,12 +168,37 @@ function M.setup()
 
   is_disabled = false
   M.id = nil
+
+  -- nvim_clear_autocmds throws an error if the group does not exist
+  local augroup = "copilot.client"
+  vim.api.nvim_create_augroup(augroup, { clear = true })
+  M.augroup = augroup
+
+  vim.api.nvim_create_autocmd("FileType", {
+    group = M.augroup,
+    callback = function()
+      logger.trace("filetype autocmd called")
+      vim.schedule(function()
+        -- todo: when we do lazy/late attaching this needs changing
+        M.buf_attach()
+      end)
+    end,
+    desc = "[copilot] (suggestion) file type",
+  })
+
   vim.schedule(M.ensure_client_started)
+  -- FileType is likely already triggered for shown buffer
+  vim.schedule(M.buf_attach)
 end
 
 function M.teardown()
   is_disabled = true
 
+  -- nvim_clear_autocmds throws an error if the group does not exist
+  if M.augroup then
+    vim.api.nvim_clear_autocmds({ group = M.augroup })
+  end
+
   if M.id then
     vim.lsp.stop_client(M.id)
   end

lua/copilot/suggestion/init.lua

@@ -740,10 +740,6 @@ local function on_insert_enter()
   request_suggestion_when_auto_trigger("insert enter")
 end
 
-local function on_filetype()
-  request_suggestion_when_auto_trigger("file type")
-end
-
 local function on_buf_enter()
   if vim.fn.mode():match("^[iR]") then
     request_suggestion_when_auto_trigger("buf enter")
@@ -805,12 +801,6 @@ local function create_autocmds()
     desc = "[copilot] (suggestion) insert enter",
   })
 
-  vim.api.nvim_create_autocmd("FileType", {
-    group = M.augroup,
-    callback = on_filetype,
-    desc = "[copilot] (suggestion) file type",
-  })
-
   vim.api.nvim_create_autocmd("BufEnter", {
     group = copilot.augroup,
     callback = on_buf_enter,