Handle the case where the suggestion is partial but fully typed

Author: intitni

Core/Tests/ServiceTests/FilespaceSuggestionInvalidationTests.swift

@@ -78,7 +78,7 @@ class FilespaceSuggestionInvalidationTests: XCTestCase {
             range: .init(startPair: (1, 0), endPair: (1, 0))
         )
         let isValid = await filespace.validateSuggestions(
-            lines: ["\n", "h🎆🎆o man\n", "\n"],
+            lines: ["\n", "h🎆🎆o ma\n", "\n"],
             cursorPosition: .init(line: 1, character: 2)
         )
         XCTAssertTrue(isValid)
@@ -95,7 +95,7 @@ class FilespaceSuggestionInvalidationTests: XCTestCase {
             range: .init(startPair: (1, 0), endPair: (1, 0))
         )
         let isValid = await filespace.validateSuggestions(
-            lines: ["\n", "h🎆🎆o man\n", "\n"],
+            lines: ["\n", "h🎆🎆o ma\n", "\n"],
             cursorPosition: .init(line: 1, character: 3)
         )
         XCTAssertTrue(isValid)
@@ -170,7 +170,7 @@ class FilespaceSuggestionInvalidationTests: XCTestCase {
             range: .init(startPair: (1, 0), endPair: (1, 0))
         )
         let wasValid = await filespace.validateSuggestions(
-            lines: ["\n", "hello man\n", "\n"],
+            lines: ["\n", "hello ma\n", "\n"],
             cursorPosition: .init(line: 1, character: 8)
         )
         let isValid = await filespace.validateSuggestions(
@@ -190,7 +190,7 @@ class FilespaceSuggestionInvalidationTests: XCTestCase {
             range: .init(startPair: (1, 0), endPair: (1, 0))
         )
         let wasValid = await filespace.validateSuggestions(
-            lines: ["\n", "hello m🎆🎆an\n", "\n"],
+            lines: ["\n", "hello m🎆🎆a\n", "\n"],
             cursorPosition: .init(line: 1, character: 12)
         )
         let isValid = await filespace.validateSuggestions(
@@ -211,7 +211,7 @@ class FilespaceSuggestionInvalidationTests: XCTestCase {
             range: .init(startPair: (1, 0), endPair: (1, 0))
         )
         let wasValid = await filespace.validateSuggestions(
-            lines: ["\n", "hello man!!!!!\n", "\n"],
+            lines: ["\n", "hello ma!!!!\n", "\n"],
             cursorPosition: .init(line: 1, character: 8)
         )
         let isValid = await filespace.validateSuggestions(

Pro

@@ -83,7 +83,7 @@ public extension Filespace {
             )
 
             let utf16View = editingLine.utf16
-            
+
             let startIndex = utf16View.index(
                 utf16View.startIndex,
                 offsetBy: max(0, presentingSuggestion.range.start.character),
@@ -102,11 +102,13 @@ public extension Filespace {
 
             return ""
         }()
-        
+
         /// if the line will not change after accepting the suggestion
-        if presentingSuggestion.range.isOneLine {
-            #warning("TODO: Also handle the case where the suggestion doesn't start at character 0")
-            if editingLine == suggestionFirstLine {
+        if suggestionLines.count == 1 {
+            if editingLine.hasPrefix(suggestionFirstLine),
+               cursorPosition.character
+               >= suggestionFirstLine.utf16.count + presentingSuggestion.range.start.character
+            {
                 reset()
                 resetSnapshot()
                 return false