Merge branch 'feature/inline-suggestion-panel' into hotfix/0.18.3

Author: intitni

Core/Sources/AXExtension/AXUIElement.swift

@@ -63,6 +63,10 @@ public extension AXUIElement {
     var isEnabled: Bool {
         (try? copyValue(key: kAXEnabledAttribute)) ?? false
     }
+    
+    var isHidden: Bool {
+        (try? copyValue(key: kAXHiddenAttribute)) ?? false
+    }
 }
 
 // MARK: - Rect

Core/Sources/AXNotificationStream/AXNotificationStream.swift

@@ -6,7 +6,7 @@ public final class AXNotificationStream: AsyncSequence {
     public typealias Stream = AsyncStream<Element>
     public typealias Continuation = Stream.Continuation
     public typealias AsyncIterator = Stream.AsyncIterator
-    public typealias Element = (name: String, info: CFDictionary)
+    public typealias Element = (name: String, element: AXUIElement, info: CFDictionary)
 
     private var continuation: Continuation
     private let stream: Stream
@@ -48,7 +48,7 @@ public final class AXNotificationStream: AsyncSequence {
         ) {
             guard let pointer = pointer?.assumingMemoryBound(to: Continuation.self)
             else { return }
-            pointer.pointee.yield((notificationName as String, userInfo))
+            pointer.pointee.yield((notificationName as String, element, userInfo))
         }
 
         _ = AXObserverCreateWithInfoCallback(

Core/Sources/HostApp/FeatureSettings/SuggestionSettingsView.swift

@@ -32,8 +32,8 @@ struct SuggestionSettingsView: View {
                 Picker(selection: $settings.suggestionPresentationMode) {
                     ForEach(PresentationMode.allCases, id: \.rawValue) {
                         switch $0 {
-                        case .comment:
-                            Text("Comment (Deprecating Soon)").tag($0)
+                        case .nearbyTextCursor:
+                            Text("Nearby Text Cursor").tag($0)
                         case .floatingWidget:
                             Text("Floating Widget").tag($0)
                         }

Core/Sources/Service/GUI/GraphicalUserInterfaceController.swift.swift

@@ -5,7 +5,6 @@ import SuggestionWidget
 @MainActor
 public final class GraphicalUserInterfaceController {
     public nonisolated static let shared = GraphicalUserInterfaceController()
-    nonisolated let realtimeSuggestionIndicatorController = RealtimeSuggestionIndicatorController()
     nonisolated let suggestionWidget = SuggestionWidgetController()
     private nonisolated init() {
         Task { @MainActor in

Core/Sources/Service/GUI/RealtimeSuggestionIndicatorController.swift

@@ -28,10 +28,6 @@ public class RealtimeSuggestionController {
     private var focusedUIElement: AXUIElement?
     private var sourceEditor: SourceEditor?
 
-    var isCommentMode: Bool {
-        UserDefaults.shared.value(for: \.suggestionPresentationMode) == .comment
-    }
-
     private nonisolated init() {
         Task { [weak self] in
 
@@ -179,16 +175,6 @@ public class RealtimeSuggestionController {
         if keycode == escape {
             if event.type == .keyDown {
                 await cancelInFlightTasks()
-            } else {
-                Task {
-                    #warning(
-                        "TODO: Any method to avoid using AppleScript to check that completion panel is presented?"
-                    )
-                    if isCommentMode, await Environment.frontmostXcodeWindowIsEditor() {
-                        if Task.isCancelled { return }
-                        self.triggerPrefetchDebounced(force: true)
-                    }
-                }
             }
         }
     }
@@ -214,11 +200,6 @@ public class RealtimeSuggestionController {
 
             Logger.service.info("Prefetch suggestions.")
 
-            if !force, isCommentMode, await !Environment.frontmostXcodeWindowIsEditor() {
-                Logger.service.info("Completion panel is open, blocked.")
-                return
-            }
-
             // So the editor won't be blocked (after information are cached)!
             await PseudoCommandHandler().generateRealtimeSuggestions(sourceEditor: sourceEditor)
         }