Update widget show/hide behavior

Author: intitni

Core/Sources/AXExtension/AXUIElement.swift

@@ -15,7 +15,7 @@ public extension AXUIElement {
     var title: String {
         (try? copyValue(key: kAXTitleAttribute)) ?? ""
     }
-    
+
     var role: String {
         (try? copyValue(key: kAXRoleAttribute)) ?? ""
     }
@@ -32,12 +32,12 @@ public extension AXUIElement {
     var description: String {
         (try? copyValue(key: kAXDescriptionAttribute)) ?? ""
     }
-    
+
     /// Type in Accessibility Inspector.
     var roleDescription: String {
         (try? copyValue(key: kAXRoleDescriptionAttribute)) ?? ""
     }
-    
+
     var label: String {
         (try? copyValue(key: kAXLabelValueAttribute)) ?? ""
     }
@@ -113,6 +113,10 @@ public extension AXUIElement {
         (try? copyValue(key: kAXWindowsAttribute)) ?? []
     }
 
+    var isFullScreen: Bool {
+        (try? copyValue(key: "AXFullScreen")) ?? false
+    }
+
     var focusedWindow: AXUIElement? {
         try? copyValue(key: kAXFocusedWindowAttribute)
     }
@@ -164,7 +168,7 @@ public extension AXUIElement {
         }
         return nil
     }
-    
+
     func children(where match: (AXUIElement) -> Bool) -> [AXUIElement] {
         var all = [AXUIElement]()
         for child in children {
@@ -175,7 +179,7 @@ public extension AXUIElement {
         }
         return all
     }
-    
+
     func firstChild(where match: (AXUIElement) -> Bool) -> AXUIElement? {
         for child in children {
             if match(child) { return child }
@@ -233,3 +237,4 @@ public extension AXUIElement {
 }
 
 extension AXError: Error {}
+

Core/Sources/SuggestionWidget/SuggestionWidgetController.swift

@@ -10,6 +10,23 @@ import UserDefaultsObserver
 
 @MainActor
 public final class SuggestionWidgetController: NSObject {
+    private lazy var fullscreenDetector = {
+        let it = CanBecomeKeyWindow(
+            contentRect: .zero,
+            styleMask: .borderless,
+            backing: .buffered,
+            defer: false
+        )
+        it.isReleasedWhenClosed = false
+        it.isOpaque = false
+        it.backgroundColor = .clear
+        it.collectionBehavior = [.canJoinAllSpaces, .fullScreenAuxiliary]
+        it.hasShadow = false
+        it.setIsVisible(true)
+        it.canBecomeKeyChecker = { false }
+        return it
+    }()
+    
     private lazy var widgetWindow = {
         let it = CanBecomeKeyWindow(
             contentRect: .zero,
@@ -21,7 +38,7 @@ public final class SuggestionWidgetController: NSObject {
         it.isOpaque = false
         it.backgroundColor = .clear
         it.level = .init(19)
-        it.collectionBehavior = [.canJoinAllSpaces, .fullScreenAuxiliary]
+        it.collectionBehavior = [.fullScreenAuxiliary]
         it.hasShadow = true
         it.contentView = NSHostingView(
             rootView: WidgetView(
@@ -52,7 +69,7 @@ public final class SuggestionWidgetController: NSObject {
         it.isOpaque = false
         it.backgroundColor = .clear
         it.level = .init(19)
-        it.collectionBehavior = [.canJoinAllSpaces, .fullScreenAuxiliary]
+        it.collectionBehavior = [.fullScreenAuxiliary]
         it.hasShadow = true
         it.contentView = NSHostingView(
             rootView: TabView(chatWindowViewModel: chatWindowViewModel)
@@ -64,7 +81,7 @@ public final class SuggestionWidgetController: NSObject {
 
     private lazy var panelWindow = {
         let it = CanBecomeKeyWindow(
-            contentRect: .zero,
+            contentRect: .init(x: 0, y: 0, width: Style.panelWidth, height: Style.panelHeight),
             styleMask: .borderless,
             backing: .buffered,
             defer: false
@@ -73,16 +90,13 @@ public final class SuggestionWidgetController: NSObject {
         it.isOpaque = false
         it.backgroundColor = .clear
         it.level = .init(NSWindow.Level.floating.rawValue + 1)
-        it.collectionBehavior = [.canJoinAllSpaces, .fullScreenAuxiliary]
+        it.collectionBehavior = [.fullScreenAuxiliary]
         it.hasShadow = true
         it.contentView = NSHostingView(
             rootView: SuggestionPanelView(viewModel: suggestionPanelViewModel)
         )
         it.setIsVisible(true)
-        it.canBecomeKeyChecker = { [suggestionPanelViewModel] in
-            if case .promptToCode = suggestionPanelViewModel.content { return true }
-            return false
-        }
+        it.canBecomeKeyChecker = { true }
         return it
     }()
 
@@ -97,7 +111,7 @@ public final class SuggestionWidgetController: NSObject {
         it.isOpaque = false
         it.backgroundColor = .clear
         it.level = .floating
-        it.collectionBehavior = [.canJoinAllSpaces, .fullScreenAuxiliary]
+        it.collectionBehavior = [.fullScreenAuxiliary]
         it.hasShadow = true
         it.contentView = NSHostingView(
             rootView: ChatWindowView(viewModel: chatWindowViewModel)
@@ -128,6 +142,7 @@ public final class SuggestionWidgetController: NSObject {
     private var windowChangeObservationTask: Task<Void, Error>?
     private var activeApplicationMonitorTask: Task<Void, Error>?
     private var sourceEditorMonitorTask: Task<Void, Error>?
+    private var fullscreenDetectingTask: Task<Void, Error>?
     private var currentFileURL: URL?
     private var colorScheme: ColorScheme = .light
     private var cancellable = Set<AnyCancellable>()
@@ -174,6 +189,27 @@ public final class SuggestionWidgetController: NSObject {
             }
         }
 
+        Task { @MainActor in
+            fullscreenDetectingTask = Task { [weak self] in
+                let sequence = NSWorkspace.shared.notificationCenter
+                    .notifications(named: NSWorkspace.activeSpaceDidChangeNotification)
+                _ = self?.fullscreenDetector
+                for await _ in sequence {
+                    try Task.checkCancellation()
+                    guard let self else { return }
+                    guard let activeXcode = ActiveApplicationMonitor.activeXcode else { continue }
+                    guard fullscreenDetector.isOnActiveSpace else { continue }
+                    let app = AXUIElementCreateApplication(activeXcode.processIdentifier)
+                    if let window = app.focusedWindow, window.isFullScreen {
+                        widgetWindow.orderFrontRegardless()
+                        tabWindow.orderFrontRegardless()
+                        panelWindow.orderFrontRegardless()
+                        chatWindow.orderFrontRegardless()
+                    }
+                }
+            }
+        }
+
         Task { @MainActor in
             presentationModeChangeObserver.onChange = { [weak self] in
                 guard let self else { return }
@@ -224,7 +260,7 @@ public final class SuggestionWidgetController: NSObject {
             }
         }
     }
-    
+
     public func detachChat() {
         chatWindowViewModel.chatPanelInASeparateWindow = true
     }
@@ -499,16 +535,14 @@ extension SuggestionWidgetController {
         }
 
         if let app = ActiveApplicationMonitor.activeApplication, app.isXcode {
-            let application = AXUIElementCreateApplication(app.processIdentifier)
-            let noFocus = application.focusedWindow == nil
-            panelWindow.alphaValue = noFocus ? 0 : 1
-            widgetWindow.alphaValue = noFocus ? 0 : 1
-            tabWindow.alphaValue = noFocus ? 0 : 1
+            panelWindow.alphaValue = 1
+            widgetWindow.alphaValue = 1
+            tabWindow.alphaValue = 1
 
             if detachChat {
                 chatWindow.alphaValue = chatWindowViewModel.chat != nil ? 1 : 0
             } else {
-                chatWindow.alphaValue = noFocus ? 0 : 1
+                chatWindow.alphaValue = 1
             }
         } else if let app = ActiveApplicationMonitor.activeApplication,
                   app.bundleIdentifier == Bundle.main.bundleIdentifier