Fix a racing issue

Author: intitni

Core/Sources/Service/WorkspaceExtension/Filespace+SuggestionService.swift

@@ -13,13 +13,15 @@ struct FilespaceSuggestionSnapshotKey: FilespacePropertyKey {
 }
 
 extension FilespacePropertyValues {
+    @WorkspaceActor
     var suggestionSourceSnapshot: FilespaceSuggestionSnapshot {
         get { self[FilespaceSuggestionSnapshotKey.self] }
         set { self[FilespaceSuggestionSnapshotKey.self] = newValue }
     }
 }
 
 extension Filespace {
+    @WorkspaceActor
     func resetSnapshot() {
         // swiftformat:disable redundantSelf
         self.suggestionSourceSnapshot = FilespaceSuggestionSnapshotKey.createDefaultValue()

Core/Sources/Service/WorkspaceExtension/SuggestionWorkspacePlugin.swift

@@ -57,18 +57,6 @@ final class SuggestionServiceWorkspacePlugin: WorkspacePlugin {
         return true
     }
 
-    func canAutoTriggerGetSuggestions(
-        forFileAt fileURL: URL,
-        lines: [String],
-        cursorPosition: CursorPosition
-    ) -> Bool {
-        guard isRealtimeSuggestionEnabled else { return false }
-        guard let filespace = filespaces[fileURL] else { return true }
-        if lines.hashValue != filespace.suggestionSourceSnapshot.linesHash { return true }
-        if cursorPosition != filespace.suggestionSourceSnapshot.cursorPosition { return true }
-        return false
-    }
-
     override init(workspace: Workspace) {
         super.init(workspace: workspace)
 

Tool/Sources/Workspace/Filespace.swift

@@ -8,8 +8,9 @@ public protocol FilespacePropertyKey {
 }
 
 public final class FilespacePropertyValues {
-    var storage: [ObjectIdentifier: Any] = [:]
+    private var storage: [ObjectIdentifier: Any] = [:]
 
+    @WorkspaceActor
     public subscript<K: FilespacePropertyKey>(_ key: K.Type) -> K.Value {
         get {
             if let value = storage[ObjectIdentifier(key)] as? K.Value {
@@ -65,7 +66,7 @@ public final class Filespace {
     }
 
     private(set) var lastSuggestionUpdateTime: Date = Environment.now()
-    var additionalProperties = FilespacePropertyValues()
+    private var additionalProperties = FilespacePropertyValues()
     let fileSaveWatcher: FileSaveWatcher
     let onClose: (URL) -> Void
 
@@ -87,6 +88,7 @@ public final class Filespace {
         }
     }
 
+    @WorkspaceActor
     public subscript<K>(
         dynamicMember dynamicMember: WritableKeyPath<FilespacePropertyValues, K>
     ) -> K {

Tool/Sources/Workspace/Workspace.swift

@@ -10,8 +10,9 @@ public protocol WorkspacePropertyKey {
 }
 
 public class WorkspacePropertyValues {
-    var storage: [ObjectIdentifier: Any] = [:]
+    private var storage: [ObjectIdentifier: Any] = [:]
 
+    @WorkspaceActor
     public subscript<K: WorkspacePropertyKey>(_ key: K.Type) -> K.Value {
         get {
             if let value = storage[ObjectIdentifier(key)] as? K.Value {
@@ -56,7 +57,7 @@ public final class Workspace {
         }
     }
 
-    var additionalProperties = WorkspacePropertyValues()
+    private var additionalProperties = WorkspacePropertyValues()
     public internal(set) var plugins = [ObjectIdentifier: WorkspacePlugin]()
     public let workspaceURL: URL
     public let projectRootURL: URL