Fix that a tab can be registered to an empty id

intitni · intitni · commit 8043cd60428a · 2024-10-30T20:10:14.000+08:00
diff --git a/Core/Sources/Service/GUI/GraphicalUserInterfaceController.swift b/Core/Sources/Service/GUI/GraphicalUserInterfaceController.swift
@@ -367,7 +367,7 @@ extension ChatTabPool {
         let id = id
         let info = ChatTabInfo(id: id, title: "")
         guard let chatTap = await builder.build(store: createStore(id)) else { return nil }
-        setTab(chatTap)
+        setTab(chatTap, forId: id)
         return (chatTap, info)
     }
 
@@ -379,7 +379,7 @@ extension ChatTabPool {
         let info = ChatTabInfo(id: id, title: "")
         let builder = kind?.builder ?? ChatGPTChatTab.defaultBuilder()
         guard let chatTap = await builder.build(store: createStore(id)) else { return nil }
-        setTab(chatTap)
+        setTab(chatTap, forId: id)
         return (chatTap, info)
     }
 
diff --git a/Tool/Sources/ChatTab/ChatTabPool.swift b/Tool/Sources/ChatTab/ChatTabPool.swift
@@ -22,8 +22,8 @@ public final class ChatTabPool {
         pool[id]
     }
 
-    public func setTab(_ tab: any ChatTab) {
-        pool[tab.id] = tab
+    public func setTab(_ tab: any ChatTab, forId id: String) {
+        pool[id] = tab
     }
 
     public func removeTab(of id: String) {

Original file line number	Diff line number	Diff line change
`@@ -22,8 +22,8 @@ public final class ChatTabPool {`
`22`	`22`	`pool[id]`
`23`	`23`	`}`
`24`	`24`
`25`		`- public func setTab(_ tab: any ChatTab) {`
`26`		`- pool[tab.id] = tab`
	`25`	`+ public func setTab(_ tab: any ChatTab, forId id: String) {`
	`26`	`+ pool[id] = tab`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`public func removeTab(of id: String) {`