feat: surface node version error reliably

Author: MunifTanjim

lua/copilot/client.lua

@@ -10,6 +10,7 @@ local M = {
   capabilities = nil,
   config = nil,
   node_version = nil,
+  node_version_error = nil,
   startup_error = nil,
 }
 
@@ -44,13 +45,14 @@ if not lsp_start then
   end
 end
 
----@return string
+---@return string node_version
+---@return nil|string node_version_error
 function M.get_node_version()
   if not M.node_version then
     local node = config.get("copilot_node_command")
 
     local cmd = { node, "--version" }
-    local cmd_output_table = vim.fn.systemlist(cmd, nil, false)
+    local cmd_output_table = vim.fn.executable(node) == 1 and vim.fn.systemlist(cmd, nil, false) or { "" }
     local cmd_output = cmd_output_table[#cmd_output_table]
     local cmd_exit_code = vim.v.shell_error
 
@@ -59,33 +61,25 @@ function M.get_node_version()
     local node_version_minor = tonumber(string.match(node_version, "^%d+%.(%d+)%.")) or 0
 
     if node_version_major == 0 then
-      local err = "[Copilot] Could not determine Node.js version"
-      vim.notify(err, vim.log.levels.WARN)
-      vim.api.nvim_echo({
-        {
-          table.concat({
-            err,
-            "-----------",
-            "(exit code) " .. tostring(cmd_exit_code),
-            "   (output) " .. cmd_output,
-            "-----------",
-          }, "\n"),
-          "MoreMsg",
-        },
-      }, true, {})
+      M.node_version_error = table.concat({
+        "Could not determine Node.js version",
+        "-----------",
+        "(exit code) " .. tostring(cmd_exit_code),
+        "   (output) " .. cmd_output,
+        "-----------",
+      }, "\n")
     elseif
       node_version_major < 16
       or (node_version_major == 16 and node_version_minor < 14)
       or (node_version_major == 17 and node_version_minor < 3)
     then
-      local err = string.format("[Copilot] Node.js version 18.x or newer required but found %s", node_version)
-      vim.notify(err, vim.log.levels.WARN)
+      M.node_version_error = string.format("Node.js version 18.x or newer required but found %s", node_version)
     end
 
     M.node_version = node_version or ""
   end
 
-  return M.node_version
+  return M.node_version, M.node_version_error
 end
 
 function M.buf_is_attached(bufnr)
@@ -208,15 +202,17 @@ local function prepare_client_config(overrides)
       end)
     end,
     on_exit = function(code, _signal, client_id)
-      if code > 0 then
+      if M.id == client_id then
         vim.schedule(function()
-          -- in case for unsupported node
-          M.get_node_version()
+          M.teardown()
+          M.id = nil
+          M.capabilities = nil
         end)
       end
-      if M.id == client_id then
-        M.id = nil
-        M.capabilities = nil
+      if code > 0 then
+        vim.schedule(function()
+          require("copilot.command").status()
+        end)
       end
     end,
     handlers = {

lua/copilot/command.lua

@@ -12,7 +12,7 @@ local function node_version_warning(node_version)
       line = line
         .. " 'copilot_node_command' is set to a non-default value. Consider removing it from your configuration."
     end
-    return { line, "WarningMsg" }
+    return { line, "MoreMsg" }
   end
 end
 
@@ -36,8 +36,11 @@ function mod.version()
       lines[#lines + 1] = "copilot/dist/agent.js" .. " " .. "not running"
     end
 
-    local node_version = c.get_node_version()
+    local node_version, node_version_error = c.get_node_version()
     lines[#lines + 1] = "Node.js" .. " " .. (#node_version == 0 and "(unknown)" or node_version)
+    if node_version_error then
+      lines[#lines + 1] = { node_version_error, "WarningMsg" }
+    end
     lines[#lines + 1] = node_version_warning(node_version)
 
     local chunks = {}
@@ -58,23 +61,31 @@ function mod.status()
       return
     end
 
-    lines[#lines + 1] = type(line) == "table" and line or { "[Copilot] " .. line }
+    lines[#lines + 1] = type(line) == "table" and { "[Copilot] " .. line[1], line[2] } or { "[Copilot] " .. line }
     lines[#lines + 1] = { "\n", "NONE" }
   end
 
   local function flush_lines(last_line, is_off)
     add_line(last_line)
 
+    if c.startup_error then
+      add_line({ c.startup_error, "WarningMsg" })
+    end
+
+    local node_version, node_version_error = c.get_node_version()
+    if node_version_error then
+      add_line({ node_version_error, "WarningMsg" })
+    end
+
     if not is_off then
-      add_line(node_version_warning(c.get_node_version()))
+      add_line(node_version_warning(node_version))
     end
 
     vim.api.nvim_echo(lines, true, {})
   end
 
   if c.is_disabled() then
-    add_line("Offline")
-    flush_lines(c.startup_error, true)
+    flush_lines("Offline", true)
     return
   end