fix: is_visible() returning stale state after accept

Fixes zbirenbaum#638

Author: AntoineGS

lua/copilot/suggestion/init.lua

@@ -635,10 +635,11 @@ function M.accept(modifier)
 
   local newText
 
+  ignore_next_cursor_moved = true
+
   if accepted_partial then
     newText = suggestion.partial_text
     ctx.accepted_partial = true
-    ignore_next_cursor_moved = true
   else
     M.clear_preview()
     newText = suggestion.text

tests/test_suggestion.lua

@@ -280,6 +280,21 @@ T["suggestion()"]["suggestion with range offset"] = function()
   child.wait_for_suggestion()
 
   reference_screenshot(child.get_screenshot(), nil, { ignore_text = { 9, 10 }, ignore_attr = { 9, 10 } })
+T["suggestion()"]["is_visible returns nil after accept"] = function()
+  child.o.lines, child.o.columns = 10, 15
+  child.config.suggestion = child.config.suggestion .. "auto_trigger = true,"
+  child.configure_copilot()
+  child.type_keys("i123", "<Esc>", "o456", "<Esc>", "o7")
+  child.wait_for_suggestion()
+  local is_visible_before = child.lua('return require("copilot.suggestion").is_visible()')
+  assert(is_visible_before, "is_visible should be true before accept")
+
+  child.lua('require("copilot.suggestion").accept()')
+  -- Allow scheduled functions to complete
+  child.lua("vim.wait(200, function() return false end, 10)")
+
+  local is_visible_after = child.lua('return require("copilot.suggestion").is_visible()')
+  MiniTest.expect.equality(is_visible_after, vim.NIL)
 end
 
 T["suggestion()"]["next keymap triggers suggestion"] = function()