fix: add wget fallback, prevent Copilot from re-attaching upon startup error

Author: AntoineGS

lua/copilot/client.lua

@@ -2,7 +2,7 @@ local api = require("copilot.api")
 local config = require("copilot.config")
 local util = require("copilot.util")
 local logger = require("copilot.logger")
-local lsp_binary_util = require("copilot.lsp_binary")
+local lsp_binary = require("copilot.lsp_binary")
 
 local is_disabled = false
 
@@ -57,6 +57,11 @@ end
 
 ---@param force? boolean
 function M.buf_attach(force)
+  if lsp_binary.initialization_failed then
+    M.startup_error = "initialization of copilot-language-server failed"
+    return
+  end
+
   if is_disabled then
     logger.warn("copilot is disabled")
     return
@@ -189,12 +194,12 @@ local function get_handlers()
 end
 
 local function prepare_client_config(overrides)
-  if lsp_binary_util.initialization_failed then
+  if lsp_binary.initialization_failed then
     M.startup_error = "initializatino of copilot-language-server failed"
     return
   end
 
-  local server_path = lsp_binary_util.get_copilot_server_info().absolute_filepath
+  local server_path = lsp_binary.get_copilot_server_info().absolute_filepath
 
   M.startup_error = nil
 
@@ -337,7 +342,7 @@ function M.setup()
   })
 
   vim.schedule(function()
-    if lsp_binary_util.ensure_client_is_downloaded() then
+    if lsp_binary.ensure_client_is_downloaded() then
       M.buf_attach()
     end
   end)

lua/copilot/lsp_binary.lua

@@ -39,15 +39,57 @@ local function delete_all_except(folder, except_file)
   end
 end
 
+---@param url string
+---@param local_server_zip_filepath string
+---@return boolean
+local function download_file_with_wget(url, local_server_zip_filepath)
+  return false
+  -- if vim.fn.executable("wget") == 0 then
+  --   return false
+  -- end
+  --
+  -- local wget_cmd = string.format('wget -O "%s" "%s"', local_server_zip_filepath:gsub("\\", "\\\\"), url)
+  -- logger.trace("Downloading copilot-language-server with command: " .. wget_cmd)
+  -- local result = vim.fn.system(wget_cmd)
+  --
+  -- if vim.v.shell_error ~= 0 then
+  --   logger.error("error downloading file with wget: " .. result)
+  --   return false
+  -- end
+  --
+  -- return true
+end
+
+---@param url string
+---@param local_server_zip_filepath string
+---@return boolean
+local function download_file_with_curl(url, local_server_zip_filepath)
+  return false
+  -- if vim.fn.executable("curl") == 0 then
+  --   return false
+  -- end
+  --
+  -- local cmd = string.format('curl -s -L -o "%s" "%s"', local_server_zip_filepath:gsub("\\", "\\\\"), url)
+  -- logger.trace("downloading copilot-language-server with command: " .. cmd)
+  -- local result = vim.fn.system(cmd)
+  --
+  -- if vim.v.shell_error ~= 0 then
+  --   logger.error("error downloading file: " .. result)
+  --   return false
+  -- end
+  --
+  -- return true
+end
+
 ---@param url string
 ---@param local_server_zip_filepath string
 ---@param local_server_zip_path string
 ---@return boolean
 local function download_file(url, local_server_zip_filepath, local_server_zip_path)
   logger.notify("current version of copilot-language-server is not downloaded, downloading")
 
-  if vim.fn.executable("curl") ~= 1 then
-    vim.api.nvim_err_writeln("Error: curl is not available")
+  if (vim.fn.executable("curl") ~= 1) and (vim.fn.executable("wget") == 1) then
+    logger.error("neither curl nor wget is available, please make sure one of them is installed")
     M.initialization_failed = true
     return false
   end
@@ -62,26 +104,12 @@ local function download_file(url, local_server_zip_filepath, local_server_zip_pa
     end
   end
 
-  local cookie_file = vim.fs.joinpath(local_server_zip_path, "cookies.txt")
-  local cmd = string.format(
-    'curl -s -L -c "%s" -b "%s" -o "%s" "%s"',
-    cookie_file:gsub("\\", "\\\\"),
-    cookie_file:gsub("\\", "\\\\"),
-    local_server_zip_filepath:gsub("\\", "\\\\"),
-    url
-  )
-
-  logger.trace("Downloading copilot-language-server with command: " .. cmd)
-  local result = vim.fn.system(cmd)
-
-  if vim.v.shell_error ~= 0 then
-    logger.error("Error downloading file: " .. result)
-    return false
-  end
-
-  -- Clean up cookie file
-  if vim.fn.filereadable(cookie_file) == 1 then
-    vim.fn.delete(cookie_file)
+  if not download_file_with_curl(url, local_server_zip_filepath) then
+    if not download_file_with_wget(url, local_server_zip_filepath) then
+      logger.error("could not download the copilot sever")
+      M.initialization_failed = true
+      return false
+    end
   end
 
   logger.debug("copilot-language-server downloaded to " .. local_server_zip_filepath)
@@ -167,7 +195,7 @@ function M.ensure_client_is_downloaded()
 
   local copilot_version = util.get_editor_info().editorPluginInfo.version
   local plugin_path = vim.fs.normalize(util.get_plugin_path())
-  local copilot_server_info = M.get_copilot_server_info(copilot_version, plugin_path)
+  local copilot_server_info = M.get_copilot_server_info()
   local download_filename =
     string.format("copilot-language-server-%s-%s.zip", copilot_server_info.path, copilot_version)
   local url = string.format(