Feature Request: Ability to approve workflow runs from the mobile app

[deadlydog]

Select Topic Area

Product Feedback

Body

GitHub has Environments that allow you to add Required reviewers, which effectively can block a workflow run until it is manually reviewed/approved. Here's the docs. This is a critical feature for many enterprise organizations, allowing them to block deployments to ensure it does not go out until the appropriate time.

Currently, the reviewers will get a notification that they need to approve the workflow run, but they are not able to approve it from the mobile app. They can view the workflow run, but there is no button to approve it. Instead, you currently need to log into the GitHub website from your phone (which often tries to redirect you back into the app) and approve the workflow run from there. The workflow run website page is not optimized for mobile though, so it's a bit of a pain to get to the button.

It would be great if the mobile app allowed you to approve workflow runs without needing to go to the website.

[alcere]

@deadlydog Thanks for your feedback. Approving deployments should be possible using the mobile app. Can you share with us the platform and app version you are using? I'd like to investigate this issue deeper. Thanks!

[deadlydog]

Hi @alcere , I'm using an iPhone 12 Pro iOS 17.3.1, with the latest GitHub App version 1.151.1.

Here's a screenshot of the workflow run shown in the app, either when clicking the "Review pending deployments" link in the approval email, or when manually navigating to the GitHub Actions workflow app manually in the app:

The only button that's available to click is "Cancel workflow"; there is no Review or Approve button.

Here's what the same workflow run looks like when I open it up in the browser (Edge in this case):

And this is what the approval on the website looks like when I click the "Review deployments" button:

Since I'm signed into the same account on both and everything works fine from the website, it should not be a permission issue.

[alcere]

Oh, I see! We only support opening the Deployment review dialog using notifications (Push notifications, or within the Notifications section) in the GitHub mobile app. But I totally understand your problem here; it should be possible too using the link or from the GitHub Action itself. I will open an internal issue to follow up on this and consider adding the option to approve deployments from those sources. Thank you for your feedback!

[deadlydog]

Thanks alcere. It's good to know that it's possible to approve from the notifications. I don't see any review/approval notifications for my deployments in the app, but I have disabled all of the push notifications within the app. I'm guessing if we disable the push notifications then that prevents them from showing up in the notifications section at all? I guess in the meantime, I'll enable the Deployment review push notification and see if approval notifications start showing up. Thanks!

[alcere]

Thanks for the follow-up, and I apologize for the late response. Unfortunately, I've been unavailable for the last couple of months. Do you see these types of notifications (for deployment reviews) using https://github.com/? To do so, can you double check in https://github.com/settings/notifications under the System section if you got Notifications for workflow runs enabled for that particular repository? This shouldn't be necessary to see push notification for deployment review, but I'd like to double check that you are seeing app notifications for deployment reviews and pinpoint the issue.

[deadlydog]

No, I do not see the notifications in github.com either. I had a deployment 2 weeks ago and it does not show up in the mobile app notifications or the website notifications:

These are my current system notification settings:

I can enable "On GitHub" notifications in addition to the Email notifications for Actions if you need; just let me know.

[alcere]

Yes please, give it a try enabling "On GitHub" and let me know the result please.

[deadlydog]

After enabling "On GitHub" and unchecking "Only notify for failed workflows" it now shows up in the GitHub.com notifications, but still does not show up in the mobile app notifications screen.

[alcere]

Thanks @deadlydog for your help! Certainly this looks like the problem to me. Please, let me do some investigations. I will reach you back as soon as possible!

[sam-utila]

Any news regarding this?

This is a crucial workflow - especially for reviewing access for teammates on production environments, which we would like to do using the mobile app.

[mccrearyp]

I also need this feature

[Thepitufo13]

Yes i agree

[charlescrain]

Agree this would be a very helpful feature

[YungBS]

https://discord.gg/gQGmxJHf?event=1336993171648942160

[ssbarnea]

Still broken, iphone. Unable to merge due to oath app lacking workflow permission but there is no option in the app to change the authentication token!

[ioannisj]

+1