Allow changes since last review to work with rebased branches #141845
Replies: 2 comments
-
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
Beta Was this translation helpful? Give feedback.
-
|
Here is a blog post mentioning this problem: https://daisy.wtf/writing/github-changes-since-last-review/ Suggesting the use of |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Select Topic Area
Product Feedback
Body
Our team uses the changes since last review a lot, but it does not work when branches are rebased and force-pushed as the rebased commits are treated as occurring after the last review.
If there was an option to show changes since my last review, but take into account the commit time (which is preserved after rebase), then the reviewers could use this feature to review only the commits since last review, even if the branch has been rebased and force-pushed since the last review. This option could also apply to the conversation stream so that comments appear in the logical historical order in relation to commits.
One workaround is to select multiple commits for review (shift-click in clunky in the UI when a lot of commits need selecting), another is to update the URL directly e.g.
pull/123/files/<first-un-reviewed-hash>-..HEADA nicer workaround would be 'Show commits since commit X' UI feature.
The workarounds require the reviewer to use command line tools or otherwise to figure out what the first un-reviewed commit was.
Beta Was this translation helpful? Give feedback.
All reactions