Load diff button on PR files changed should be visually distinct for large diffs vs generated #157549
Replies: 1 comment
-
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Select Topic Area
Product Feedback
Body
When performing a code review, the files changed tab will hide the contents of a file behind a Load diff button if the diff is large or if it's marked as a generated file in a .gitattributes file.
The problem is the Load diff button looks the same in both cases and the only way to determine why the contents were not rendered is the small text underneath the Load diff button having either:
or
I almost never want to review the generated files because in my code, they are generated deterministically and have automatic validation. However I always want to review large diffs because they are often the most important changes in the particular PR. The lack of visual distinction on the Load diff button depending on if they were generated files vs large diffs makes it easy to miss reviewing a large diff when performing a code review.
Example screenshot

Even a small change like making Load diff a different color such as gray for the generated file so that it's visually distinct from the blue Load diff on the large diff would make it a much better experience when reviewing a large PR.
Beta Was this translation helpful? Give feedback.
All reactions