Users should always be able to dismiss their own PR approval or request-changes, but the option sometimes disappears #179474
Replies: 2 comments
-
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
Beta Was this translation helpful? Give feedback.
-
|
Any updates? This is kind of ridiculous. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Select Topic Area
Bug
Body
It's not rare for a reviewer to approve a PR and then have a reason to un-approve it: for example, they might notice something they initially missed, or some team decision might have changed, or some other work might have made this work no longer valid.
Currently the process to dismiss an "approve" is, unintuitively, done from the "Changes approved" summary box at the bottom of the PR. Not only is this not necessarily an intuitive place to look, it isn't always available:
The option to dismiss an approve should always be present, and it should be in a stable, intuitive place. Ideally it should be an option next to every green tick and user chip indicating that you approved the PR, next to the "re-request review" (which some users already incorrectly believe dismisses approvals).
For example, here, there's no section summarising the reviews and approvals, so it's impossible for me to dismiss my approval:
Here's an example from the same repo where CI passed but a merge conflict has caused the "dismiss review" link to not show (this repo does not auto-dismiss reviews):
I think all of the above also applies to "Request changes" but I don't currently have a "request changes" I want to dismiss to test with.
Beta Was this translation helpful? Give feedback.
All reactions