Reviewers section in Pull Requests - Misaligned "Request Review" and "Comments" icons #191364
Replies: 3 comments
-
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
Beta Was this translation helpful? Give feedback.
-
|
Hi @tambiyash, |
Beta Was this translation helpful? Give feedback.
-
|
Just tested this on a few of our open PRs. You're 100% right – between 768px and 1012px viewport width, the "Request re-review" and comment icons are vertically off. The comment icon sits noticeably lower than the request icon next to it. What I observed:
Your fix is correct: The comment icon's parent /* Stylus / userstyle snippet */
.pr-reviewers-sidebar .reviewer-comment-icon {
align-self: center;
}One additional observation: This seems to only affect reviewers who have already submitted a review (so both icons appear). New reviewers who haven't reviewed yet only have the request icon, so it's fine. Good bug report – including the exact viewport range and the DOM fix saves the GitHub UI team a ton of time. Hopefully they pick this up in the next sprint. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
🏷️ Discussion Type
Bug
💬 Feature/Topic Area
Issues
Body
When viewport width is between 768px and 1012px, in the Reviewers section (right) on PR details page, the two icons for "Request Re-review" and "Comments" next to reviewer name are mis-aligned.
The fix can be a simple
align-self: centerto the comment icon<a>tag.Guidelines
Beta Was this translation helpful? Give feedback.
All reactions