Confusing tabs navigation in PR between commits and files changed

[fmigneault]

When a PR is opened, there are some tabs available to navigate between relevant items:

If one goes to "Files changed" tab to display modifications, and then selects a specific commit to be displayed via the "Changes from <selected-commits>" dropdown (as shown below), the page is then (IMO incorrectly) redirected to the "Commits" tab after commits have been selected.

selecting a commit

after selection of the displayed commit above (what seems wrong)

Since the user went to the "Files changed" specifically, and then used the dropdown offered on that tab to select specific "changed commits", the expected behavior would appear to be that only the diff relevant to newly selected commits would be displayed, instead of "all commits" from the PR that were initially displayed.

In other words, instead of being redirected to https://github.com/{org}/{repo}/pull/{num}/commits that simply lists the commits that we just selected, it would be expected that selecting those commits in the dropdown would redirect the user immediately to something like https://github.com/{org}/{repo}/commit/{selected-commit} (compare variant if many commits selected?).

Note that this result can be achieved by clicking the "view the diff" link at the bottom of the commits list (see above image), but that seems like an unnecessary additional step. That link is also not that obvious to spot if there are a lot of commits, since it goes all the way at the bottom of the page.

After clinking that "view the diff" link, the following page is displayed. I argue that the original "Changes from <selected-commits>" selection should have directed the user here immediately instead of going through the intermediate "Commits"+"view the diff" tab/link navigation.