GitHub Community
Help reviewers find what files to review based on CODEOWNERS #40474
Replies: 6 comments 14 replies
-
|
I also would highly recommend this as a feature request if it does not exists. We are operating a NX based monorepo with 8 domain owners and find ourselves in too detailed reviews. We want to encourage ownership of our domain owners so they should review and see all their changes to the code they own, but they should also be able to filter out any other file. We would also appreciate if we can configure this as the default based on the repository. |
Beta Was this translation helpful? Give feedback.
-
|
I searched for open source tools for this with no success |
Beta Was this translation helpful? Give feedback.
-
|
Actually there seem to be the function: If you select a Pull Request on a repository with a CODEOWNERS file and you go to a PR and select the Files Changed view, then in the filter section you find "Only files owned by you"... Then it seems to only show all the files of the changes that belong to files of the CODEOWNER teams that you are part of |
Beta Was this translation helpful? Give feedback.
-
|
Amazing find! I tried it and it worked beautifully. The docs are very useless though: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/filtering-files-in-a-pull-request#using-the-file-filter-dropdown |
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
I'm also not seeing this feature. I wonder if it's related to the GitHub Enterprise version we're using? |
Beta Was this translation helpful? Give feedback.
-
|
It looks like GitHub may have removed this feature when they rolled out the new PR experience (with the file tree on the left-hand-side)? Which at face-value seems like a pretty crazy move. I wonder if there is a magic string you can search for in the file tree 🤔 |
Beta Was this translation helpful? Give feedback.
-
|
I am not a GitHub administrator in our organisation, I still need to figure out if it's possible to set this as the default. But if the option is there I am pretty sure that its also configurable as default |
Beta Was this translation helpful? Give feedback.
-
|
I'm an admin and I don't see a way to turn this filter thing on or off. |
Beta Was this translation helpful? Give feedback.
-
|
Sad, for our company and the repository I am responsible for it would be great to enable it by default... For us ownership means that the CODEOWNERs check Pull Requests for quality but also ensure their domain code to not get any changes that harm maintainability or introduce side effect to our domain owners code... or its code usages Especially now where we are in the middle of a migration of an monolithic frontend application, developers touch many areas in their Pull requests to introduce domain boundaries... This creates a lot of review noise, so it would be nice in our current situation to have this enabled for our repository by default. Interested developers that want to review beyond their responsibility could turn off the filter if wanted, but its about effective and fast code reviews, where in our situation it would be better to turn the Filter Option "Only files owned by you" on for all PRs by default. |
Beta Was this translation helpful? Give feedback.
-
|
Are you saying it's not enabled for your org/repos by default? I don't see an option to configure this feature and I assume it's enabled by default and there's no way to change it. |
Beta Was this translation helpful? Give feedback.
-
It would be great to have the ability to select not only the files that you own, but the files you own per group. If I'm in 3 codeowner groups, it would be useful to be able to filter by one codeowner group at a time when reviewing PRs. |
Beta Was this translation helpful? Give feedback.
-
|
Agreed! it'd also be really useful to be able to send a URL to another team that would pre-filter the list of files to only those owned by their team, e.g. |
Beta Was this translation helpful? Give feedback.
-
|
🕒 Discussion Activity Reminder 🕒 This Discussion has been labeled as dormant by an automated system for having no activity in the last 60 days. Please consider one the following actions: 1️⃣ Close as Out of Date: If the topic is no longer relevant, close the Discussion as 2️⃣ Provide More Information: Share additional details or context — or let the community know if you've found a solution on your own. 3️⃣ Mark a Reply as Answer: If your question has been answered by a reply, mark the most helpful reply as the solution. Note: This dormant notification will only apply to Discussions with the Thank you for helping bring this Discussion to a resolution! 💬 |
Beta Was this translation helpful? Give feedback.
-
|
Hey all :) |
Beta Was this translation helpful? Give feedback.
-
|
https://chromewebstore.google.com/detail/github-code-owners-filter/jhbeenhmiadkocfjpmipapdnpgngbmmo |
Beta Was this translation helpful? Give feedback.
-
|
can you make one for firefox? that'd be amazing! |
Beta Was this translation helpful? Give feedback.
-
|
Awesome!! |
Beta Was this translation helpful? Give feedback.
-
|
Does this extension still work? |
Beta Was this translation helpful? Give feedback.
-
|
It doesn't work for me( |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Select Topic Area
Question
Body
For large PRs that touch many files, many teams will need to review and approve them. People find it hard to figure out what files their teams own and hence they need to review. Are there any tools that can assist in this regard?
I imagine a UI or a comment on the PR that shows the "owner" of each file in the PR. That way, a person knows exactly what files they need to review.
Beta Was this translation helpful? Give feedback.
All reactions