Broken action file won't appear in PR status checks and so makes the PR green #73048
Unanswered
Fryguy
asked this question in
Pull Requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Select Topic Area
Bug
Body
Recently, my team received a PR where a change was made to our ci.yaml workflow. The change to the workflow was expected, but actually had an invalid syntax change. Because of that, the workflow failed with a syntax error, however the failure wasn't shown in the PR status checks. Instead, because the other status checks were green, the PR was entirely shown as green. We ended up merging the PR because we thought it passed all of the status checks. Additionally, since it thought all checks were green, it visually collapsed them, so we didn't even notice that the actual CI checks never ran.
Here's the PR for reference: ManageIQ/manageiq#22761
Here's the failed actions run that was not reflected in the PR: https://github.com/ManageIQ/manageiq/actions/runs/6699929362 (broken link, but here's an old screenshot: ManageIQ/manageiq#22761 (comment))
Beta Was this translation helpful? Give feedback.
All reactions